Code Review / common / thrift.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 840ca08) | patch
[thrift] Move readMessageEnd inside of else block for accelerated protocol
authordweatherford <dev-null@apache.org>
Tue, 11 Mar 2008 02:42:45 +0000 (02:42 +0000)
committerdweatherford <dev-null@apache.org>
Tue, 11 Mar 2008 02:42:45 +0000 (02:42 +0000)
commit6b53bbb77881ceb149e468e7e5082f82b50c07d9
tree227086b49c7ee1ae3ebda22156179e0c0c08033dtree | snapshot
parent840ca085fcfe737554ede28088d4ae9adf457216commit | diff
[thrift] Move readMessageEnd inside of else block for accelerated protocol

Summary: Otherwise, readMessageEnd will be performed twice; once in the extension and once in PHP-land. Since TBinaryProtocol readMessageEnd is a no-op this isn't a huge deal, but it's bad style.
Reviewed By: mcslee
Test Plan: Inspect generated php code
Revert: OK
TracCamp Project: Thrift
DiffCamp Revision: 9155

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665567 13f79535-47bb-0310-9956-ffa450edef68
compiler/cpp/src/generate/t_php_generator.cc diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.