Code Review / common / thrift.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: bef54c0) | patch
Thrift compiler now enforces uniqueness of field identifiers
authorMark Slee <mcslee@apache.org>
Wed, 28 Nov 2007 22:28:13 +0000 (22:28 +0000)
committerMark Slee <mcslee@apache.org>
Wed, 28 Nov 2007 22:28:13 +0000 (22:28 +0000)
commit6f9ac3ffeb408392d1c3bb3945fe5b261f9e7817
tree10673a4dddea97323cf883a6edd42fe5d389cd9btree | snapshot
parentbef54c0647b22128c9035cfbc4d4b112ab5e68f8commit | diff
Thrift compiler now enforces uniqueness of field identifiers

Summary: The code would either not generate, or generate code with errors, if you did this beforehand. Now it's a die-fast stop hard error since this is absolultely always a wrong thing to do.

Reviewed By: dreiss

Test Plan: Test compiling a .thrift file with a repeated field identifier in a struct or arglist.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665379 13f79535-47bb-0310-9956-ffa450edef68
compiler/cpp/src/parse/t_field.h diff | blob | history
compiler/cpp/src/parse/t_struct.h diff | blob | history
compiler/cpp/src/thrifty.yy diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.