Code Review
/
common
/
thrift.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
review
|
tree
raw
|
patch
| inline |
side by side
(parent:
779b9ac
)
THRIFT-2495 JavaScript/Node string constants lack proper escaping
author
Jens Geyer
<jensg@apache.org>
Sun, 27 Apr 2014 16:29:50 +0000
(18:29 +0200)
committer
Jens Geyer
<jensg@apache.org>
Sun, 27 Apr 2014 16:30:40 +0000
(18:30 +0200)
Client: JS
Patch: Jens Geyer
compiler/cpp/src/generate/t_js_generator.cc
patch
|
blob
|
history
diff --git
a/compiler/cpp/src/generate/t_js_generator.cc
b/compiler/cpp/src/generate/t_js_generator.cc
index
5788749
..
be0c331
100644
(file)
--- a/
compiler/cpp/src/generate/t_js_generator.cc
+++ b/
compiler/cpp/src/generate/t_js_generator.cc
@@
-396,7
+396,7
@@
string t_js_generator::render_const_value(t_type* type, t_const_value* value) {
t_base_type::t_base tbase = ((t_base_type*)type)->get_base();
switch (tbase) {
case t_base_type::TYPE_STRING:
- out << "'" <<
value->get_string(
) << "'";
+ out << "'" <<
get_escaped_string(value
) << "'";
break;
case t_base_type::TYPE_BOOL:
out << (value->get_integer() > 0 ? "true" : "false");