Thrift-1277: Node.js serializes false booleans as null
authorJake Farrell <jfarrell@apache.org>
Sat, 5 Nov 2011 13:16:34 +0000 (13:16 +0000)
committerJake Farrell <jfarrell@apache.org>
Sat, 5 Nov 2011 13:16:34 +0000 (13:16 +0000)
Client: js
Patch: Hans Duedal

When serializing boolean types, false booleans are serialized as null instead of false switching to  using loose compare instead

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1197955 13f79535-47bb-0310-9956-ffa450edef68

compiler/cpp/src/generate/t_js_generator.cc

index d7d83bf..3d781a7 100644 (file)
@@ -688,7 +688,7 @@ void t_js_generator::generate_js_struct_writer(ofstream& out,
   indent(out) << "output.writeStructBegin('" << name << "');" << endl;
 
   for (f_iter = fields.begin(); f_iter != fields.end(); ++f_iter) {
-    out << indent() << "if (this." << (*f_iter)->get_name() << ") {" << endl;
+    out << indent() << "if (this." << (*f_iter)->get_name() << " != null) {" << endl;
     indent_up();
 
     indent(out) <<