Code Review
/
common
/
thrift.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
review
|
tree
raw
|
patch
| inline |
side by side
(parent:
b54fbd3
)
THRIFT-2172 Java compiler allocates optionals array for every struct with an optional...
author
Roger Meier
<roger@apache.org>
Wed, 13 Nov 2013 21:08:06 +0000
(22:08 +0100)
committer
Roger Meier
<roger@apache.org>
Wed, 13 Nov 2013 21:08:06 +0000
(22:08 +0100)
Patch: Andrew Gaul
compiler/cpp/src/generate/t_java_generator.cc
patch
|
blob
|
history
diff --git
a/compiler/cpp/src/generate/t_java_generator.cc
b/compiler/cpp/src/generate/t_java_generator.cc
index
b8cd930
..
e978af8
100644
(file)
--- a/
compiler/cpp/src/generate/t_java_generator.cc
+++ b/
compiler/cpp/src/generate/t_java_generator.cc
@@
-1371,7
+1371,7
@@
void t_java_generator::generate_java_struct_definition(ofstream &out,
}
if (optionals > 0) {
- std::string output_string = "private _Fields optionals[] = {";
+ std::string output_string = "private
static final
_Fields optionals[] = {";
for (m_iter = members.begin(); m_iter != members.end(); ++m_iter) {
if ((*m_iter)->get_req() == t_field::T_OPTIONAL) {
output_string = output_string + "_Fields." + constant_name((*m_iter)->get_name()) + ",";