THRIFT-2404 emit warning on (typically inefficient) list<byte>

Patch: Jens Geyer

diff --git a/compiler/cpp/src/main.cc b/compiler/cpp/src/main.cc
index 781db3b..e1c9394 100755 (executable)
--- a/compiler/cpp/src/main.cc
+++ b/compiler/cpp/src/main.cc
@@ -661,6 +661,20 @@ void generate_all_fingerprints(t_program* program) {
   */
 }
 
+
+/**
+ * Emits a warning on list<byte>, binary type is typically a much better choice.
+ */
+void check_for_list_of_bytes(t_type* list_elem_type) {
+  if((g_parse_mode == PROGRAM) && (list_elem_type != NULL) && list_elem_type->is_base_type()) {
+    t_base_type* tbase = (t_base_type*)list_elem_type;
+    if(tbase->get_base() == t_base_type::TYPE_BYTE) {
+      pwarning(1,"Consider using the more efficient \"binary\" type instead of \"list<byte>\".");
+    }
+  }
+}
+
+
 /**
  * Prints the version number
  */

diff --git a/compiler/cpp/src/main.h b/compiler/cpp/src/main.h
index 87af5f6..f737e3f 100644 (file)
--- a/compiler/cpp/src/main.h
+++ b/compiler/cpp/src/main.h
@@ -88,6 +88,10 @@ char* clean_up_doctext(char* doctext);
  */
 void declare_valid_program_doctext();
 
+/**
+ * Emits a warning on list<byte>, binary type is typically a much better choice.
+ */
+void check_for_list_of_bytes(t_type* list_elem_type);
 
 /**
  * Flex utilities

diff --git a/compiler/cpp/src/thrifty.yy b/compiler/cpp/src/thrifty.yy
index fd72b70..7c4a90b 100755 (executable)
--- a/compiler/cpp/src/thrifty.yy
+++ b/compiler/cpp/src/thrifty.yy
@@ -1213,6 +1213,7 @@ ListType:
   tok_list '<' FieldType '>' CppType
     {
       pdebug("ListType -> tok_list<FieldType>");
+      check_for_list_of_bytes($3);
       $$ = new t_list($3);
       if ($5 != NULL) {
         ((t_container*)$$)->set_cpp_name(std::string($5));