Thrift: Fix a bug in the skip function in Python's fastbinary.c
authorDavid Reiss <dreiss@apache.org>
Thu, 14 Feb 2008 20:20:08 +0000 (20:20 +0000)
committerDavid Reiss <dreiss@apache.org>
Thu, 14 Feb 2008 20:20:08 +0000 (20:20 +0000)
Reviewed By: mcslee

Other Notes:
Submitted by Ben Maurer (the original author).

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665479 13f79535-47bb-0310-9956-ffa450edef68

lib/py/src/protocol/fastbinary.c

index 3b7b5c0..5625f4b 100644 (file)
@@ -806,7 +806,7 @@ skip(DecodeBuffer* input, TType type) {
 
   }
 
-  return false;
+  return true;
 
 #undef SKIPBYTES
 }
@@ -851,6 +851,8 @@ decode_struct(DecodeBuffer* input, PyObject* output, PyObject* spec_seq) {
     if (item_spec == Py_None) {
       if (!skip(input, type)) {
         return false;
+      } else {
+        continue;
       }
     }