fix for issue #136
authorErich Smith <heartquest@gmail.com>
Sun, 20 May 2012 17:18:04 +0000 (13:18 -0400)
committerErich Smith <heartquest@gmail.com>
Sun, 20 May 2012 17:18:04 +0000 (13:18 -0400)
issue #136 was found to be caused by an aliased 'ls' command that
generated rogue values for 'plugin' in the enable/disable-plugin()
functions. this commit fixes that by forcing the shell to disregard
aliased 'ls' commands.

lib/helpers.bash

index d0c16b8..dfd64b0 100644 (file)
@@ -74,7 +74,7 @@ disable-plugin ()
             fi
         done
     else
-        typeset plugin=$(ls $BASH_IT/plugins/enabled/$1.*bash 2>/dev/null | head -1)
+        typeset plugin=$(command ls $BASH_IT/plugins/enabled/$1.*bash 2>/dev/null | head -1)
         if [ ! -h $plugin ]; then
             printf '%s\n' 'sorry, that does not appear to be an enabled plugin.'
             return
@@ -107,7 +107,7 @@ enable-plugin ()
             fi
         done
     else
-        typeset plugin=$(ls $BASH_IT/plugins/available/$1.*bash 2>/dev/null | head -1)
+        typeset plugin=$(command ls $BASH_IT/plugins/available/$1.*bash 2>/dev/null | head -1)
         if [ -z "$plugin" ]; then
             printf '%s\n' 'sorry, that does not appear to be an available plugin.'
             return