THRIFT-309. Make Thrift's C# mapping .NET 2.0 (Mono 1.2.4) compatible
authorDavid Reiss <dreiss@apache.org>
Fri, 13 Feb 2009 03:09:52 +0000 (03:09 +0000)
committerDavid Reiss <dreiss@apache.org>
Fri, 13 Feb 2009 03:09:52 +0000 (03:09 +0000)
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@743963 13f79535-47bb-0310-9956-ffa450edef68

38 files changed:
compiler/cpp/src/generate/t_csharp_generator.cc
configure.ac
lib/csharp/Makefile.am
lib/csharp/src/Collections/THashSet.cs [new file with mode: 0644]
lib/csharp/src/Protocol/TBinaryProtocol.cs
lib/csharp/src/Protocol/TField.cs
lib/csharp/src/Protocol/TList.cs
lib/csharp/src/Protocol/TMap.cs
lib/csharp/src/Protocol/TMessage.cs
lib/csharp/src/Protocol/TMessageType.cs
lib/csharp/src/Protocol/TProtocol.cs
lib/csharp/src/Protocol/TProtocolException.cs
lib/csharp/src/Protocol/TProtocolFactory.cs
lib/csharp/src/Protocol/TProtocolUtil.cs
lib/csharp/src/Protocol/TSet.cs
lib/csharp/src/Protocol/TStruct.cs
lib/csharp/src/Protocol/TType.cs
lib/csharp/src/Server/TServer.cs
lib/csharp/src/Server/TSimpleServer.cs
lib/csharp/src/Server/TThreadPoolServer.cs
lib/csharp/src/Server/TThreadedServer.cs
lib/csharp/src/TApplicationException.cs
lib/csharp/src/TProcessor.cs
lib/csharp/src/Thrift.csproj
lib/csharp/src/Transport/TBufferedTransport.cs
lib/csharp/src/Transport/TServerSocket.cs
lib/csharp/src/Transport/TServerTransport.cs
lib/csharp/src/Transport/TSocket.cs
lib/csharp/src/Transport/TStreamTransport.cs
lib/csharp/src/Transport/TTransport.cs
lib/csharp/src/Transport/TTransportException.cs
lib/csharp/src/Transport/TTransportFactory.cs
test/csharp/CSharpServer.cs
test/csharp/ThriftTest/Program.cs
test/csharp/ThriftTest/TestClient.cs
test/csharp/ThriftTest/TestServer.cs
test/csharp/ThriftTest/ThriftTest.csproj
test/csharp/ThriftTest/maketest.sh [new file with mode: 0755]

index 2463c46..df1d59c 100644 (file)
@@ -145,7 +145,8 @@ string t_csharp_generator::csharp_type_usings() {
     "using System.Collections.Generic;\n" +
     "using System.Text;\n" +
     "using System.IO;\n" +
-    "using Thrift;\n";
+    "using Thrift;\n" +
+    "using Thrift.Collections;\n";
 }
 
 string t_csharp_generator::csharp_thrift_usings() {
@@ -1534,7 +1535,7 @@ string t_csharp_generator::type_name(t_type* ttype, bool in_container, bool in_i
       ", " + type_name(tmap->get_val_type(), true) + ">";
   } else if (ttype->is_set()) {
     t_set* tset = (t_set*) ttype;
-    return "HashSet<" + type_name(tset->get_elem_type(), true) + ">";
+    return "THashSet<" + type_name(tset->get_elem_type(), true) + ">";
   } else if (ttype->is_list()) {
     t_list* tlist = (t_list*) ttype;
     return "List<" + type_name(tlist->get_elem_type(), true) + ">";
index f88bf49..040ae06 100644 (file)
@@ -41,9 +41,11 @@ AM_CONDITIONAL([AMX_HAVE_ZLIB], [test "$success" = "yes"])
 
 AX_THRIFT_LIB(csharp, [C#], yes)
 if test "$with_csharp" = "yes";  then
-  PKG_CHECK_MODULES(MONO, mono >= 1.2.6, have_mono=yes, have_mono=no)
+  PKG_CHECK_MODULES(MONO, mono >= 2.0.0, net_3_5=yes, net_3_5=no)
+  PKG_CHECK_MODULES(MONO, mono >= 1.2.4, have_mono=yes, have_mono=no)
 fi
 AM_CONDITIONAL(WITH_MONO, [test "$have_mono" = "yes"])
+AM_CONDITIONAL(NET_2_0, [test "$net_3_5" = "no"])
 
 AX_THRIFT_LIB(java, [Java], yes)
 if test "$with_java" = "yes";  then
index 710cd12..4ceb9e0 100644 (file)
@@ -1,4 +1,5 @@
 THRIFTCODE= \
+            src/Collections/THashSet.cs \
             src/Protocol/TBase.cs \
             src/Protocol/TProtocolException.cs \
             src/Protocol/TProtocolFactory.cs \
@@ -31,10 +32,14 @@ THRIFTCODE= \
 
 CSC=gmcs
 
+if NET_2_0
+MONO_DEFINES=/d:NET_2_0
+endif
+
 all-local: Thrift.dll
 
 Thrift.dll: $(THRIFTCODE)
-       $(CSC) $(THRIFTCODE) /out:Thrift.dll /target:library /langversion:linq
+       $(CSC) $(THRIFTCODE) /out:Thrift.dll /target:library $(MONO_DEFINES)
 
 clean-local:
        $(RM) Thrift.dll
diff --git a/lib/csharp/src/Collections/THashSet.cs b/lib/csharp/src/Collections/THashSet.cs
new file mode 100644 (file)
index 0000000..51a09b5
--- /dev/null
@@ -0,0 +1,142 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+using System;
+using System.Collections;
+using System.Collections.Generic;
+
+namespace Thrift.Collections
+{
+       public class THashSet<T> : ICollection<T>
+       {
+#if NET_2_0
+               TDictSet<T> set = new TDictSet<T>();
+#else
+               HashSet<T> set = new HashSet<T>();
+#endif
+               public int Count
+               {
+                       get { return set.Count; }
+               }
+
+               public bool IsReadOnly
+               {
+                       get { return set.IsReadOnly; }
+               }
+
+               public void Add(T item)
+               {
+                       set.Add(item);
+               }
+
+               public void Clear()
+               {
+                       set.Clear();
+               }
+
+               public bool Contains(T item)
+               {
+                       return set.Contains(item);
+               }
+
+               public void CopyTo(T[] array, int arrayIndex)
+               {
+                       set.CopyTo(array, arrayIndex);
+               }
+
+               public IEnumerator GetEnumerator()
+               {
+                       return set.GetEnumerator();
+               }
+
+               IEnumerator<T> IEnumerable<T>.GetEnumerator()
+               {
+                       return ((IEnumerable<T>)set).GetEnumerator();
+               }
+
+               public bool Remove(T item)
+               {
+                       return set.Remove(item);
+               }
+
+#if NET_2_0
+               private class TDictSet<V> : ICollection<V>
+               {
+                       Dictionary<V, TDictSet<V>> dict = new Dictionary<V, TDictSet<V>>();
+
+                       public int Count
+                       {
+                               get { return dict.Count; }
+                       }
+
+                       public bool IsReadOnly
+                       {
+                               get { return false; }
+                       }
+
+                       public IEnumerator GetEnumerator()
+                       {
+                               return ((IEnumerable)dict.Keys).GetEnumerator();
+                       }
+
+                       IEnumerator<V> IEnumerable<V>.GetEnumerator()
+                       {
+                               return dict.Keys.GetEnumerator();
+                       }
+
+                       public bool Add(V item)
+                       {
+                               if (!dict.ContainsKey(item))
+                               {
+                                       dict[item] = this;
+                                       return true;
+                               }
+
+                               return false;
+                       }
+
+                       void ICollection<V>.Add(V item)
+                       {
+                               Add(item);
+                       }
+
+                       public void Clear()
+                       {
+                               dict.Clear();
+                       }
+
+                       public bool Contains(V item)
+                       {
+                               return dict.ContainsKey(item);
+                       }
+
+                       public void CopyTo(V[] array, int arrayIndex)
+                       {
+                               dict.Keys.CopyTo(array, arrayIndex);
+                       }
+
+                       public bool Remove(V item)
+                       {
+                               return dict.Remove(item);
+                       }
+               }
+#endif
+       }
+
+}
index 5df2021..2f2f4a1 100644 (file)
@@ -12,7 +12,6 @@
 //  http://developers.facebook.com/thrift/using
 
 using System;
-using System.Collections.Generic;
 using System.Text;
 using Thrift.Transport;
 
index 93c0738..bda1760 100644 (file)
@@ -18,30 +18,34 @@ namespace Thrift.Protocol
 {
        public struct TField
        {
+               private string name;
+               private TType type;
+               private short id;
+
                public TField(string name, TType type, short id)
                        :this()
                {
-                       Name = name;
-                       Type = type;
-                       ID = id;
+                       this.name = name;
+                       this.type = type;
+                       this.id = id;
                }
 
                public string Name
                {
-                       get;
-                       set;
+                       get { return name; }
+                       set { name = value; }
                }
 
                public TType Type
                {
-                       get;
-                       set;
+                       get { return type; }
+                       set { type = value; }
                }
 
                public short ID
                {
-                       get;
-                       set;
+                       get { return id; }
+                       set { id = value; }
                }
        }
 }
index ccce522..5e4fa39 100644 (file)
@@ -18,23 +18,26 @@ namespace Thrift.Protocol
 {
        public struct TList
        {
+               private TType elementType;
+               private int count;
+
                public TList(TType elementType, int count)
                        :this()
                {
-                       ElementType = elementType;
-                       Count = count;
+                       this.elementType = elementType;
+                       this.count = count;
                }
 
                public TType ElementType
                {
-                       get;
-                       set;
+                       get { return elementType; }
+                       set { elementType = value; }
                }
 
                public int Count
                {
-                       get;
-                       set;
+                       get { return count; }
+                       set { count = value; }
                }
        }
 }
index a71e52a..4813027 100644 (file)
@@ -18,30 +18,34 @@ namespace Thrift.Protocol
 {
        public struct TMap
        {
+               private TType keyType;
+               private TType valueType;
+               private int count;
+
                public TMap(TType keyType, TType valueType, int count)
                        :this()
                {
-                       KeyType = keyType;
-                       ValueType = valueType;
-                       Count = count;
+                       this.keyType = keyType;
+                       this.valueType = valueType;
+                       this.count = count;
                }
 
                public TType KeyType
                {
-                       get;
-                       set;
+                       get { return keyType; }
+                       set { keyType = value; }
                }
 
                public TType ValueType
                {
-                       get;
-                       set;
+                       get { return valueType; }
+                       set { valueType = value; }
                }
 
                public int Count
                {
-                       get;
-                       set;
+                       get { return count; }
+                       set { count = value; }
                }
        }
 }
index 15dfce0..3818da0 100644 (file)
@@ -18,30 +18,34 @@ namespace Thrift.Protocol
 {
        public struct TMessage
        {
+               private string name;
+               private TMessageType type;
+               private int seqID;
+
                public TMessage(string name, TMessageType type, int seqid)
                        :this()
                {
-                       Name = name;
-                       Type = type;
-                       SeqID = seqid;
+                       this.name = name;
+                       this.type = type;
+                       this.seqID = seqid;
                }
 
                public string Name
                {
-                       get;
-                       set;
+                       get { return name; }
+                       set { name = value; }
                }
 
                public TMessageType Type
                {
-                       get;
-                       set;
+                       get { return type; }
+                       set { type = value; }
                }
 
                public int SeqID
                {
-                       get;
-                       set;
+                       get { return seqID; }
+                       set { seqID = value; }
                }
        }
 }
index 6e6ead7..d458d53 100644 (file)
@@ -11,8 +11,6 @@
 //  http://developers.facebook.com/thrift/using
 
 using System;
-using System.Collections.Generic;
-using System.Text;
 
 namespace Thrift.Protocol
 {
index 2702ad8..6e48fac 100644 (file)
@@ -11,7 +11,6 @@
 //  http://developers.facebook.com/thrift/using
 
 using System;
-using System.Collections.Generic;
 using System.Text;
 using Thrift.Transport;
 
index db38d88..f43a7cc 100644 (file)
@@ -1,6 +1,4 @@
 using System;
-using System.Collections.Generic;
-using System.Text;
 
 namespace Thrift.Protocol
 {
index 756bb5e..4e15bb1 100644 (file)
@@ -10,8 +10,6 @@
 //  See accompanying file LICENSE or visit the Thrift site at:
 //  http://developers.facebook.com/thrift/using
 using System;
-using System.Collections.Generic;
-using System.Text;
 using Thrift.Transport;
 
 namespace Thrift.Protocol
index a65ea0f..577182c 100644 (file)
@@ -11,8 +11,6 @@
 //  http://developers.facebook.com/thrift/using
 
 using System;
-using System.Collections.Generic;
-using System.Text;
 
 namespace Thrift.Protocol
 {
index 0bfc29e..cdf3849 100644 (file)
@@ -18,23 +18,26 @@ namespace Thrift.Protocol
 {
        public struct TSet
        {
+               private TType elementType;
+               private int count;
+
                public TSet(TType elementType, int count)
                        :this()
                {
-                       ElementType = elementType;
-                       Count = count;
+                       this.elementType = elementType;
+                       this.count = count;
                }
 
                public TType ElementType
                {
-                       get;
-                       set;
+                       get { return elementType; }
+                       set { elementType = value; }
                }
 
                public int Count
                {
-                       get;
-                       set;
+                       get { return count; }
+                       set { count = value; }
                }
        }
 }
index 62f60fd..1a7d572 100644 (file)
@@ -17,16 +17,18 @@ namespace Thrift.Protocol
 {
        public struct TStruct
        {
+               private string name;
+
                public TStruct(string name)
                        :this()
                {
-                       Name = name;
+                       this.name = name;
                }
 
                public string Name
                {
-                       get;
-                       set;
+                       get { return name; }
+                       set { name = value; }
                }
        }
 }
index 257ac6b..5cc6178 100644 (file)
@@ -11,8 +11,6 @@
 //  http://developers.facebook.com/thrift/using
 
 using System;
-using System.Collections.Generic;
-using System.Text;
 
 namespace Thrift.Protocol
 {
index afb2b9f..f5f617a 100644 (file)
@@ -11,7 +11,6 @@
 //  http://developers.facebook.com/thrift/using
 
 using System;
-using System.Collections.Generic;
 using Thrift.Protocol;
 using Thrift.Transport;
 using System.IO;
index 95f3962..912b4a3 100644 (file)
@@ -10,8 +10,6 @@
 //  See accompanying file LICENSE or visit the Thrift site at:
 //  http://developers.facebook.com/thrift/using
 using System;
-using System.Collections.Generic;
-using System.Text;
 using Thrift.Transport;
 using Thrift.Protocol;
 
index b44487f..e3c5cde 100644 (file)
@@ -10,8 +10,6 @@
 //  See accompanying file LICENSE or visit the Thrift site at:
 //  http://developers.facebook.com/thrift/using
 using System;
-using System.Collections.Generic;
-using System.Text;
 using System.Threading;
 using Thrift.Protocol;
 using Thrift.Transport;
index a4d33a5..2928f31 100644 (file)
@@ -11,8 +11,8 @@
 //  http://developers.facebook.com/thrift/using
 using System;
 using System.Collections.Generic;
-using System.Text;
 using System.Threading;
+using Thrift.Collections;
 using Thrift.Protocol;
 using Thrift.Transport;
 
@@ -28,7 +28,7 @@ namespace Thrift.Server
                private readonly int maxThreads;
 
                private Queue<TTransport> clientQueue;
-               private HashSet<Thread> clientThreads;
+               private THashSet<Thread> clientThreads;
                private object clientLock;
                private Thread workerThread;
 
@@ -73,7 +73,7 @@ namespace Thrift.Server
                        this.maxThreads = maxThreads;
                        clientQueue = new Queue<TTransport>();
                        clientLock = new object();
-                       clientThreads = new HashSet<Thread>();
+                       clientThreads = new THashSet<Thread>();
                }
 
                /// <summary>
index 4248664..cb3353b 100644 (file)
@@ -11,8 +11,6 @@
 //  http://developers.facebook.com/thrift/using
 
 using System;
-using System.Collections.Generic;
-using System.Text;
 using Thrift.Protocol;
 
 namespace Thrift
index 2cbddd7..679e3f6 100644 (file)
@@ -11,8 +11,6 @@
 //  http://developers.facebook.com/thrift/using
 
 using System;
-using System.Collections.Generic;
-using System.Text;
 using Thrift.Protocol;
 
 namespace Thrift
index 9f3f620..1eb4355 100644 (file)
     <Reference Include="System.Core">
       <RequiredTargetFramework>3.5</RequiredTargetFramework>
     </Reference>
-    <Reference Include="System.Data" />
-    <Reference Include="System.Data.DataSetExtensions" />
-    <Reference Include="System.Drawing" />
-    <Reference Include="System.Windows.Forms" />
-    <Reference Include="System.Xml" />
-    <Reference Include="System.Xml.Linq" />
   </ItemGroup>
   <ItemGroup>
+    <Compile Include="Collections\THashSet.cs" />
     <Compile Include="Protocol\TBase.cs" />
     <Compile Include="Protocol\TBinaryProtocol.cs" />
     <Compile Include="Protocol\TField.cs" />
index 96a0741..bd4ba95 100644 (file)
@@ -7,9 +7,6 @@
 //
 
 using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
 using System.IO;
 
 namespace Thrift.Transport
index a6caf90..3559ce7 100644 (file)
@@ -9,8 +9,6 @@
 //  All rights reserved.
 
 using System;
-using System.Collections.Generic;
-using System.Text;
 using System.Net.Sockets;
 
 
index 6b05a15..bff62e1 100644 (file)
@@ -8,8 +8,6 @@
 //  Copyright (C) 2007 imeem, inc. <http://www.imeem.com>
 //  All rights reserved.
 using System;
-using System.Collections.Generic;
-using System.Text;
 
 namespace Thrift.Transport
 {
index c790fce..cc7eefd 100644 (file)
@@ -10,8 +10,6 @@
 //
 
 using System;
-using System.Collections.Generic;
-using System.Text;
 using System.Net.Sockets;
 
 namespace Thrift.Transport
index ca14ecf..f74f59a 100644 (file)
@@ -10,8 +10,6 @@
 //
 
 using System;
-using System.Collections.Generic;
-using System.Text;
 using System.IO;
 
 namespace Thrift.Transport
index 915cbc9..c95d98e 100644 (file)
@@ -10,8 +10,6 @@
 //
 
 using System;
-using System.Collections.Generic;
-using System.Text;
 
 namespace Thrift.Transport
 {
index daf21d8..fa1f6b5 100644 (file)
@@ -10,8 +10,6 @@
 //
 
 using System;
-using System.Collections.Generic;
-using System.Text;
 
 namespace Thrift.Transport
 {
index a0a6c2b..0280649 100644 (file)
@@ -9,9 +9,6 @@
 //  All rights reserved.
 //
 using System;
-using System.Collections.Generic;
-using System.Text;
-
 
 namespace Thrift.Transport
 {
index 32cc703..5eef03b 100644 (file)
@@ -1,7 +1,5 @@
 \feffusing System;\r
 using System.Collections.Generic;\r
-using System.Linq;\r
-using System.Text;\r
 using Thrift.Server;\r
 using Thrift.Transport;\r
 \r
index 09bd84f..3860525 100644 (file)
@@ -4,8 +4,6 @@
 // http://developers.facebook.com/thrift/
 
 using System;
-using System.Collections.Generic;
-using System.Text;
 using Thrift.Transport;
 using Thrift.Protocol;
 using Thrift.Test; //generated code
index bcdb00e..42b21b8 100644 (file)
@@ -1,11 +1,10 @@
 using System;
 using System.Collections.Generic;
-using System.Text;
-
+using System.Threading;
+using Thrift.Collections;
 using Thrift.Protocol;
 using Thrift.Transport;
 using Thrift.Test;
-using System.Threading;
 
 namespace Test
 {
@@ -247,7 +246,7 @@ namespace Test
                        Console.WriteLine("}");
 
                        //set
-                       HashSet<int> setout = new HashSet<int>();
+                       THashSet<int> setout = new THashSet<int>();
                        for (int j = -2; j < 3; j++)
                        {
                                setout.Add(j);
@@ -268,7 +267,7 @@ namespace Test
                        }
                        Console.Write("})");
 
-                       HashSet<int> setin = client.testSet(setout);
+                       THashSet<int> setin = client.testSet(setout);
 
                        Console.Write(" = {");
                        first = true;
index 4efe4b4..18952d4 100644 (file)
@@ -4,9 +4,8 @@
 // http://developers.facebook.com/thrift/
 using System;
 using System.Collections.Generic;
-using System.Text;
+using Thrift.Collections;
 using Thrift.Test; //generated code
-
 using Thrift.Transport;
 using Thrift.Protocol;
 using Thrift.Server;
@@ -99,7 +98,7 @@ namespace Test
                                return thing;
                        }
 
-                       public HashSet<int> testSet(HashSet<int> thing)
+                       public THashSet<int> testSet(THashSet<int> thing)
                        {
                                Console.WriteLine("testSet({");
                                bool first = true;
@@ -305,10 +304,13 @@ namespace Test
                                TServer serverEngine;
 
                                // Simple Server
-                               // serverEngine = new TSimpleServer(testProcessor, tServerSocket);
+                               serverEngine = new TSimpleServer(testProcessor, tServerSocket);
 
                                // ThreadPool Server
-                               serverEngine = new TThreadPoolServer(testProcessor, tServerSocket);
+                               // serverEngine = new TThreadPoolServer(testProcessor, tServerSocket);
+
+                               // Threaded Server
+                               // serverEngine = new TThreadedServer(testProcessor, tServerSocket);
 
                                testHandler.server = serverEngine;
 
index 8e61173..3f427fd 100644 (file)
   </PropertyGroup>
   <ItemGroup>
     <Reference Include="System" />
-    <Reference Include="System.Core">
-      <RequiredTargetFramework>3.5</RequiredTargetFramework>
-    </Reference>
-    <Reference Include="System.Xml.Linq">
-      <RequiredTargetFramework>3.5</RequiredTargetFramework>
-    </Reference>
-    <Reference Include="System.Data.DataSetExtensions">
-      <RequiredTargetFramework>3.5</RequiredTargetFramework>
-    </Reference>
-    <Reference Include="System.Data" />
-    <Reference Include="System.Xml" />
     <Reference Include="ThriftImpl, Version=0.0.0.0, Culture=neutral, processorArchitecture=MSIL">
       <SpecificVersion>False</SpecificVersion>
       <HintPath>.\ThriftImpl.dll</HintPath>
@@ -117,6 +106,6 @@ $(ProjectDir)\..\..\..\compiler\cpp\thrift.exe -csharp -o $(ProjectDir) $(Projec
 
 cd $(ProjectDir)
 
-C:\Windows\Microsoft.NET\Framework\v3.5\Csc.exe /t:library /out:.\ThriftImpl.dll /recurse:.\gen-csharp\* /reference:$(ProjectDir)..\..\..\lib\csharp\src\bin\Debug\Thrift.dll</PreBuildEvent>
+$(MSBuildToolsPath)\Csc.exe /t:library /out:.\ThriftImpl.dll /recurse:.\gen-csharp\* /reference:$(ProjectDir)..\..\..\lib\csharp\src\bin\Debug\Thrift.dll</PreBuildEvent>
   </PropertyGroup>
 </Project>
diff --git a/test/csharp/ThriftTest/maketest.sh b/test/csharp/ThriftTest/maketest.sh
new file mode 100755 (executable)
index 0000000..aab34b7
--- /dev/null
@@ -0,0 +1,3 @@
+#!/bin/sh
+../../../compiler/cpp/thrift --gen csharp -o . ../../ThriftTest.thrift
+gmcs /t:library /out:./ThriftImpl.dll /recurse:./gen-csharp/* /reference:../../../lib/csharp/Thrift.dll