From: Jens Geyer <jensg@apache.org>
Date: Sun, 27 Apr 2014 16:29:50 +0000 (+0200)
Subject: THRIFT-2495 JavaScript/Node string constants lack proper escaping
X-Git-Url: https://source.supwisdom.com/gerrit/gitweb?a=commitdiff_plain;h=3290336e33a257d77d731aa8f4c86af84bd8f9ad;p=common%2Fthrift.git

THRIFT-2495 JavaScript/Node string constants lack proper escaping
Client: JS
Patch: Jens Geyer
---

diff --git a/compiler/cpp/src/generate/t_js_generator.cc b/compiler/cpp/src/generate/t_js_generator.cc
index 57887493..be0c3313 100644
--- a/compiler/cpp/src/generate/t_js_generator.cc
+++ b/compiler/cpp/src/generate/t_js_generator.cc
@@ -396,7 +396,7 @@ string t_js_generator::render_const_value(t_type* type, t_const_value* value) {
     t_base_type::t_base tbase = ((t_base_type*)type)->get_base();
     switch (tbase) {
     case t_base_type::TYPE_STRING:
-      out << "'" << value->get_string() << "'";
+      out << "'" << get_escaped_string(value) << "'";
       break;
     case t_base_type::TYPE_BOOL:
       out << (value->get_integer() > 0 ? "true" : "false");