From: Jake Farrell Date: Sat, 5 Nov 2011 13:16:34 +0000 (+0000) Subject: Thrift-1277: Node.js serializes false booleans as null X-Git-Tag: 0.8.0~31 X-Git-Url: https://source.supwisdom.com/gerrit/gitweb?a=commitdiff_plain;h=48bb0e2ad4e5fb10cc832e05a2af4f505c5b0922;p=common%2Fthrift.git Thrift-1277: Node.js serializes false booleans as null Client: js Patch: Hans Duedal When serializing boolean types, false booleans are serialized as null instead of false switching to using loose compare instead git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1197955 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/compiler/cpp/src/generate/t_js_generator.cc b/compiler/cpp/src/generate/t_js_generator.cc index d7d83bfb..3d781a76 100644 --- a/compiler/cpp/src/generate/t_js_generator.cc +++ b/compiler/cpp/src/generate/t_js_generator.cc @@ -688,7 +688,7 @@ void t_js_generator::generate_js_struct_writer(ofstream& out, indent(out) << "output.writeStructBegin('" << name << "');" << endl; for (f_iter = fields.begin(); f_iter != fields.end(); ++f_iter) { - out << indent() << "if (this." << (*f_iter)->get_name() << ") {" << endl; + out << indent() << "if (this." << (*f_iter)->get_name() << " != null) {" << endl; indent_up(); indent(out) <<