From: Roger Meier <roger@apache.org>
Date: Wed, 13 Nov 2013 21:08:06 +0000 (+0100)
Subject: THRIFT-2172 Java compiler allocates optionals array for every struct with an optional... 
X-Git-Url: https://source.supwisdom.com/gerrit/gitweb?a=commitdiff_plain;h=5df24f7afb05fe25352f1fe5fff0206eb0103a3d;p=common%2Fthrift.git

THRIFT-2172 Java compiler allocates optionals array for every struct with an optional field
Patch: Andrew Gaul
---

diff --git a/compiler/cpp/src/generate/t_java_generator.cc b/compiler/cpp/src/generate/t_java_generator.cc
index b8cd930b..e978af80 100644
--- a/compiler/cpp/src/generate/t_java_generator.cc
+++ b/compiler/cpp/src/generate/t_java_generator.cc
@@ -1371,7 +1371,7 @@ void t_java_generator::generate_java_struct_definition(ofstream &out,
     }
 
     if (optionals > 0) {
-      std::string output_string = "private _Fields optionals[] = {";
+      std::string output_string = "private static final _Fields optionals[] = {";
       for (m_iter = members.begin(); m_iter != members.end(); ++m_iter) {
         if ((*m_iter)->get_req() == t_field::T_OPTIONAL) {
           output_string = output_string + "_Fields." + constant_name((*m_iter)->get_name()) + ",";