From: Bryan Duxbury <bryanduxbury@apache.org>
Date: Thu, 22 Apr 2010 00:27:41 +0000 (+0000)
Subject: THRIFT-763. java: Variable capture bug in generated struct compareTo
X-Git-Tag: 0.3.0~35
X-Git-Url: https://source.supwisdom.com/gerrit/gitweb?a=commitdiff_plain;h=60229785cb858c919f832e8ce8155c7c4ce06012;p=common%2Fthrift.git

THRIFT-763. java: Variable capture bug in generated struct compareTo

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@936583 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/compiler/cpp/src/generate/t_java_generator.cc b/compiler/cpp/src/generate/t_java_generator.cc
index 970c32c3..8786d401 100644
--- a/compiler/cpp/src/generate/t_java_generator.cc
+++ b/compiler/cpp/src/generate/t_java_generator.cc
@@ -1387,7 +1387,7 @@ void t_java_generator::generate_java_struct_compare_to(ofstream& out, t_struct*
     indent(out) << "}" << endl;
 
     indent(out) << "if (" << generate_isset_check(field) << ") {";
-    indent(out) << "  lastComparison = TBaseHelper.compareTo(" << field->get_name() << ", typedOther." << field->get_name() << ");" << endl;
+    indent(out) << "  lastComparison = TBaseHelper.compareTo(this." << field->get_name() << ", typedOther." << field->get_name() << ");" << endl;
     indent(out) << "  if (lastComparison != 0) {" << endl;
     indent(out) << "    return lastComparison;" << endl;
     indent(out) << "  }" << endl;