From: Jake Farrell Date: Sun, 6 Nov 2011 15:02:30 +0000 (+0000) Subject: Thrift-1251: Generated java code should indicate which fields are required and which... X-Git-Tag: 0.8.0~26 X-Git-Url: https://source.supwisdom.com/gerrit/gitweb?a=commitdiff_plain;h=605c760ba690056e562f38395d6b40e5b2bacd8c;p=common%2Fthrift.git Thrift-1251: Generated java code should indicate which fields are required and which are optional Client: java Patch: Jake Farrell Fixes optional/required comments on fields. git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1198386 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/compiler/cpp/src/generate/t_java_generator.cc b/compiler/cpp/src/generate/t_java_generator.cc index 7b995f32..2b542593 100644 --- a/compiler/cpp/src/generate/t_java_generator.cc +++ b/compiler/cpp/src/generate/t_java_generator.cc @@ -3266,7 +3266,7 @@ string t_java_generator::declare_field(t_field* tfield, bool init) { } } result += "; // "; - if (tfield->get_xsd_optional()) { + if (tfield->get_req() == t_field::T_OPTIONAL) { result += "optional"; } else { result += "required";