From: Roger Meier <roger@apache.org>
Date: Thu, 29 May 2014 20:40:32 +0000 (+0200)
Subject: THRIFT-2526 Assignment operators and copy constructors in c++ don't copy the __isset... 
X-Git-Url: https://source.supwisdom.com/gerrit/gitweb?a=commitdiff_plain;h=7ca13f5507af5c67e0e93a2774f2b122374e0276;p=common%2Fthrift.git

THRIFT-2526 Assignment operators and copy constructors in c++ don't copy the __isset struct

Client: cpp
Patch: Doug Judd
---

diff --git a/compiler/cpp/src/generate/t_cpp_generator.cc b/compiler/cpp/src/generate/t_cpp_generator.cc
index f985492c..771af460 100755
--- a/compiler/cpp/src/generate/t_cpp_generator.cc
+++ b/compiler/cpp/src/generate/t_cpp_generator.cc
@@ -831,11 +831,17 @@ void t_cpp_generator::generate_copy_constructor(
 
   const vector<t_field*>& members = tstruct->get_members();
   vector<t_field*>::const_iterator f_iter;
+  bool has_nonrequired_fields = false;
   for (f_iter = members.begin(); f_iter != members.end(); ++f_iter) {
+    if ((*f_iter)->get_req() != t_field::T_REQUIRED)
+      has_nonrequired_fields = true;
     indent(out) << (*f_iter)->get_name() << " = " << tmp_name << "." <<
       (*f_iter)->get_name() << ";" << endl;
   }
 
+  if (has_nonrequired_fields)
+    indent(out) << "__isset = " << tmp_name << ".__isset;" << endl;
+
   indent_down();
   indent(out) << "}" << endl;
 }
@@ -852,10 +858,15 @@ void t_cpp_generator::generate_assignment_operator(
 
   const vector<t_field*>& members = tstruct->get_members();
   vector<t_field*>::const_iterator f_iter;
+  bool has_nonrequired_fields = false;
   for (f_iter = members.begin(); f_iter != members.end(); ++f_iter) {
+    if ((*f_iter)->get_req() != t_field::T_REQUIRED)
+      has_nonrequired_fields = true;
     indent(out) << (*f_iter)->get_name() << " = " << tmp_name << "." <<
       (*f_iter)->get_name() << ";" << endl;
   }
+  if (has_nonrequired_fields)
+    indent(out) << "__isset = " << tmp_name << ".__isset;" << endl;
 
   indent(out) << "return *this;" << endl;
   indent_down();