From: Christopher Piro <cpiro@apache.org>
Date: Thu, 15 Nov 2007 06:26:32 +0000 (+0000)
Subject: [thrift] Erlang client calls return value from recv_
X-Git-Tag: 0.2.0~1128
X-Git-Url: https://source.supwisdom.com/gerrit/gitweb?a=commitdiff_plain;h=9230539a6f2b36e25799b97ff45e90743af61269;p=common%2Fthrift.git

[thrift] Erlang client calls return value from recv_

Summary: only return `ok' if it's an async, otherwise return the value of recv_

Reviewed By: cvarenhorst

Test Plan: my server works now

Revert Plan: ok


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665344 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/compiler/cpp/src/generate/t_erl_generator.cc b/compiler/cpp/src/generate/t_erl_generator.cc
index 7d4c0509..d152c182 100644
--- a/compiler/cpp/src/generate/t_erl_generator.cc
+++ b/compiler/cpp/src/generate/t_erl_generator.cc
@@ -686,16 +686,12 @@ void t_erl_generator::generate_service_client(t_service* tservice) {
     }
     f_service_ << ")," << endl;
 
-    if (!(*f_iter)->is_async()) {
-      f_service_ << indent();
-      if (!(*f_iter)->get_returntype()->is_void()) {
-        f_service_ << "";
-      }
-      f_service_ <<
-        "recv_" << funname << "(This)," << endl;
+    if ((*f_iter)->is_async()) {
+      f_service_ << indent() << "ok." << endl;
+    } else {
+      f_service_ << indent() << "recv_" << funname << "(This)." << endl;
     }
 
-    indent(f_service_) << "ok." << endl;
     indent_down();
     f_service_ << endl;