From: Mark Slee <mcslee@apache.org>
Date: Fri, 17 Aug 2007 03:53:13 +0000 (+0000)
Subject: Perl pass by reference versioning fix
X-Git-Tag: 0.2.0~1265
X-Git-Url: https://source.supwisdom.com/gerrit/gitweb?a=commitdiff_plain;h=937fa6258bc4f9509dbaf914108cf2d381c8f741;p=common%2Fthrift.git

Perl pass by reference versioning fix

Summary: I hate Perl the most. Submitted by Jake Luciani.

Reviewed By: mcslee

Test Plan: We don't even use the Perl bindings for Thrift, but we could use Jake's test scripts on this.


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665207 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/lib/perl/lib/Thrift/BinaryProtocol.pm b/lib/perl/lib/Thrift/BinaryProtocol.pm
index c31e1d77..b9bb88de 100644
--- a/lib/perl/lib/Thrift/BinaryProtocol.pm
+++ b/lib/perl/lib/Thrift/BinaryProtocol.pm
@@ -228,7 +228,7 @@ sub readMessageBegin
     my ($name, $type, $seqid) = @_;
 
     my $version = 0;
-    my $result = $self->readI32($version);
+    my $result = $self->readI32(\$version);
     if ($version & VERSION_MASK != VERSION_1) {
       die new Thrift::TException('Missing version identifier')
     }