From: Mark Slee <mcslee@apache.org>
Date: Tue, 21 Aug 2007 02:39:40 +0000 (+0000)
Subject: Fix thread_t cast again
X-Git-Tag: 0.2.0~1261
X-Git-Url: https://source.supwisdom.com/gerrit/gitweb?a=commitdiff_plain;h=98439158db96e682467f87b0d6533896db9ae72a;p=common%2Fthrift.git

Fix thread_t cast again

Summary: reinterpret_cast actually breaks on linux, despite working on FreeBSD

Reviewed By: dreiss

Test Plan: Compile on Linux OR FreeBSD


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665211 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/lib/cpp/src/concurrency/PosixThreadFactory.cpp b/lib/cpp/src/concurrency/PosixThreadFactory.cpp
index f6ab6c72..3f356811 100644
--- a/lib/cpp/src/concurrency/PosixThreadFactory.cpp
+++ b/lib/cpp/src/concurrency/PosixThreadFactory.cpp
@@ -135,7 +135,8 @@ class PthreadThread: public Thread {
   }
 
   id_t getId() {
-    return reinterpret_cast<id_t>(pthread_);
+    // TODO(dreiss): Stop using C-style casts.
+    return (id_t)pthread_;
   }
 
   shared_ptr<Runnable> runnable() const { return Thread::runnable(); }
@@ -258,7 +259,10 @@ class PosixThreadFactory::Impl {
 
   void setDetached(bool value) { detached_ = value; }
 
-  Thread::id_t getCurrentThreadId() const {return reinterpret_cast<id_t>(pthread_self());}
+  Thread::id_t getCurrentThreadId() const {
+    // TODO(dreiss): Stop using C-style casts.
+    return (id_t)pthread_self();
+  }
 
 };