From: dweatherford Date: Thu, 6 Mar 2008 03:11:08 +0000 (+0000) Subject: [thrift] ZTS fixes for thift_protocol extension X-Git-Tag: 0.2.0~914 X-Git-Url: https://source.supwisdom.com/gerrit/gitweb?a=commitdiff_plain;h=9b945da3ca84b2e27c5cb0e62bfe5eafcf28b45b;p=common%2Fthrift.git [thrift] ZTS fixes for thift_protocol extension Summary: Now the threadsafe build compiles! Reviewed by: mcslee Test Plan: compiles, ship it Revert: ok git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665558 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp b/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp index 32b50393..ffe081c8 100644 --- a/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp +++ b/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp @@ -391,7 +391,7 @@ void binary_deserialize(int8_t thrift_typeID, PHPInputTransport& transport, zval RETURN_NULL(); } TSRMLS_FETCH(); - zval* spec = zend_read_static_property(zend_get_class_entry(return_value TSRMLS_CC), "_TSPEC", 6, false); + zval* spec = zend_read_static_property(zend_get_class_entry(return_value TSRMLS_CC), "_TSPEC", 6, false TSRMLS_CC); if (Z_TYPE_P(spec) != IS_ARRAY) { char errbuf[128]; snprintf(errbuf, 128, "spec for %s is wrong type: %d\n", structType, Z_TYPE_P(spec)); @@ -681,7 +681,7 @@ void binary_serialize(int8_t thrift_typeID, PHPOutputTransport& transport, zval* return; case T_STRUCT: { TSRMLS_FETCH(); - zval* spec = zend_read_static_property(zend_get_class_entry(*value TSRMLS_CC), "_TSPEC", 6, false); + zval* spec = zend_read_static_property(zend_get_class_entry(*value TSRMLS_CC), "_TSPEC", 6, false TSRMLS_CC); binary_serialize_spec(*value, transport, Z_ARRVAL_P(spec)); } return; case T_BOOL: @@ -870,7 +870,7 @@ PHP_FUNCTION(thrift_protocol_write_binary) { transport.writeI32(seqID); } - zval* spec = zend_read_static_property(zend_get_class_entry(request_struct TSRMLS_CC), "_TSPEC", 6, false); + zval* spec = zend_read_static_property(zend_get_class_entry(request_struct TSRMLS_CC), "_TSPEC", 6, false TSRMLS_CC); binary_serialize_spec(request_struct, transport, Z_ARRVAL_P(spec)); } catch (const PHPExceptionWrapper& ex) { zend_throw_exception_object(ex TSRMLS_CC); @@ -937,13 +937,13 @@ PHP_FUNCTION(thrift_protocol_read_binary) { zval* ex; MAKE_STD_ZVAL(ex); createObject("TApplicationException", ex); - zval* spec = zend_read_static_property(zend_get_class_entry(ex TSRMLS_CC), "_TSPEC", 6, false); + zval* spec = zend_read_static_property(zend_get_class_entry(ex TSRMLS_CC), "_TSPEC", 6, false TSRMLS_CC); binary_deserialize_spec(ex, transport, Z_ARRVAL_P(spec)); throw PHPExceptionWrapper(ex); } createObject(obj_typename, return_value); - zval* spec = zend_read_static_property(zend_get_class_entry(return_value TSRMLS_CC), "_TSPEC", 6, false); + zval* spec = zend_read_static_property(zend_get_class_entry(return_value TSRMLS_CC), "_TSPEC", 6, false TSRMLS_CC); binary_deserialize_spec(return_value, transport, Z_ARRVAL_P(spec)); } catch (const PHPExceptionWrapper& ex) { zend_throw_exception_object(ex TSRMLS_CC);