From: David Reiss <dreiss@apache.org>
Date: Thu, 14 Feb 2008 20:20:08 +0000 (+0000)
Subject: Thrift: Fix a bug in the skip function in Python's fastbinary.c
X-Git-Tag: 0.2.0~993
X-Git-Url: https://source.supwisdom.com/gerrit/gitweb?a=commitdiff_plain;h=bc444b034e79b521b0512198a1feaa37da6d3ee7;p=common%2Fthrift.git

Thrift: Fix a bug in the skip function in Python's fastbinary.c

Reviewed By: mcslee

Other Notes:
Submitted by Ben Maurer (the original author).


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665479 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/lib/py/src/protocol/fastbinary.c b/lib/py/src/protocol/fastbinary.c
index 3b7b5c09..5625f4b4 100644
--- a/lib/py/src/protocol/fastbinary.c
+++ b/lib/py/src/protocol/fastbinary.c
@@ -806,7 +806,7 @@ skip(DecodeBuffer* input, TType type) {
 
   }
 
-  return false;
+  return true;
 
 #undef SKIPBYTES
 }
@@ -851,6 +851,8 @@ decode_struct(DecodeBuffer* input, PyObject* output, PyObject* spec_seq) {
     if (item_spec == Py_None) {
       if (!skip(input, type)) {
         return false;
+      } else {
+        continue;
       }
     }