From: David Reiss <dreiss@apache.org>
Date: Thu, 1 May 2008 06:21:04 +0000 (+0000)
Subject: Throw a transport exception if fstat fails.
X-Git-Tag: 0.2.0~795
X-Git-Url: https://source.supwisdom.com/gerrit/gitweb?a=commitdiff_plain;h=f233e46a2dc705f017d5980baa6ad97922b72291;p=common%2Fthrift.git

Throw a transport exception if fstat fails.

This was failing on an NFS mount that was dying.
Better to fail hard then return uninitialized data.


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665677 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/lib/cpp/src/transport/TFileTransport.cpp b/lib/cpp/src/transport/TFileTransport.cpp
index 6c4920f8..d3767956 100644
--- a/lib/cpp/src/transport/TFileTransport.cpp
+++ b/lib/cpp/src/transport/TFileTransport.cpp
@@ -734,8 +734,17 @@ uint32_t TFileTransport::getNumChunks() {
   if (fd_ <= 0) {
     return 0;
   }
+
   struct stat f_info;
-  fstat(fd_, &f_info);
+  int rv = fstat(fd_, &f_info);
+
+  if (rv < 0) {
+    int errno_copy = errno;
+    throw TTransportException(TTransportException::UNKNOWN,
+                              "TFileTransport::getNumChunks() (fstat)",
+                              errno_copy);
+  }
+
   if (f_info.st_size > 0) {
     return ((f_info.st_size)/chunkSize_) + 1;
   }