From: David Reiss <dreiss@apache.org>
Date: Thu, 26 Mar 2009 06:15:26 +0000 (+0000)
Subject: cpp: Eliminate a buffer overflow in the tutorial server
X-Git-Tag: 0.2.0~211
X-Git-Url: https://source.supwisdom.com/gerrit/gitweb?a=commitdiff_plain;h=f33c7c670b189fbb58eb9cb868703ca99a107b7c;p=common%2Fthrift.git

cpp: Eliminate a buffer overflow in the tutorial server

Negative numbers can have 11 characters :)


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758529 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/tutorial/cpp/CppServer.cpp b/tutorial/cpp/CppServer.cpp
index a2c30d2a..044e1d99 100644
--- a/tutorial/cpp/CppServer.cpp
+++ b/tutorial/cpp/CppServer.cpp
@@ -69,8 +69,8 @@ class CalculatorHandler : public CalculatorIf {
 
     SharedStruct ss;
     ss.key = logid;
-    char buffer[11];
-    sprintf(buffer, "%d", val);
+    char buffer[12];
+    snprintf(buffer, sizeof(buffer), "%d", val);
     ss.value = buffer;
 
     log[logid] = ss;