From: Bryan Duxbury Date: Sat, 21 Feb 2009 01:57:46 +0000 (+0000) Subject: THRIFT-116. java: Isset fields for non-primitive types unnecessary X-Git-Tag: 0.2.0~287 X-Git-Url: https://source.supwisdom.com/gerrit/gitweb?a=commitdiff_plain;h=f9d105c51997d0cc77ab5c30e3f1616359026fde;p=common%2Fthrift.git THRIFT-116. java: Isset fields for non-primitive types unnecessary Missed one of the cases where isset was being used on non-primitive fields. git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@746429 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/compiler/cpp/src/generate/t_java_generator.cc b/compiler/cpp/src/generate/t_java_generator.cc index 07646767..0d2345a9 100644 --- a/compiler/cpp/src/generate/t_java_generator.cc +++ b/compiler/cpp/src/generate/t_java_generator.cc @@ -1014,7 +1014,7 @@ void t_java_generator::generate_java_validator(ofstream& out, if ((*f_iter)->get_req() == t_field::T_REQUIRED) { if (bean_style_) { out << - indent() << "if (!__isset." << (*f_iter)->get_name() << ") {" << endl << + indent() << "if (" << generate_isset_check(*f_iter) << ") {" << endl << indent() << " throw new TProtocolException(\"Required field '" << (*f_iter)->get_name() << "' is unset! Struct:\" + toString());" << endl << indent() << "}" << endl << endl; } else{