From: David Reiss <dreiss@apache.org>
Date: Tue, 2 Dec 2008 02:32:25 +0000 (+0000)
Subject: THRIFT-214. cpp: Qualify a cast to fix OSX compilation
X-Git-Tag: 0.2.0~396
X-Git-Url: https://source.supwisdom.com/gerrit/gitweb?a=commitdiff_plain;h=fbb14ef1b33db23cb0862975af58bbba957d2378;p=common%2Fthrift.git

THRIFT-214. cpp: Qualify a cast to fix OSX compilation

id_t is defined in some OSX header, and the id_t in this function
resolved to that one instead of Thread::id_t.  This change fully
qualifies the type to make sure it resolves properly.

Also remove a comment about eliminating the C-style cast, since it
is actually quite appropriate in this case.


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@722337 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/lib/cpp/src/concurrency/PosixThreadFactory.cpp b/lib/cpp/src/concurrency/PosixThreadFactory.cpp
index 59953417..001d6ad8 100644
--- a/lib/cpp/src/concurrency/PosixThreadFactory.cpp
+++ b/lib/cpp/src/concurrency/PosixThreadFactory.cpp
@@ -139,9 +139,8 @@ class PthreadThread: public Thread {
     }
   }
 
-  id_t getId() {
-    // TODO(dreiss): Stop using C-style casts.
-    return (id_t)pthread_;
+  Thread::id_t getId() {
+    return (Thread::id_t)pthread_;
   }
 
   shared_ptr<Runnable> runnable() const { return Thread::runnable(); }