From: David Reiss <dreiss@apache.org>
Date: Wed, 11 Jun 2008 01:03:10 +0000 (+0000)
Subject: Remove another TODO - no need to set "id" field of stop markers
X-Git-Tag: 0.2.0~705
X-Git-Url: https://source.supwisdom.com/gerrit/gitweb?a=commitdiff_plain;h=fe7ce1b3b380f29450d74db694147d560556b949;p=common%2Fthrift.git

Remove another TODO - no need to set "id" field of stop markers

Test plan: tested on our price service


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@666457 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/lib/alterl/src/thrift_binary_protocol.erl b/lib/alterl/src/thrift_binary_protocol.erl
index c84701ef..804e0ad4 100644
--- a/lib/alterl/src/thrift_binary_protocol.erl
+++ b/lib/alterl/src/thrift_binary_protocol.erl
@@ -190,8 +190,7 @@ read(This, struct_end) -> ok;
 read(This, field_begin) ->
     case read(This, byte) of
         {ok, Type = ?tType_STOP} ->
-            #protocol_field_begin{type = Type,
-                                  id = 0}; % TODO(todd) 0 or undefined?
+            #protocol_field_begin{type = Type};
         {ok, Type} ->
             {ok, Id} = read(This, i16),
             #protocol_field_begin{type = Type,