From: Roger Meier <roger@apache.org>
Date: Sat, 29 Jun 2013 12:51:30 +0000 (+0200)
Subject: THRIFT-2074 cppcheck error removed from ThreadManager.cpp
X-Git-Tag: 0.9.1~48
X-Git-Url: https://source.supwisdom.com/gerrit/gitweb?a=commitdiff_plain;h=ffbfd03cc2a943a41b28e82dafd3d4c7438cf04c;p=common%2Fthrift.git

THRIFT-2074 cppcheck error removed from ThreadManager.cpp
Patch: Konrad Grochowski
---

diff --git a/lib/cpp/src/thrift/concurrency/ThreadManager.cpp b/lib/cpp/src/thrift/concurrency/ThreadManager.cpp
index 298dbac7..f2c0fa56 100644
--- a/lib/cpp/src/thrift/concurrency/ThreadManager.cpp
+++ b/lib/cpp/src/thrift/concurrency/ThreadManager.cpp
@@ -446,8 +446,8 @@ void ThreadManager::Impl::removeWorker(size_t value) {
     }
 
     for (std::set<shared_ptr<Thread> >::iterator ix = deadWorkers_.begin(); ix != deadWorkers_.end(); ix++) {
-      workers_.erase(*ix);
       idMap_.erase((*ix)->getId());
+      workers_.erase(*ix);
     }
 
     deadWorkers_.clear();