Supwisdom Source - common/thrift.git/log

Code Review / common / thrift.git / log

summary | shortlog | log | commit | commitdiff | review | tree
first ⋅ prev ⋅ next

commit | commitdiff | tree

Mark Slee [Thu, 25 Jan 2007 08:14:50 +0000 (08:14 +0000)]

Separate thrift into libthrift and libthriftnb

Summary: libthriftnb is the one that requires libevent. It was really annoying that you always had to put -levent in your link step to build thrift programs when youa re not using any of the c++ nonblocking stuff. This way, if you're using nonblocking you can do that, but the normal case is easier to link.

Reviewed By: makefile

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664951 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Thu, 25 Jan 2007 08:01:28 +0000 (08:01 +0000)]

Fix relative paths in test dirs

Reviewed By: makefile

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664950 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Thu, 25 Jan 2007 07:58:55 +0000 (07:58 +0000)]

Full automake/autoconf compliance for thrift

Summary: Including the compiler!!!

Reviewed By: automake

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664949 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Thu, 25 Jan 2007 06:28:24 +0000 (06:28 +0000)]

Fix bootstrap for the jwang

Summary: SORRY MY HAX)RDS WAS BROKED

Reviewed By: jwang

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664948 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Aditya Agarwal [Thu, 25 Jan 2007 03:27:43 +0000 (03:27 +0000)]

-- ThriftLogfile is finally done.

Summary:
- Everything seems to be working well..

Reviewed By: tbr - slee

Test Plan: Tested using search

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664947 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Thu, 25 Jan 2007 02:10:07 +0000 (02:10 +0000)]

Fix Makefile to use thrifty.yy and thriftl.ll

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664946 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Thu, 25 Jan 2007 02:07:22 +0000 (02:07 +0000)]

Rename some thrif tcompiler files

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664945 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Wed, 24 Jan 2007 23:42:12 +0000 (23:42 +0000)]

Add some smaller test cases and fix new single protocol/transport C++ test

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664944 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Aditya Agarwal [Wed, 24 Jan 2007 23:39:10 +0000 (23:39 +0000)]

-- Error recovery code for thrift logfile

Summary:
- perform some basic corruption checks:
   1) Event larger than chunk
   2) Event larger than specified max
   3) Event crossing chunk boundary etc.
- If error encountered, then try to perform some recovery

Reviewed By: Slee

Test Plan: Going to test now...need to check in because of compile issues

Notes:
- These checks take care of the case when there is a dirty read from the filesystem (which
  we have encountered with the netapps). The recovery involves trying to perform the read
  again from ths FS and if that fails skipping the chunk altogether.
  Keep in mind that this might only be useful for idempotent systems (e.g. search redolog).

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664943 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Wed, 24 Jan 2007 23:14:30 +0000 (23:14 +0000)]

Thrift socket should not perror in the TRYAGAIN state

Reviewed By: wayne

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664942 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Wed, 24 Jan 2007 22:57:20 +0000 (22:57 +0000)]

No more getInputTransport vs getOutputTransport in protocols

Summary: It is just getTransport ow

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664941 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Aditya Agarwal [Wed, 24 Jan 2007 22:53:54 +0000 (22:53 +0000)]

-- Change concept of protocol and transport factory

Summary:
- Transport factories now wrap around one transport
- Protocol factories now wrap around one transport (as opposed to a pair of input/output
transports)
- TServer now takes input/output transport and protocol factories

The motivation for this change is that you could concievably want to use a different protocol or
transport for input and output. An example is that incoming data is encoded using binary protocol
but outgoing data is encrypted XML (with encryption being done on the transport level).

This change should be mostly backwards compatible because the TServer classes have constructors
that take a transport factory and use that for both the input and transport factories. The only
change might be for anyone who is using the C++ client code directly i.e. instantiating
TBinaryProtocol() directly because the constructor now only accepts one transport.

Reviewed By: Slee

Test Plan: Everything compiles (for both thrift and search).

Notes:
I am going to make the same changes in all the supported languages after this...

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664940 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Wed, 24 Jan 2007 22:53:07 +0000 (22:53 +0000)]

Generate pargs an presult helpers in C++ to be more efficient in thrift

Summary: Copy construction is the pits. Avoid it at all costs.

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664939 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Wed, 24 Jan 2007 19:43:06 +0000 (19:43 +0000)]

Fix C++ Thrift test code to work with new gen'd code interface

Reviewed By: tbr-aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664938 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Wed, 24 Jan 2007 19:41:57 +0000 (19:41 +0000)]

Nonblockingserver constructor that uses binary protocol factory by default

Reviewed By: tbr-aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664937 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Aditya Agarwal [Wed, 24 Jan 2007 02:24:35 +0000 (02:24 +0000)]

-- thrift logfile fixes

Summary:
-- numChunks was broken and that was causing a lot of strange downstream behaviour

Reviewed By: tbr slee

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664936 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Tue, 23 Jan 2007 23:22:35 +0000 (23:22 +0000)]

No need to generate private __construct() function if the class is already final

Reviewed By: lucas

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664935 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Fri, 19 Jan 2007 23:49:00 +0000 (23:49 +0000)]

Use proper name for catching exceptions

Reviewed By: tbr-dave

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664934 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Fri, 19 Jan 2007 22:12:10 +0000 (22:12 +0000)]

Thrift XSD generator populates PHP globals with type names for typedeffed stuffs

Reviewed By: dave

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664933 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Fri, 19 Jan 2007 20:09:51 +0000 (20:09 +0000)]

Allow field elements to be optional in thrift with xsd_optional keyword

Reviewed By: tbr-dave

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664932 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Fri, 19 Jan 2007 19:14:36 +0000 (19:14 +0000)]

Add comma-separated list of type "slist" to thrift

Summary: Useful for API arguments

Reviewed By: tbr-dave

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664931 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Aditya Agarwal [Fri, 19 Jan 2007 02:02:12 +0000 (02:02 +0000)]

-- Nonblocking server changes to allow logging

Summary:
-- the constructor needs to accept a transport factory
-- TConnection close() needs to close factor generated transports

Reviewed By: Mark Slee

Test Plan: Tested with search redologger

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664930 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Fri, 19 Jan 2007 00:17:02 +0000 (00:17 +0000)]

Add xsd_all keyword to Thrift

Summary: Makes a struct an xsd_all instead of a sequence

Reviewed By: dave

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664929 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Thu, 18 Jan 2007 22:59:59 +0000 (22:59 +0000)]

Thrift now generates XSD files

Summary: Are you fucking kidding me? This shit is robust.

Reviewed By: fetter-tbr-d00d

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664928 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Thu, 18 Jan 2007 20:00:11 +0000 (20:00 +0000)]

Resolve typedefs in php generation

Reviewed By: xsd

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664927 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Thu, 18 Jan 2007 18:35:26 +0000 (18:35 +0000)]

Remove py compiler from thrift repo

Summary: This keeps confusing people when they try to do make and make install, we always have it around in the svn repo, so we can take it out of current trunk.

Reviewed By: martin

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664926 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Thu, 18 Jan 2007 06:54:43 +0000 (06:54 +0000)]

Fix changing struct name bug on C++ generation

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664925 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Aditya Agarwal [Thu, 18 Jan 2007 06:20:24 +0000 (06:20 +0000)]

-- additions to ThriftLogfile

Summary:
-- fixed peek() in TBufferedRouterTransport.cpp
-- Added processChunk() to ThriftLogfile

Reviewed By: Slee

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664924 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Thu, 18 Jan 2007 02:35:27 +0000 (02:35 +0000)]

Do not generate write code for null fields in Java

Summary: It will make null pointer exceptions!

Reviewed By: martin, alex

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664923 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Thu, 18 Jan 2007 01:16:51 +0000 (01:16 +0000)]

Add mkdir for bin in thrift compiler

Reviewed By: dcorson

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664922 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Wed, 17 Jan 2007 19:19:21 +0000 (19:19 +0000)]

Fix bugs with php_namespace keyword in thrift

Reviewed By: aditya

line, and those below, will be ignored--

M t_php_generator.cc

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664921 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Karl Lehenbauer [Wed, 17 Jan 2007 18:56:10 +0000 (18:56 +0000)]

Fix identifier typo in Thrift error message.

Trac Bug: #

Reviewed By:

Test Plan:
The correct error message appears when a PHP Thrift client can't
connect to a server. Set that up, and try and get the error message:

[Wed Jan 17 10:41:41 2007] [error] TSocketPool: retryInterval (60) has
passed for host dev007:8188

...then you're good. If you get something about a undefined property,
then this fix didn't work.

Revert Plan: Revertible

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664920 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Marc Slemko [Wed, 17 Jan 2007 08:32:16 +0000 (08:32 +0000)]

Added ax_event_base.m4 to find and configure libevent
Modified configure.ac to pull in AX_EVENT_BASE
Modified Makefile.am to take EVENT settings from automake.

Reviewed by dcorson

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664919 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Marc Slemko [Wed, 17 Jan 2007 07:59:38 +0000 (07:59 +0000)]

Make boost base default to yes to make sure we don't get through configure without boost
Fixed configure.ac to add a few missing functions and headers

Reviewed by dcorson

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664918 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Tue, 16 Jan 2007 23:53:53 +0000 (23:53 +0000)]

Resolve complex typedefs in Thrift

Summary: For function returns

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664917 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Tue, 16 Jan 2007 23:00:31 +0000 (23:00 +0000)]

Thrift should generate C++ enums first before typdefs

Summary: In case you want to typedef an enum

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664916 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Tue, 16 Jan 2007 22:48:22 +0000 (22:48 +0000)]

Prefix generated _args and _result helper classes with service name

Summary: To avoid conflicts when you have two services with the same name inside one .thrift file

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664915 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Marc Slemko [Tue, 16 Jan 2007 22:20:19 +0000 (22:20 +0000)]

Added autoconf/automake glue to run lib/py/setup.py as part of make install

Reviewed by mslee

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664914 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

robert [Mon, 15 Jan 2007 23:53:25 +0000 (23:53 +0000)]

Fixed some warnings, changed TSocketPool to inherit debugHandler from TSocket
reviewed: mcslee
revert: yes

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664913 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Aditya Agarwal [Mon, 15 Jan 2007 23:14:58 +0000 (23:14 +0000)]

-- Allow manual setting of host and port in TSocket

Summary:
-- required for TSocketPool equivalent functionality

Reviewed By: slee

Notes:
-- Todo is to replicate TSocketPool.php in C++

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664912 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

robert [Mon, 15 Jan 2007 18:29:51 +0000 (18:29 +0000)]

Added open, close, and isOpen to TFramedTransport
reviewed: mcslee
revert: yes

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664911 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Fri, 12 Jan 2007 21:44:14 +0000 (21:44 +0000)]

Thrift C++ code generator returns complex types by reference

Summary: Efficiency, Yo.

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664910 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Fri, 12 Jan 2007 02:10:16 +0000 (02:10 +0000)]

Committing code gen changes for const ref args to functions in Thrift

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664909 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Fri, 12 Jan 2007 01:06:24 +0000 (01:06 +0000)]

Add PHP namespacing support to Thrift

Summary: "php_namespace Whoa" at the top of your Thrift file, then all your defined class names start with "Whoa_"

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664908 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Fri, 12 Jan 2007 00:23:26 +0000 (00:23 +0000)]

Disallow keywords in Thrift files

Summary: Or else you are bound to get shitty errors in some generated languages.. They're not all covered here, but a lot of them are.

Reviewed By: dougb, bobby

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664907 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Adam Nichols [Thu, 11 Jan 2007 21:25:29 +0000 (21:25 +0000)]

minor syntax change in thrift php library, reviewed by slee, revertible

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664906 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Thu, 11 Jan 2007 01:26:00 +0000 (01:26 +0000)]

Fix call_user_func bug on debugHandler_

Reviewed By: lucas

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664905 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Fri, 5 Jan 2007 01:09:04 +0000 (01:09 +0000)]

Example syntax for constants in Thrift

Reviewed By: martin

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664904 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Wed, 3 Jan 2007 19:23:50 +0000 (19:23 +0000)]

Add options to thrift transport classes for custom error handlers

Summary: So we can pass debug_rlog (facebook custom) in as a handler for errors to thrift (generic open source)

Reviewed By: lucas

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664903 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Wed, 3 Jan 2007 18:45:04 +0000 (18:45 +0000)]

Fix typo class variable bug in TSocketPool

Reviewed By: corson

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664902 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

putnam [Fri, 22 Dec 2006 10:35:12 +0000 (10:35 +0000)]

Fixed typo in Thrift README

Summary:
  locacation? COME ON GUYS.

Review:
  peter

Test plan:
  I read it, then re-read it, then re-re-read it.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664901 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

robert [Wed, 20 Dec 2006 19:25:38 +0000 (19:25 +0000)]

fixed a problem with read buffer resizing in TNonblockingServer

reviewed: mcslee
revert: yes
test: send a large message to a nonblocking server

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664900 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

robert [Tue, 19 Dec 2006 22:27:54 +0000 (22:27 +0000)]

fixed a bug in TFramedTransport where it was checking a size for nonzero after byte swapping it.

reviewed: mcslee
revert: yes
test: run a C++ client and server with framed transport

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664899 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Sat, 16 Dec 2006 01:06:49 +0000 (01:06 +0000)]

message_ in TException can't be const or subclasses break

Reviewed By: yishan

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664898 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Sat, 16 Dec 2006 00:59:29 +0000 (00:59 +0000)]

Fix exceptions throw() and virtual destructor

Reviewed By: yishan

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664897 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Fri, 15 Dec 2006 19:07:04 +0000 (19:07 +0000)]

All user-defined thrift exceptions inherit from TException

Summary: So you can catch more effectively

Reviewed By: tbr-karl

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664896 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Wed, 13 Dec 2006 01:54:56 +0000 (01:54 +0000)]

Another AccessNull bug fix in Thrift

Reviewed By: yhishan

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664895 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Wed, 13 Dec 2006 01:45:26 +0000 (01:45 +0000)]

Fix c++ Null inheritance issue

Reviewed By: yishan

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664894 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Wed, 13 Dec 2006 01:07:33 +0000 (01:07 +0000)]

Take out timestamps from generated files

Summary: File system does this for you.

Reviewed By: martin, yishan

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664893 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Martin Kraemer [Sat, 9 Dec 2006 01:57:58 +0000 (01:57 +0000)]

Thrift TException Cleanup

Summary:
Destructors should be virtual or declared protected.

Reviewed By: mcslee

Revert Plan: revertible

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664892 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Aditya Agarwal [Sat, 9 Dec 2006 00:58:15 +0000 (00:58 +0000)]

-- Rename TBufferedFileWriter.h/cpp to TFileTransport.h/cpp

Summary:
-- Thrift logfile is now officially in action!

Reviewed By: Mark Slee

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664891 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Aditya Agarwal [Sat, 9 Dec 2006 00:47:03 +0000 (00:47 +0000)]

-- Check all system call return values

Summary:
-- Throw TTransportException if a system call fails

Reviewed By: Mark Slee

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664890 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Aditya Agarwal [Fri, 8 Dec 2006 23:52:57 +0000 (23:52 +0000)]

-- TFileTransport (Thrift Logfile)

Summary:
-- TBufferedFileWriter.h/cpp will be renamed to TFileTransport.h/cpp in the next commit.
-- TFileTransport is essentially reading and writing thrift calls to/from a file instead of a
socket.
-- The code/design is somewhat similar to pillar_logfile but there are some significant changes.

todo:
-- still need to do error correction/detection

Reviewed By: Mark Slee

Test Plan:
-- Wrote test in thrift/test/cpp/src/main.cpp that appends to a file and replays requests

Notes:
It's finally time to port search over to Thrift

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664889 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Fri, 8 Dec 2006 19:15:35 +0000 (19:15 +0000)]

Generate a null implementation of thrift C++ class for easy subclassing

Summary: Sometimes you just want a subclass that only implements one method... annoying to fill in nulls for the others, so use the generated null class

Reviewed By: tbr-aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664888 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Martin Kraemer [Wed, 6 Dec 2006 19:52:16 +0000 (19:52 +0000)]

Thrift TException does not properly define virtual what() method.

Summary:
Clients would elect to call the base class what() method instead of the derived version. This results in
less than usable exceptions for debugging.

Reviewed By: Karl * mcslee

Test Plan:
Tested with local application in development.

Revert Plan:
revertible.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664887 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Wed, 6 Dec 2006 00:13:42 +0000 (00:13 +0000)]

Fix TSimpleServer exception bug

Reviewed By: tbr-martin

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664886 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Thu, 30 Nov 2006 00:55:41 +0000 (00:55 +0000)]

Missing file in thrift parser, sorry d00dz!

Summary: Forgot to svn add

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664885 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Wed, 29 Nov 2006 22:07:23 +0000 (22:07 +0000)]

Oops take out printf debug

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664884 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Wed, 29 Nov 2006 22:06:42 +0000 (22:06 +0000)]

Thrift supports HEX notation for int consts and proper python/php sets

Reviewed By: yishan-tbr

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664883 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Wed, 29 Nov 2006 03:37:04 +0000 (03:37 +0000)]

Strings in JSON style thrift constants do not need quotes

Summary: Cause it's just too much work to put in quotes sometimes. struct thing = { a : 325, bb : 5632} OBVIOUSLY a and bb are strings. Duh.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664882 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Wed, 29 Nov 2006 03:19:31 +0000 (03:19 +0000)]

Thrift supports arbitrarily typed constants across all languages

Summary: Hot! Now you can defined your maps to strings and other constnats things in your .thrift file, so you can have the same symbols and useful defaults defined in your client as in your server.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664881 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Tue, 28 Nov 2006 01:24:07 +0000 (01:24 +0000)]

Thrift compiler frontend support for constants

Summary: The parser now accepts constants and adds them into the parse tree

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664880 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Mon, 27 Nov 2006 20:25:43 +0000 (20:25 +0000)]

Fix _seqid to seqid_ name change in PHP

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664879 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Tue, 21 Nov 2006 02:01:22 +0000 (02:01 +0000)]

Thrift: Fix PHP socket fread return

Summary: If you read the string "0" then it treats that as false, so we have to check for both === false and === '' manually.

Reviewed By: martin

Notes: I hate php

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664878 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Tue, 21 Nov 2006 00:44:23 +0000 (00:44 +0000)]

Fix thrift compiler typedef support

Summary: Typedefed containers were wonk'd

Reviewed By: martin

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664877 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Thu, 16 Nov 2006 01:00:24 +0000 (01:00 +0000)]

Thrift: C++ peek() method and TException not Exception

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664876 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Wed, 15 Nov 2006 22:23:06 +0000 (22:23 +0000)]

Fix bad implode call with nonexistant class variable in PHP SocketPool

Reviewed By: karl

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664875 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Wed, 15 Nov 2006 21:25:34 +0000 (21:25 +0000)]

Comma after ENUM with no explicit value

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664874 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Tue, 14 Nov 2006 23:51:27 +0000 (23:51 +0000)]

Rest definition should not implement interface, the method signatures are different.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664873 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Tue, 14 Nov 2006 23:48:00 +0000 (23:48 +0000)]

Thrift generates a REST handler for PHP code

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664872 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Fri, 10 Nov 2006 23:07:35 +0000 (23:07 +0000)]

All thrift PHP class constructors can take an array as the constructor argument

Summary: It will init any field with the value in the array. Hot for converting DB rows into thrift objs.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664871 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Fri, 10 Nov 2006 22:32:07 +0000 (22:32 +0000)]

I lied before, now thrift really supports single or double dashes

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664870 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Thu, 9 Nov 2006 00:23:30 +0000 (00:23 +0000)]

Allow single dash or double dash for thrift flags

Reviewed By: martin

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664869 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Martin Kraemer [Thu, 9 Nov 2006 00:06:36 +0000 (00:06 +0000)]

Thrift Include Path Specification

Summary:
Add support for include path specification in thrift. Using a -I <dir> option you can build a list of search paths to resolve thrift includes.

Reviewed By: mcslee

Revert Plan: revertible

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664868 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Wed, 8 Nov 2006 23:44:59 +0000 (23:44 +0000)]

Do not print ; in thrift parser

Reviewed By: bizsys d00dz

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664867 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Tue, 7 Nov 2006 23:03:00 +0000 (23:03 +0000)]

Fix TType.php problem

Reviewed By: martin

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664866 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Mon, 6 Nov 2006 21:40:11 +0000 (21:40 +0000)]

Fix C++ skeleton code generator

Summary: Do not reference TBufferedTransportFactory.h

Reviewed By: yishan

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664865 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Thu, 2 Nov 2006 18:43:12 +0000 (18:43 +0000)]

Make commas and/or semicolons both optional in thrift

Reviewed by: karl

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664864 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Tue, 31 Oct 2006 05:56:27 +0000 (05:56 +0000)]

Iterate python dictionaries with for k,v in dict.items()

Notes:

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664863 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Tue, 31 Oct 2006 05:45:33 +0000 (05:45 +0000)]

Py inherited processor must pass handler to parent constructor

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664862 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Tue, 31 Oct 2006 05:43:53 +0000 (05:43 +0000)]

Inherited processors must call parent constructor in python

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664861 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Tue, 31 Oct 2006 05:09:24 +0000 (05:09 +0000)]

Add python scons rules

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664860 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Tue, 31 Oct 2006 05:08:33 +0000 (05:08 +0000)]

Use AbstractMap instead of HashMap

Summary: So ConcurrentHashMap can be used safely

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664859 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Sat, 28 Oct 2006 00:51:14 +0000 (00:51 +0000)]

Mutex was missing from libthrift build

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664858 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Fri, 27 Oct 2006 22:30:15 +0000 (22:30 +0000)]

Fix Python indentation for async methods

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664857 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Thu, 26 Oct 2006 18:15:02 +0000 (18:15 +0000)]

Skeletons should use virtual inheritance from the interface base

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664856 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Thu, 26 Oct 2006 05:06:26 +0000 (05:06 +0000)]

Include <time.h> not "time.h"

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664855 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Thu, 26 Oct 2006 04:57:03 +0000 (04:57 +0000)]

Thrift PHP update for new Protocol wraps Transport style

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664854 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Thu, 26 Oct 2006 04:56:40 +0000 (04:56 +0000)]

Let Python server take protocolFactory argument

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664853 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Mark Slee [Thu, 26 Oct 2006 04:56:18 +0000 (04:56 +0000)]

Bring Thrift test code up to date

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664852 13f79535-47bb-0310-9956-ffa450edef68

Unnamed repository; edit this file 'description' to name the repository.