Supwisdom Source - common/thrift.git/log

Code Review / common / thrift.git / log

summary | shortlog | log | commit | commitdiff | review | tree
first ⋅ prev ⋅ next

commit | commitdiff | tree

Jake Farrell [Fri, 7 Oct 2011 17:41:48 +0000 (17:41 +0000)]

Thrift-1373: Fix user-defined exception generation in thrift (python)
Client: py
Patch: Dave Watson

forgotten include of TException in py imports section

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1180119 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Fri, 7 Oct 2011 00:25:46 +0000 (00:25 +0000)]

Thrift-1379: fix uninitialized enum values in thrift C++ objects
Client: cpp
Patch: Dave Watson

The thrift-generated code for C++ class objects does not provide any
initialization for enum values, so they wind up containing random/uninitialized
data. This causes problems when clients do not send argument data, as the server
receives random data rather than zero for unpassed args.
Enums should be initialized to zero.

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1179909 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Fri, 7 Oct 2011 00:17:25 +0000 (00:17 +0000)]

Thrift-1377: abort PHP deserialization on unknown field type
client: php
Patch: Dave Watson

Previously the code incorrectly ignored unknown field types. After
reading the field header, if it was an unknown type it would incorrectly
assume there was no data, and start trying to read the next field
immediately.

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1179907 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Fri, 7 Oct 2011 00:14:34 +0000 (00:14 +0000)]

Thrift-1376: Make port specification option in thrift remote
Client: py
Patch: Dave Watson

The thrift-generated Python service client allows overriding the default host/port by doing "-h host:port" on the command line. Oftentimes, you want to override the host but not the port, as most services run on well-defined ports.

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1179905 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Fri, 7 Oct 2011 00:10:20 +0000 (00:10 +0000)]

Thrift-1375: fixed a hex char conversion bug in TJSONProtocol
Client: java
Patch: Dave Watson

Fixed a hex char conversion bug in TJSONProtocol: 10 ~ 15 <=> 'a' ~ 'f'.

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1179904 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Fri, 7 Oct 2011 00:04:56 +0000 (00:04 +0000)]

Thrift-1373: Fix user-defined exception generation in thrift (python)
Client: py
Patch: Dave Watson

Fixed python code generation so that user-defined exceptions have a
base class of TException rather than Exception.

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1179903 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Tue, 4 Oct 2011 14:59:40 +0000 (14:59 +0000)]

THRIFT-1370: Debian packaging should Build-Depend on libglib2.0-dev
Client: build
Patch: Christian Hofstaedtler

The Debian packaging builds the c_glib interface library, but does not name libglib2.0-dev as a Build-Dependency. While this usually won't affect manual builds, this is a problem for automated build environments which will not have libglib2.0-dev installed unless explicitly requested by Build-Depends.

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1178823 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Mon, 3 Oct 2011 19:37:09 +0000 (19:37 +0000)]

THRIFT-1361 Optional replacement of pthread by boost::thread (minor fix)
FIX: member initialization order within constructor

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1178532 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Sun, 2 Oct 2011 10:51:45 +0000 (10:51 +0000)]

THRIFT-1361 Optional replacement of pthread by boost::thread
Patch: alexandre parenteau

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1178176 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Fri, 30 Sep 2011 20:23:34 +0000 (20:23 +0000)]

THRIFT-1031 Patch to compile Thrift for vc++ 9.0 and 10.0
Patch: Peace

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1177817 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Thu, 29 Sep 2011 22:51:54 +0000 (22:51 +0000)]

add utility for benchmarking protocols against each other

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1177458 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 27 Sep 2011 17:07:19 +0000 (17:07 +0000)]

revert THRIFT-959

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1176472 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Mon, 26 Sep 2011 21:29:15 +0000 (21:29 +0000)]

THRIFT-1365. java: TupleProtocol#writeBitSet unintentionally writes a variable length byte array

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1176072 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Mon, 26 Sep 2011 20:32:59 +0000 (20:32 +0000)]

inconsequential indentation fix to java compiler

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1176034 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Mon, 26 Sep 2011 15:29:03 +0000 (15:29 +0000)]

THRIFT-1357: Erlang dependency breaks build
Client: erl
Patch: Peter Neumark

Updates json protocol to work with JSX 0.9.

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1175906 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Sun, 25 Sep 2011 07:16:17 +0000 (07:16 +0000)]

THRIFT-1359 --gen-cob cpp:cob_style does not compile anymore
Patch: Alexandre Parenteau

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1175308 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Fri, 23 Sep 2011 17:24:00 +0000 (17:24 +0000)]

Thrift-1355: Running make in lib/rb doesn't build the native extensions
Client: rb
Patch: jfarrell

Builds extension prior to running spec calls to resolve test deps.

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1174896 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Fri, 23 Sep 2011 14:25:22 +0000 (14:25 +0000)]

THRIFT-1031 Patch to compile Thrift for vc++ 9.0 and 10.0
=> some more improvements

Patch: James Dickson

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1174801 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Thu, 22 Sep 2011 21:15:02 +0000 (21:15 +0000)]

Thrift-1354: Add rake task to build just the gem file
Client: rb
Patch: jfarrell

Updates ruby build to now build the gem by default and adds a rake task to create the gem.

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1174393 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Wed, 21 Sep 2011 00:15:27 +0000 (00:15 +0000)]

Thrift-857: tests run by "make install" fail if generators are disabled
Client: build
Patch: jfarrell

removes --enable-gen* from configure and adds all generators by default.

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1173436 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 20 Sep 2011 22:53:31 +0000 (22:53 +0000)]

THRIFT-1339. java: Extend Tuple Protocol to TUnions

This patch implements TupleProtocol (and general Scheme support) to TUnion descendants.

Patch: Armaan Sarkar

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1173418 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 20 Sep 2011 18:45:56 +0000 (18:45 +0000)]

THRIFT-1331. rb: Ruby library deserializes an empty map to nil

This patch properly detects when the metadata is omitted in Compact Protocol messages.

Patch: Armaan Sarkar

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1173300 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Mon, 19 Sep 2011 23:38:39 +0000 (23:38 +0000)]

THRIFT-1350: Go library code does not build against latest release
Client: go
Patch: Kyle Consalus

Go has moved it's URL-handling code into a "url" package, patch updates for these new changes.

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1172901 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Anthony F. Molinaro [Sun, 18 Sep 2011 04:57:50 +0000 (04:57 +0000)]

THRIFT-1227 - erlang implementation of thrift json protocol

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1172199 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Fri, 16 Sep 2011 20:58:44 +0000 (20:58 +0000)]

THRIFT-1031 Patch to compile Thrift for vc++ 9.0 and 10.0
Patch: James Dickson and Alexandre Parenteau

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1171777 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Fri, 16 Sep 2011 12:02:57 +0000 (12:02 +0000)]

THRIFT-1031 Patch to compile Thrift for vc++ 9.0 and 10.0 (partial)
no chmod on windows for go and py compiler
Patch: James Dickson

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1171520 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Wed, 14 Sep 2011 06:19:10 +0000 (06:19 +0000)]

THRIFT-1335: Add accept timeout to TServerSocket
Client: cpp
Patch: Dave Watson

Added an accept timeout to the TServerSocket poll loop

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1170443 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Wed, 14 Sep 2011 03:43:49 +0000 (03:43 +0000)]

Thrift-1345: Allow building without test cases
Client: build env
Patch: Vitali Lovich

Adds --without-tests to configure to omit processing/building the test directories.

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1170426 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Tue, 13 Sep 2011 13:54:46 +0000 (13:54 +0000)]

fix spelling issue within license

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1170181 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Tue, 13 Sep 2011 13:54:05 +0000 (13:54 +0000)]

THRIFT-1342 Compilation problem on Windows of fastbinary.c
Patch: alexandre parenteau

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1170180 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Mon, 12 Sep 2011 22:20:11 +0000 (22:20 +0000)]

THRIFT-1341 TProtocol.h endian detection wrong with boost
Patch: alexandre parenteau

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1169963 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Sun, 11 Sep 2011 18:16:21 +0000 (18:16 +0000)]

THRIFT-1115 python TBase class for dynamic (de)serialization, and __slots__ option for memory savings
Patch: Will Pierce

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1169492 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Sun, 11 Sep 2011 09:09:52 +0000 (09:09 +0000)]

uncomment handler parameter, so compile does not fail if they
are undefined

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1167686 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Sun, 11 Sep 2011 07:28:54 +0000 (07:28 +0000)]

THRIFT-1243 TAsyncChannel callbacks
improved exception handling
Patch: Alexandre Parenteau

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1167679 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Fri, 9 Sep 2011 08:17:02 +0000 (08:17 +0000)]

THRIFT-1238 Thrift JS client cannot read map of structures
Patch: Henrique Mendonca

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1167032 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Fri, 9 Sep 2011 06:19:35 +0000 (06:19 +0000)]

THRIFT-1296 SSL detection is broken

mingw toolchain used to build "Thrift Compiler for Windows"
does not support libcrypto, so we just check if we building the cpp library

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1167013 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Fri, 9 Sep 2011 04:32:36 +0000 (04:32 +0000)]

THRIFT-1333: Make RWGuard not copyable
Client: cpp
Patch: Dave Watson

Copying would cause contained mutex to unlock twice, changing to noncopyable.

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1166996 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Fri, 9 Sep 2011 04:10:32 +0000 (04:10 +0000)]

Thrift-1334: Add more info to IllegalStateException
Client cpp
Patch: Dave Watson

Add support for the message field in IllegalStateException

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1166992 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Thu, 8 Sep 2011 16:57:40 +0000 (16:57 +0000)]

THRIFT-1332: TSSLTransportParameters class uses hard coded value keyManagerType: SunX509
Client: java
Patch: Vladimir Zhilyaev

Convert Keymanger and TrustManager over to using detected jvm values rather than hard coded.

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1166798 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Wed, 7 Sep 2011 18:12:34 +0000 (18:12 +0000)]

THRIFT-1328. java: TBaseHelper.toString(...) appends ByteBuffer data outside of valid buffer range

This patch now correctly considers both arrayOffset and position when determining how to access the backing array of a buffer.

Patch: Andy Schlaikjer

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1166292 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Tue, 6 Sep 2011 16:26:58 +0000 (16:26 +0000)]

Thrift-1322: OCaml lib fail to compile: Thrift.ml line 305, int vs int32 mismatch
Client: OCaml

Updates the ocaml lib INTERNAL and PROTOCOL error enums to use the correct numeric values

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1165753 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Tue, 6 Sep 2011 15:19:18 +0000 (15:19 +0000)]

Thrift-1279: type set is handled incorrectly when writing object
Client: php
Patch: Darius Staisiunas

Fixes issue to iIterate through scalar types correctly.

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1165703 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Mon, 5 Sep 2011 19:15:53 +0000 (19:15 +0000)]

THRIFT-1320 Consistency of configure generated config.h
Patch: Alexandre Parenteau

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1165400 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Fri, 2 Sep 2011 21:45:44 +0000 (21:45 +0000)]

THRIFT-322 IHttpHandler for Thrift
Patch: Nils Huegelmann

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1164723 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Fri, 2 Sep 2011 20:33:33 +0000 (20:33 +0000)]

remove unused variable sz
add .gitignore stuff

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1164696 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Thu, 1 Sep 2011 18:54:07 +0000 (18:54 +0000)]

THRIFT-1319. java: Mismatch between how a union reads and writes a container

This patch fixes the problem in the java generator (and removes an unnecessary comment). It also amends TestTUnion to catch this.

Patch: Armaan Sarkar

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1164202 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Thu, 1 Sep 2011 18:31:53 +0000 (18:31 +0000)]

THRIFT-1316. cpp: update server classes to accept
TProcessorFactory objects

Patch: Adam Simpkins

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1164201 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Thu, 1 Sep 2011 18:06:20 +0000 (18:06 +0000)]

THRIFT-1314. cpp: add TProcessorFactory

Patch: Adam Simpkins

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1164190 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Thu, 1 Sep 2011 18:00:37 +0000 (18:00 +0000)]

THRIFT-1315. cpp: generate server interface factory classes

Patch: Adam Simpkins

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1164187 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Thu, 1 Sep 2011 16:52:56 +0000 (16:52 +0000)]

THRIFT-1317. cpp: Remove copy constructibility from
thrift::concurrency::Guard

Patch: Jordan DeLong

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1164164 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Thu, 1 Sep 2011 16:50:28 +0000 (16:50 +0000)]

THRIFT-1305. cpp: make TConnection a private inner class of
TNonblockingServer

The previous patch reverted some elements of THRIFT-1217. Fixed.

Patch: Alexandre Parenteau

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1164161 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Tue, 30 Aug 2011 19:12:10 +0000 (19:12 +0000)]

Thrift-1286: Modernize the Thrift Ruby Library Dev Environment
Client: Ruby
Patch: jfarrell

Updates to ruby build process with the following changes:
- Removes dependency on echoe for spec generation
- Adds gemfile for bulider and uses thrift.gemspec for dependency management.
- Adds checks in configure for builder and only calls if available (make check-local on ci servers)
- Adds checks in configure for Ruby and rake (bundler as well but this is optional for check-local and auto dependency management)
- Still allows for rake to do its thing if all dependencies are in place
- Removed Manifest and setup.rb
- Adds a install task which will generate a gem and then install that gem to locally configured ruby path (no more prefix or destdir with this client)

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1163341 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Mon, 29 Aug 2011 20:28:23 +0000 (20:28 +0000)]

THRIFT-1305. cpp: make TConnection a private inner class of
TNonblockingServer

Patch: Adam Simpkins

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1162987 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Mon, 29 Aug 2011 18:50:12 +0000 (18:50 +0000)]

THRIFT-1304. cpp: TNonblockingServer: pass in the connection context to
process()

Patch: Adam Simpkins

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1162943 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Mon, 29 Aug 2011 18:34:41 +0000 (18:34 +0000)]

THRIFT-1306: Fix stale documentation
Client: cpp
Patch: Diwaker Gupta

Fix documentation to match API change. Also format to 80 chars.

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1162937 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Mon, 29 Aug 2011 18:22:11 +0000 (18:22 +0000)]

Thrift-1299: If SSL is available, 'thrift' binary links against it
Patch: jfarrell

Removes the dependencies added from configure.ac in the thrift compiler makefile.

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1162927 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Mon, 29 Aug 2011 18:18:55 +0000 (18:18 +0000)]

Thrift-1296: SSL detection is broken
Patch: jfarrell

Updated configure to check for crypto and then ssl and error along the way if unavailable.

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1162925 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Mon, 29 Aug 2011 18:05:26 +0000 (18:05 +0000)]

THRIFT-1302. cpp: raise an exception if send() times out in
TSocket::write()

Patch: Adam Simpkins

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1162923 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Mon, 29 Aug 2011 18:01:24 +0000 (18:01 +0000)]

THRIFT-1301. cpp: consolidate common code in TNonblockingServer constructors

Patch: Adam Simpkins

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1162920 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Mon, 29 Aug 2011 17:50:31 +0000 (17:50 +0000)]

THRIFT-1298. java: Standard scheme doesn't read or write metadata along with field values

This patch makes StandardScheme write metadata, and adds tests against a static known-good Binary-serialized struct for a reference.

Patch: Armaan Sarkar

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1162917 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Mon, 29 Aug 2011 15:27:41 +0000 (15:27 +0000)]

Thrift-1303: Twisted tutorial client does not include correct generated path
Client: tutorial

Updated path in python client to include correct generated code.

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1162866 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Sun, 28 Aug 2011 18:24:45 +0000 (18:24 +0000)]

Thrift-1257: thrift's dependency scope on javax.servlet:servlet-api should be 'provided'
Client: java
Patch: jfarrell

Updated artifact servlet-api scope to provided.

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1162568 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Fri, 26 Aug 2011 02:42:14 +0000 (02:42 +0000)]

Thrift-1240: TBinarySerializer.php invalid serialization due to TBufferTransport not flushing last chunk of data into TMemoryBuffer
Client: php
Patch: Marimuthu Ponnambalam

Simple Serialization errors out, due to the TBufferTransport not flushing the data into TMemoryBuffer after $object->write($protocol) in TBinarySerializer.

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1161968 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Thu, 25 Aug 2011 22:02:38 +0000 (22:02 +0000)]

Thrift-1295: Duplicate include in TSocket.cpp
Client: cpp
Patch: Diwaker Gupta

TSocket.cpp includes netdb.in which is already included by TSocket.h.

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1161775 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Thu, 25 Aug 2011 17:43:56 +0000 (17:43 +0000)]

THRIFT-1294. cpp: fix log message typos in TSimpleServer
Patch: Adam Simpkins"

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1161663 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Thu, 25 Aug 2011 17:33:03 +0000 (17:33 +0000)]

THRIFT-1293. cpp: improve handling of exceptions thrown by
process()

Patch: Adam Simpkins

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1161660 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Thu, 25 Aug 2011 17:30:21 +0000 (17:30 +0000)]

THRIFT-1292. cpp: silence log spew from TThreadedServer

Patch: Adam Simpkins

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1161659 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Thu, 25 Aug 2011 17:28:23 +0000 (17:28 +0000)]

THRIFT-1290. cpp: TNonblockingServer: clean up state in the
destructor

Patch: Adam Simpkins

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1161655 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Wed, 24 Aug 2011 21:26:48 +0000 (21:26 +0000)]

THRIFT-1289. cpp: implement TNonblockingServer::stop()

Patch: Adam Simpkins

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1161283 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Wed, 24 Aug 2011 20:53:03 +0000 (20:53 +0000)]

THRIFT-1288. cpp: Allow typedefed exceptions in throws clauses

Patch: David Reiss

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1161271 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Wed, 24 Aug 2011 18:35:55 +0000 (18:35 +0000)]

THRIFT-1287. cpp: start refactoring some of the C++ processor

Move the generation of Processors into a separate subclass.

Patch: Adam Simpkins

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1161223 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Wed, 24 Aug 2011 00:35:52 +0000 (00:35 +0000)]

THRIFT-1280. cpp: Improve Monitor exception-free interfaces

Patch: Mark Rabkin

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1160944 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Wed, 24 Aug 2011 00:28:18 +0000 (00:28 +0000)]

THRIFT-1281. compiler: add @generated to the docblock

Patch: Bill Fumerola

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1160943 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Wed, 24 Aug 2011 00:22:30 +0000 (00:22 +0000)]

THRIFT-1282. java: Upgrade httpclient to 4.1.2 (from 4.0.1)

Patch: Aravind Srini

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1160941 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 23 Aug 2011 23:26:58 +0000 (23:26 +0000)]

THRIFT-1284. cpp: fix processor inheritance

Don't make processors that have a proper parent class also inherit from TProcessor.

Patch: Adam Simpkins

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1160933 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 23 Aug 2011 23:21:59 +0000 (23:21 +0000)]

THRIFT-1283. cpp: wrap t_cpp_generator::generate_process_function() to 80

Adjust the line width to 80 for generated CPP classes.

Patch: Adam Simpkins

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1160931 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Tue, 23 Aug 2011 20:27:19 +0000 (20:27 +0000)]

THRIFT-1278 javadoc warnings - compilation
Patch: Aravind Srini

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1160883 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Mon, 22 Aug 2011 21:38:50 +0000 (21:38 +0000)]

THRIFT-1269 thrift: handle undeclared exceptions in the async

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1160453 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Mon, 22 Aug 2011 21:38:16 +0000 (21:38 +0000)]

THRIFT-1274 Making * a known symbol

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1160451 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Mon, 22 Aug 2011 16:59:20 +0000 (16:59 +0000)]

THRIFT-1254. javame: Code can't be compiled against a regular JRE: Object.clone() override has a different return type

This patch mirrors a previous commit to the main Java library by removing the clone() implementation altogether.

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1160333 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Fri, 19 Aug 2011 18:32:51 +0000 (18:32 +0000)]

THRIFT-1271. cpp: missing namespace in generated local reflection

Patch: Adam Simpkins

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1159734 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Fri, 19 Aug 2011 18:27:47 +0000 (18:27 +0000)]

THRIFT-1274. compiler: fail compilation if an unexpected token is encountered

This patch makes the lexer throw an exception when an unexpected token is encountered, as opposed to the standard behavior of just printing it out and doing nothing.

Patch: Adam Simpkins

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1159733 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Fri, 19 Aug 2011 18:23:39 +0000 (18:23 +0000)]

THRIFT-1275. cpp: always prefix namespaces with ' ::'

Ensures no accidental namespace clashes.

Patch: Adam Simpkins

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1159729 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Fri, 19 Aug 2011 11:25:39 +0000 (11:25 +0000)]

THRIFT-1276 Add thrift compiler option to suppress warnings about
Patch: Dave Watson

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1159593 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Thu, 18 Aug 2011 20:31:16 +0000 (20:31 +0000)]

(void) unused parameters to reduce compiler warnings to zero!

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1159405 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Thu, 18 Aug 2011 00:02:50 +0000 (00:02 +0000)]

THRIFT-1167. java: Java nonblocking server with more than one thread for select and handling IO

This patch refactors the nonblocking server hierarchy and adds in a new server that has a threaded selector pool as well as a threaded invoker pool.

Patch: Steve Jiang

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1158977 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Wed, 17 Aug 2011 23:17:04 +0000 (23:17 +0000)]

THRIFT-1270. compiler: add --allow-neg-keys argument to allow

This switch allows the user to specify explicit negative field IDs in Thrift IDL in order to avoid breaking wire protocol.

Patch: Dave Watson

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1158967 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Wed, 17 Aug 2011 19:00:33 +0000 (19:00 +0000)]

Updating python setup.py for deploying client to pypi

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1158869 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Tue, 16 Aug 2011 17:13:41 +0000 (17:13 +0000)]

Thrift-1263: Updating rb client Rakefile to add suport for publishing client to rubygems.org
Client: Ruby
Patch: Jfarrell

Updating Rakefile to remove deprecated functions and add support for publishing to rubgems.org

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1158383 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Sat, 13 Aug 2011 21:29:36 +0000 (21:29 +0000)]

updating trunk from 0.7.0-dev to 0.8.0-dev

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1157426 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Jake Farrell [Thu, 11 Aug 2011 19:11:26 +0000 (19:11 +0000)]

Removing duplicate java client properties seen during release process

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1156747 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Thu, 11 Aug 2011 18:54:11 +0000 (18:54 +0000)]

THRIFT-1205. java: port server unduly fragile with arbitrary input

Increase the default max frame size to 16MB.

Patch: Ryan King

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1156731 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Thu, 11 Aug 2011 18:50:58 +0000 (18:50 +0000)]

THRIFT-169. java: Pluggable Serializers
THRIFT-1239. java: TupleProtocol- An extremely compact, temporary protocol

This monster commit is the combination of the two above tickets, providing a new serialization framework and the first new consumer in one go.

Patch: Armaan Sarkar

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1156728 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Thu, 4 Aug 2011 23:08:35 +0000 (23:08 +0000)]

THRIFT-1241 php namespace generation
realization of THRIFT-777

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1154045 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Thu, 4 Aug 2011 22:37:16 +0000 (22:37 +0000)]

THRIFT-916 do not mix declarations and code
issue detected with -Werror

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1154040 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Thu, 4 Aug 2011 22:36:07 +0000 (22:36 +0000)]

fix memoryleak detected by cppcheck

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1154039 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Thu, 4 Aug 2011 21:23:27 +0000 (21:23 +0000)]

THRIFT-916 remove i64 => fix build and compile without warning on CI

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1154022 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Wed, 3 Aug 2011 21:21:43 +0000 (21:21 +0000)]

THRIFT-1249 js-test-driver support (run unittests on multiple browsers and get XML test results)

additonal improvements
- unit test log in XML
- fetch local copy of jslibs to build/js/lib/
- remove unused json2.js
- some lint on test.js

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1153673 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Wed, 3 Aug 2011 20:12:32 +0000 (20:12 +0000)]

THRIFT-916 printf %lld for 32bit platform only by using __ia64__

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1153638 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Roger Meier [Wed, 3 Aug 2011 17:36:55 +0000 (17:36 +0000)]

THRIFT-1256 Unit Test Logging Output for CI
pass BOOST environment variables to the test suite arguments and create a tests.xml with the results

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1153594 13f79535-47bb-0310-9956-ffa450edef68

Unnamed repository; edit this file 'description' to name the repository.