common/thrift.git
16 years agoTHRIFT-282. Move generate_docstring_comment to t_generator
David Reiss [Thu, 26 Mar 2009 08:40:18 +0000 (08:40 +0000)] 
THRIFT-282. Move generate_docstring_comment to t_generator

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758556 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-255. cpp: Add TSimpleFileTransport, a wrapper around TFDTransport
David Reiss [Thu, 26 Mar 2009 06:23:57 +0000 (06:23 +0000)] 
THRIFT-255. cpp: Add TSimpleFileTransport, a wrapper around TFDTransport

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758533 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-154. python: Make THttpClient take a URL in its constructor
David Reiss [Thu, 26 Mar 2009 06:22:18 +0000 (06:22 +0000)] 
THRIFT-154. python: Make THttpClient take a URL in its constructor

Support https in the process.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758532 13f79535-47bb-0310-9956-ffa450edef68

16 years agocpp: Eliminate a buffer overflow in the tutorial server
David Reiss [Thu, 26 Mar 2009 06:15:26 +0000 (06:15 +0000)] 
cpp: Eliminate a buffer overflow in the tutorial server

Negative numbers can have 11 characters :)

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758529 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-405. php: Create a tutorial server
David Reiss [Thu, 26 Mar 2009 06:15:05 +0000 (06:15 +0000)] 
THRIFT-405. php: Create a tutorial server

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758528 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-404. php: Make TPhpStream work for cli (cgi) scripts
David Reiss [Thu, 26 Mar 2009 06:14:45 +0000 (06:14 +0000)] 
THRIFT-404. php: Make TPhpStream work for cli (cgi) scripts

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758526 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix the arguments in tutorial/README
David Reiss [Thu, 26 Mar 2009 06:14:17 +0000 (06:14 +0000)] 
Fix the arguments in tutorial/README

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758525 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-408. rb: Ruby C extension doesn't build on 1.8.5
Bryan Duxbury [Thu, 26 Mar 2009 04:55:34 +0000 (04:55 +0000)] 
THRIFT-408. rb: Ruby C extension doesn't build on 1.8.5

This patch redefines the important macros so 1.8.5 is compatible.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758517 13f79535-47bb-0310-9956-ffa450edef68

16 years agophp: Improve some docblock comments for TSocket
David Reiss [Thu, 26 Mar 2009 04:27:47 +0000 (04:27 +0000)] 
php: Improve some docblock comments for TSocket

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758516 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-401. rb: Speed up FramedTransport
Kevin Clark [Thu, 26 Mar 2009 03:46:58 +0000 (03:46 +0000)] 
THRIFT-401. rb: Speed up FramedTransport

Author: Tyler Kovacs

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758510 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUpdate tutorial/README now that Thrift files don't support shebang
David Reiss [Wed, 25 Mar 2009 22:15:18 +0000 (22:15 +0000)] 
Update tutorial/README now that Thrift files don't support shebang

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758453 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-374. rb: ruby 1.9 compatibility
Bryan Duxbury [Wed, 25 Mar 2009 21:06:53 +0000 (21:06 +0000)] 
THRIFT-374. rb: ruby 1.9 compatibility

This patch updates the thrift_native package to use 1.9 compatible macros and fixes the pure ruby stuff to behave equally well in ruby1.8.6-ruby1.9.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758435 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-329. python: Make TServerSocket.close() work properly
David Reiss [Tue, 24 Mar 2009 22:51:02 +0000 (22:51 +0000)] 
THRIFT-329. python: Make TServerSocket.close() work properly

Changing the order of inheritance makes "close" refer to the
(correct) TSocketBase method, rather than the (stub)
TServerTransportBase method.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758072 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-360. python: Make fastbinary skip struct fields with the wrong type
David Reiss [Tue, 24 Mar 2009 22:48:40 +0000 (22:48 +0000)] 
THRIFT-360. python: Make fastbinary skip struct fields with the wrong type

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758071 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-402. rb: MemoryBuffer > 4096 bytes will truncate remaining bytes
Bryan Duxbury [Tue, 24 Mar 2009 21:10:14 +0000 (21:10 +0000)] 
THRIFT-402. rb: MemoryBuffer > 4096 bytes will truncate remaining bytes

This patch fixes the issue, preserving the remaining bytes.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758024 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-155. python: Reopen THttpClient on a flush
David Reiss [Tue, 24 Mar 2009 20:10:24 +0000 (20:10 +0000)] 
THRIFT-155. python: Reopen THttpClient on a flush

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@757996 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-136. s/async/oneway/ in the Thrift IDL
David Reiss [Tue, 24 Mar 2009 20:02:22 +0000 (20:02 +0000)] 
THRIFT-136. s/async/oneway/ in the Thrift IDL

This is the real change.  The lexer now recognizes "oneway"
and warns on "async".  All example and test IDLs have been
updated, as have the syntax files.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@757994 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-136. s/async/oneway/ in Erlang
David Reiss [Tue, 24 Mar 2009 20:02:08 +0000 (20:02 +0000)] 
THRIFT-136. s/async/oneway/ in Erlang

This is kind of a bummer because it requires a simultaneous
code regeneration and library upgrade, and possibly also a
server restart.  I'm not sure if it is worth it, since the
only benefit is a little code clarity.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@757993 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-136. s/async/oneway/ in misc places
David Reiss [Tue, 24 Mar 2009 20:01:58 +0000 (20:01 +0000)] 
THRIFT-136. s/async/oneway/ in misc places

This is mostly an internal-only change.
It affects docstrings, messages, variables, test cases, etc.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@757992 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-136. s/async/oneway/ in comments
David Reiss [Tue, 24 Mar 2009 20:01:25 +0000 (20:01 +0000)] 
THRIFT-136. s/async/oneway/ in comments

This is an internal-only change.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@757990 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-136. s/async/oneway/ in compiler variables
David Reiss [Tue, 24 Mar 2009 20:01:02 +0000 (20:01 +0000)] 
THRIFT-136. s/async/oneway/ in compiler variables

This is an internal-only change.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@757989 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-136. s/async/oneway/ in lexer and parser variables
David Reiss [Tue, 24 Mar 2009 20:00:47 +0000 (20:00 +0000)] 
THRIFT-136. s/async/oneway/ in lexer and parser variables

This is an internal-only change.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@757988 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-192. erl: Fix handling of booleans
Kevin Clark [Tue, 24 Mar 2009 16:04:36 +0000 (16:04 +0000)] 
THRIFT-192. erl: Fix handling of booleans

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@757870 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-399. hs: Fix set and number issues in generated constant code
Kevin Clark [Tue, 24 Mar 2009 15:56:19 +0000 (15:56 +0000)] 
THRIFT-399. hs: Fix set and number issues in generated constant code

Author: Spiridon Eliopoulos

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@757864 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-398. hs: Remove unnecessary parens from generated type annotations
Kevin Clark [Tue, 24 Mar 2009 14:51:51 +0000 (14:51 +0000)] 
THRIFT-398. hs: Remove unnecessary parens from generated type annotations

Author: Spiridon Eliopoulos

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@757825 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-397. hs: Remove unnecessary redefinition of generate_program()
Kevin Clark [Tue, 24 Mar 2009 14:47:31 +0000 (14:47 +0000)] 
THRIFT-397. hs: Remove unnecessary redefinition of generate_program()

Author: Spiridon Eliopoulos

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@757824 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-275. rb: Remove deprecated classes from Ruby library
Bryan Duxbury [Tue, 24 Mar 2009 05:23:52 +0000 (05:23 +0000)] 
THRIFT-275. rb: Remove deprecated classes from Ruby library

This patch removes all the deprecation stuff and the t*.rb classes that were only placeholders. In addition, I've changed the implementations of some "abstract" methods to throw NotImplementedError instead of returning nil, and fixed the test accordingly. Finally, I removed the no longer required borrow and consume methods from all the transport implementations that had them. (Borrow and consume have been supplanted by the thrift_native package.)

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@757668 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-391. py: Fix memory leak in fastbinary
Kevin Clark [Tue, 24 Mar 2009 01:40:56 +0000 (01:40 +0000)] 
THRIFT-391. py: Fix memory leak in fastbinary

Author: Alexander Shigin

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@757634 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-382. java: Unused imports in generated code
Bryan Duxbury [Tue, 24 Mar 2009 00:43:33 +0000 (00:43 +0000)] 
THRIFT-382. java:  Unused imports in generated code

Regrouped some of the imports and removed ones that will never be used.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@757623 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-32. thrift.el doesn't syntax highlight single line comments correctly in xemacs
Bryan Duxbury [Tue, 24 Mar 2009 00:39:27 +0000 (00:39 +0000)] 
THRIFT-32. thrift.el doesn't syntax highlight single line comments correctly in xemacs

Even though Todd didn't give me an easy patch to apply, I still figured it out because I just like the guy so much.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@757621 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-392. hs: Make test scripts easier to use
Bryan Duxbury [Tue, 24 Mar 2009 00:36:00 +0000 (00:36 +0000)] 
THRIFT-392. hs: Make test scripts easier to use

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@757620 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-385. hs: 64-bit integer and double types incorrectly serialized on 32-bit...
Bryan Duxbury [Tue, 24 Mar 2009 00:34:16 +0000 (00:34 +0000)] 
THRIFT-385. hs: 64-bit integer and double types incorrectly serialized on 32-bit platforms

Use 64-bit types where appropriate.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@757619 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-266. erlang: Erlang atoms must always start with lower-case character
Bryan Duxbury [Tue, 24 Mar 2009 00:28:40 +0000 (00:28 +0000)] 
THRIFT-266. erlang: Erlang atoms must always start with lower-case character

Forces first char of atom to lowercase for struct fields.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@757617 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-312. rb: Ruby unit tests fail due to change in BinaryProtocolAccelerated interface
Bryan Duxbury [Tue, 24 Mar 2009 00:08:45 +0000 (00:08 +0000)] 
THRIFT-312. rb: Ruby unit tests fail due to change in BinaryProtocolAccelerated interface

Couldn't find any broken tests anymore, but did remove some dead code that had been commented in the binary protocol spec.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@757610 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-396. rb: BinaryProtocol missing method implementations
Bryan Duxbury [Mon, 23 Mar 2009 23:36:16 +0000 (23:36 +0000)] 
THRIFT-396. rb: BinaryProtocol missing method implementations

Added missing implementations of write_struct_begin and read_struct_begin to BinaryProtocol.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@757599 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-375. rb: syntax error in benchmark.rb
Bryan Duxbury [Fri, 20 Mar 2009 16:54:33 +0000 (16:54 +0000)] 
THRIFT-375. rb: syntax error in benchmark.rb

Fixed the syntax error.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@756617 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-262. java: Generate Javadocs for library classes
Bryan Duxbury [Fri, 20 Mar 2009 16:43:06 +0000 (16:43 +0000)] 
THRIFT-262. java: Generate Javadocs for library classes

This patch adds a 'javadoc' Ant target, and installs the documentation to ${docdir}/thrift/java (/usr/local/share/doc/thrift/java with the default invocation of configure). It also fixes a few Javadoc warnings in the source code.

It also modifies the 'dist' target to include the Java sources in the jar file, so that Eclipse may show the javadocs for Thrift classes automatically (this increases the size of libthrift.jar from 90 Kb to 155 Kb).

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@756603 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-293. Make the README point to the Wiki for requirements
David Reiss [Fri, 20 Mar 2009 07:15:04 +0000 (07:15 +0000)] 
THRIFT-293. Make the README point to the Wiki for requirements

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@756354 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix a parallel build bug under test
David Reiss [Fri, 20 Mar 2009 07:14:50 +0000 (07:14 +0000)] 
Fix a parallel build bug under test

The "_extras.cpp" files depend on the appropriate ".h" files,
but that dependency is not listed in the Makefile, and cannot
be determined automatically by automake because the .h files
are generated.  Add explicit dependencies so "make -j8 check"
works.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@756353 13f79535-47bb-0310-9956-ffa450edef68

16 years agoGet a few more generated files into release tarballs
David Reiss [Fri, 20 Mar 2009 07:02:52 +0000 (07:02 +0000)] 
Get a few more generated files into release tarballs

The generated code for the C++ automated tests is all put into
one (non-installed) library.  This change updates the list of
sources for the library to (1) eliminate sources that aren't
used and (1) include the relevant header files.  The headers
aren't acutally built into the library, but listing them causes
them to be included in the release tarball.  They also had to
be added to the code-generating rules so make would know how
to build them.  Now "make check" works out of the box in
release tarballs (after configure).

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@756347 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd Apache headers to Ruby libs and remove a few remaining Facebook notices
Kevin Clark [Fri, 20 Mar 2009 04:21:39 +0000 (04:21 +0000)] 
Add Apache headers to Ruby libs and remove a few remaining Facebook notices

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@756322 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-158. csharp: Update headers to Apache
Kevin Clark [Fri, 20 Mar 2009 02:28:41 +0000 (02:28 +0000)] 
THRIFT-158. csharp: Update headers to Apache

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@756311 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-313. rb: BinaryProtocolAccelerated and BinaryProtocol don't produce the same...
Bryan Duxbury [Fri, 20 Mar 2009 02:21:05 +0000 (02:21 +0000)] 
THRIFT-313. rb: BinaryProtocolAccelerated and BinaryProtocol don't produce the same bytes when writes aren't strict

A Fixnum was not properly being converted to its native value before being written. This patch rectifies that problem.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@756308 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-294. Remove @author tags
Bryan Duxbury [Fri, 20 Mar 2009 02:19:46 +0000 (02:19 +0000)] 
THRIFT-294. Remove @author tags

They're gone. Don't add any new ones!

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@756307 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-245. rb: FIELDS constant should contain name of enumerated type for enum fields
Bryan Duxbury [Fri, 20 Mar 2009 01:51:16 +0000 (01:51 +0000)] 
THRIFT-245. rb: FIELDS constant should contain name of enumerated type for enum fields

This patch adds the :enum_class key to FIELDS entries that are enums.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@756295 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-260. rb: Some Protocol methods shouldn't have default nil implementations
Bryan Duxbury [Fri, 20 Mar 2009 01:49:53 +0000 (01:49 +0000)] 
THRIFT-260. rb: Some Protocol methods shouldn't have default nil implementations

This patch makes most of the methods in Thrift::Protocol throw NotImplementedExceptions.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@756293 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-384. csharp: Fix handling of fields named "value"
David Reiss [Thu, 19 Mar 2009 20:33:15 +0000 (20:33 +0000)] 
THRIFT-384. csharp: Fix handling of fields named "value"

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@756179 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-332. rb: Compact Protocol in Ruby
Bryan Duxbury [Thu, 19 Mar 2009 18:57:43 +0000 (18:57 +0000)] 
THRIFT-332. rb: Compact Protocol in Ruby

This patch includes both a pure Ruby and C-extension port of the Compact Protocol described in THRIFT-110. It also fixes a bug in struct.c that was interfering with native protocol method calls, and adds some utility classes to the Java library for serializing/deserializing to a file for the purpose of testing protocols cross-language.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@756133 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-361. Use separate negative id counters for arguments and exceptions
David Reiss [Thu, 19 Mar 2009 08:14:12 +0000 (08:14 +0000)] 
THRIFT-361. Use separate negative id counters for arguments and exceptions

NOTE:
This will break wire-compatibility, but only with functions that have
both negative-id arguments and negative id-exceptions, and only in the
exceptional case.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@755870 13f79535-47bb-0310-9956-ffa450edef68

16 years agoThrift-357. cpp: Fix buffer and connection bloat in TNonBlockingServer
Kevin Clark [Thu, 19 Mar 2009 03:50:05 +0000 (03:50 +0000)] 
Thrift-357. cpp: Fix buffer and connection bloat in TNonBlockingServer

Author: Anthony Giardullo

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@755824 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-373. Update lists of files to include in release tarballs
David Reiss [Wed, 18 Mar 2009 23:59:56 +0000 (23:59 +0000)] 
THRIFT-373. Update lists of files to include in release tarballs

This is mostly EXTRA_DIST, but also includes some headers.
I had to drill down into test because "make dist" builds some
of the test code.  .gitignore is not included in the tarballs.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@755791 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-362. python: Detect endianness on Solaris
David Reiss [Wed, 18 Mar 2009 23:14:13 +0000 (23:14 +0000)] 
THRIFT-362. python: Detect endianness on Solaris

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@755776 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-379. java: Print enum value names
Bryan Duxbury [Wed, 18 Mar 2009 03:14:56 +0000 (03:14 +0000)] 
THRIFT-379. java: Print enum value names

This patch adds a new generated map of enum values to their respective names to each generated enum class, and then consumes that in the toString method to print the names when possible.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@755464 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-367. java: Some dead code in TNonblockingSocket.java
Bryan Duxbury [Wed, 18 Mar 2009 02:47:02 +0000 (02:47 +0000)] 
THRIFT-367. java: Some dead code in TNonblockingSocket.java

All the blocks of commented code are removed.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@755463 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-277. rb: Abstract Transport in Ruby #read method should throw NotImplementedEx...
Bryan Duxbury [Wed, 18 Mar 2009 02:40:54 +0000 (02:40 +0000)] 
THRIFT-277. rb: Abstract Transport in Ruby #read method should throw NotImplementedException

The name says it all.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@755460 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-278. java: #validate exceptions should contain the offending value
Bryan Duxbury [Wed, 18 Mar 2009 01:50:50 +0000 (01:50 +0000)] 
THRIFT-278. java: #validate exceptions should contain the offending value

This patch causes validate to throw exceptions that contain the bad field value as well as the field name. I had to modify it slightly from the patch on the issue to conform with the new style isset checks.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@755454 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-365. html: HTML compiler infinite loop
Bryan Duxbury [Tue, 17 Mar 2009 21:55:36 +0000 (21:55 +0000)] 
THRIFT-365. html:  HTML compiler infinite loop

Trivial fix for 64-bit systems.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@755413 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-351. cpp: Allow a custom ThreadFactory in TThreadedServer
David Reiss [Sat, 14 Mar 2009 23:35:16 +0000 (23:35 +0000)] 
THRIFT-351. cpp: Allow a custom ThreadFactory in TThreadedServer

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@754551 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMake .thrift files non-executable since we removed the shebangs
David Reiss [Sat, 14 Mar 2009 07:37:28 +0000 (07:37 +0000)] 
Make .thrift files non-executable since we removed the shebangs

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@753610 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix a test in ax_lib_zlib
David Reiss [Fri, 13 Mar 2009 21:25:31 +0000 (21:25 +0000)] 
Fix a test in ax_lib_zlib

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@753429 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-300. A reimplementation of ax_java
David Reiss [Fri, 13 Mar 2009 21:25:29 +0000 (21:25 +0000)] 
THRIFT-300. A reimplementation of ax_java

Completely replace ax_java.m4 with ax_javac_and_java, which is
a clean-room implementation of an autoconf macro to detect Java.
It has some limitations compared to the ax_java macros in
The Autoconf Macro archive, but it has two key advantages.
It is not GPL-licensed.  It doesn't abort configure if Java is
not found.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@753428 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-368. java: setFieldValue should allow nulls for all field types
Bryan Duxbury [Fri, 13 Mar 2009 18:28:40 +0000 (18:28 +0000)] 
THRIFT-368. java: setFieldValue should allow nulls for all field types

After this patch, setFieldValue will treat a set with a null as an unset.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@753337 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-366. java: Lots of little warnings in java library
Bryan Duxbury [Fri, 13 Mar 2009 00:28:06 +0000 (00:28 +0000)] 
THRIFT-366. java: Lots of little warnings in java library

This cleans up imports, adds generic arguments where necessary, and puts OverloadNonblockingServer into the right package.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@753072 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-364. java: Use of enums in other namespaces breaks java generated code
Bryan Duxbury [Wed, 11 Mar 2009 23:40:57 +0000 (23:40 +0000)] 
THRIFT-364. java: Use of enums in other namespaces breaks java generated code

This patch checks for different namespaces and prefixes appropriately.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@752696 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-359. java: nocamel style breaks generated services
Bryan Duxbury [Sat, 7 Mar 2009 03:08:37 +0000 (03:08 +0000)] 
THRIFT-359. java:  nocamel style breaks generated services

This patch makes the generated code respect the nocamel option.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@751180 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-229. rb: Don't block indefinitely on connect()
Kevin Clark [Sat, 7 Mar 2009 00:03:15 +0000 (00:03 +0000)] 
THRIFT-229. rb: Don't block indefinitely on connect()

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@751142 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-358. ruby: Change how external thrift files' generated code is required
Bryan Duxbury [Thu, 5 Mar 2009 23:11:37 +0000 (23:11 +0000)] 
THRIFT-358. ruby:  Change how external thrift files' generated code is required

Generated code that relies on included thrift files now doesn't assume the path will be the same.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@750667 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-96. cpp: TSocket.peek fails on FreeBSD
Kevin Clark [Thu, 5 Mar 2009 21:05:37 +0000 (21:05 +0000)] 
THRIFT-96. cpp: TSocket.peek fails on FreeBSD

Author: Alexander Shigin

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@750585 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove now defunct tests (they've been moved to specs in lib/rb)
Kevin Clark [Wed, 4 Mar 2009 22:06:59 +0000 (22:06 +0000)] 
Remove now defunct tests (they've been moved to specs in lib/rb)

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@750188 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-352. rb: Implicit enums should be valid values
Kevin Clark [Wed, 4 Mar 2009 21:42:46 +0000 (21:42 +0000)] 
THRIFT-352. rb: Implicit enums should be valid values

Author: Gary Tsang

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@750171 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-353. rb: Capitalize module names on ruby generation
Kevin Clark [Wed, 4 Mar 2009 21:32:54 +0000 (21:32 +0000)] 
THRIFT-353. rb: Capitalize module names on ruby generation

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@750160 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-265. cpp: Reset buffers every 512 calls in TNonblockingServer
Kevin Clark [Wed, 4 Mar 2009 21:10:58 +0000 (21:10 +0000)] 
THRIFT-265. cpp: Reset buffers every 512 calls in TNonblockingServer

Author: Erik Frey

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@750153 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-148. py: One more time, reapply the most *recent* patch
Kevin Clark [Tue, 3 Mar 2009 22:13:46 +0000 (22:13 +0000)] 
THRIFT-148. py: One more time, reapply the most *recent* patch

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@749795 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-148. py: Add un-commited file missing from 749510
Kevin Clark [Tue, 3 Mar 2009 22:03:57 +0000 (22:03 +0000)] 
THRIFT-148. py: Add un-commited file missing from 749510

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@749786 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-148. py: Add support for Twisted
Kevin Clark [Tue, 3 Mar 2009 02:25:50 +0000 (02:25 +0000)] 
THRIFT-148. py: Add support for Twisted

Author: Esteve Fernandez

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@749510 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-324: replace strlen with length
T Jake Luciani [Mon, 2 Mar 2009 23:47:20 +0000 (23:47 +0000)] 
THRIFT-324: replace strlen with length

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@749478 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPerl library should honor the INSTALLDIRS variable
Kevin Clark [Mon, 2 Mar 2009 23:29:54 +0000 (23:29 +0000)] 
Perl library should honor the INSTALLDIRS variable

Author: Esteve Fernandez

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@749472 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-348. cpp: Fix readBool for vectors of bools (again)
David Reiss [Wed, 25 Feb 2009 00:59:55 +0000 (00:59 +0000)] 
THRIFT-348. cpp: Fix readBool for vectors of bools (again)

This bug only affected the returned number bytes read
(which is not currently used), not the actual bool value.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@747635 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-116. java: Isset fields for non-primitive types unnecessary
Bryan Duxbury [Mon, 23 Feb 2009 17:49:24 +0000 (17:49 +0000)] 
THRIFT-116. java: Isset fields for non-primitive types unnecessary

Prior commit on this issue was missing a !.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@747090 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-116. java: Isset fields for non-primitive types unnecessary
Bryan Duxbury [Sat, 21 Feb 2009 01:57:46 +0000 (01:57 +0000)] 
THRIFT-116. java: Isset fields for non-primitive types unnecessary

Missed one of the cases where isset was being used on non-primitive fields.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@746429 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-116. java: Isset fields for non-primitive types unnecessary
Bryan Duxbury [Thu, 19 Feb 2009 21:21:44 +0000 (21:21 +0000)] 
THRIFT-116. java: Isset fields for non-primitive types unnecessary

This patch gets rid of the __isset fields for non-primitives and updates ToStringTest and EqualityTest appropriately.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@746000 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-325. Remove a bunch of uses of the old command line format
David Reiss [Tue, 17 Feb 2009 20:28:46 +0000 (20:28 +0000)] 
THRIFT-325. Remove a bunch of uses of the old command line format

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745242 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMake the PHP generator use non-hardcoded namespaces.
David Reiss [Tue, 17 Feb 2009 20:28:37 +0000 (20:28 +0000)] 
Make the PHP generator use non-hardcoded namespaces.

- Make the PHP generator use program->get_namespace("php")
  instead of program->get_php_namespace()
- Eliminate the explicit "php_namespace" in t_program.
- Deprecate the php_namespace token.
- Update example .thrift files and syntax files.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745241 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAllow the Thrift compiler to be built without the PHP generator.
David Reiss [Tue, 17 Feb 2009 20:28:30 +0000 (20:28 +0000)] 
Allow the Thrift compiler to be built without the PHP generator.

- Use AX_THRIFT_GEN to make configure support --disable-gen-php
- Update the compiler Makefile.am to exclude the generator.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745240 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove t_php_generator.h.
David Reiss [Tue, 17 Feb 2009 20:28:28 +0000 (20:28 +0000)] 
Remove t_php_generator.h.

t_php_generator.h is no longer included anywhere, because
the PHP generator uses the new dynamic generator framework.
Therefore, we can collapse the class definition into the .cc file.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745239 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMake the PHP generator dynamic.
David Reiss [Tue, 17 Feb 2009 20:28:24 +0000 (20:28 +0000)] 
Make the PHP generator dynamic.

- Modify the PHP generator constructor to fit the new generic interface.
- Register the PHP genrator with the central registry.
- Deprecate the old way of invoking the PHP generator.
- main.cc no longer includes t_php_generator.h.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745238 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMake the XSD generator use non-hardcoded namespaces.
David Reiss [Tue, 17 Feb 2009 20:28:19 +0000 (20:28 +0000)] 
Make the XSD generator use non-hardcoded namespaces.

- Make the XSD generator use program->get_namespace("xsd")
  instead of program->get_xsd_namespace()
- Eliminate the explicit "xsd_namespace" in t_program.
- Deprecate the xsd_namespace token.
- Update example .thrift files and syntax files.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745237 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAllow the Thrift compiler to be built without the XSD generator.
David Reiss [Tue, 17 Feb 2009 20:28:13 +0000 (20:28 +0000)] 
Allow the Thrift compiler to be built without the XSD generator.

- Use AX_THRIFT_GEN to make configure support --disable-gen-xsd
- Update the compiler Makefile.am to exclude the generator.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745236 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove t_xsd_generator.h.
David Reiss [Tue, 17 Feb 2009 20:28:10 +0000 (20:28 +0000)] 
Remove t_xsd_generator.h.

t_xsd_generator.h is no longer included anywhere, because
the XSD generator uses the new dynamic generator framework.
Therefore, we can collapse the class definition into the .cc file.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745235 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMake the XSD generator dynamic.
David Reiss [Tue, 17 Feb 2009 20:28:06 +0000 (20:28 +0000)] 
Make the XSD generator dynamic.

- Modify the XSD generator constructor to fit the new generic interface.
- Register the XSD genrator with the central registry.
- Deprecate the old way of invoking the XSD generator.
- main.cc no longer includes t_xsd_generator.h.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745234 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAllow the Thrift compiler to be built without the Erlang generator.
David Reiss [Tue, 17 Feb 2009 20:28:01 +0000 (20:28 +0000)] 
Allow the Thrift compiler to be built without the Erlang generator.

- Use AX_THRIFT_GEN to make configure support --disable-gen-erl
- Update the compiler Makefile.am to exclude the generator.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745233 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove t_erl_generator.h.
David Reiss [Tue, 17 Feb 2009 20:27:58 +0000 (20:27 +0000)] 
Remove t_erl_generator.h.

t_erl_generator.h is no longer included anywhere, because
the Erlang generator uses the new dynamic generator framework.
Therefore, we can collapse the class definition into the .cc file.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745232 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMake the Erlang generator dynamic.
David Reiss [Tue, 17 Feb 2009 20:27:54 +0000 (20:27 +0000)] 
Make the Erlang generator dynamic.

- Modify the Erlang generator constructor to fit the new generic interface.
- Register the Erlang genrator with the central registry.
- Deprecate the old way of invoking the Erlang generator.
- main.cc no longer includes t_erl_generator.h.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745231 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-325. Include t_generator.h in main.cc
David Reiss [Tue, 17 Feb 2009 20:27:48 +0000 (20:27 +0000)] 
THRIFT-325. Include t_generator.h in main.cc

I'm about to remove all of the generator includes, but we'll still need
the generic header for the generator registry and interface.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745230 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-340. python: Detect endianness properly on FreeBSD
David Reiss [Tue, 17 Feb 2009 20:06:08 +0000 (20:06 +0000)] 
THRIFT-340. python: Detect endianness properly on FreeBSD

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745223 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-309. Make Thrift's C# mapping .NET 2.0 (Mono 1.2.4) compatible
David Reiss [Fri, 13 Feb 2009 03:09:52 +0000 (03:09 +0000)] 
THRIFT-309. Make Thrift's C# mapping .NET 2.0 (Mono 1.2.4) compatible

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@743963 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-199. perl: Let "make distclean" work when we are not using Perl
David Reiss [Wed, 11 Feb 2009 01:11:54 +0000 (01:11 +0000)] 
THRIFT-199. perl: Let "make distclean" work when we are not using Perl

When configure is run with --without-perl, lib/perl/Makefile.am cannot
generate Makefile-perl.mk.  However, "make distclean" still runs, so
the clean-local target fails.  This version just silently does nothing
when Perl is not being used.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@743190 13f79535-47bb-0310-9956-ffa450edef68

16 years agocpp: Fix implementations of "list<bool>"
David Reiss [Tue, 10 Feb 2009 21:38:48 +0000 (21:38 +0000)] 
cpp: Fix implementations of "list<bool>"

TProtocol::readBool expects a "bool&" as its argument, but "list<bool>"
is implemented as "vector<bool>", which is a specialization of vector
that uses a custom structure as its reference type.  Therefore, we need
to overload TProtocol::readBool for std::vector<bool>::reference.
This function is provided as a non-virtual for efficiency since it is
highly unlikely that any subclass will want to override it.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@743112 13f79535-47bb-0310-9956-ffa450edef68

16 years agocpp: Fix "make check" by defining a comparator for "Empty"
David Reiss [Tue, 10 Feb 2009 21:38:44 +0000 (21:38 +0000)] 
cpp: Fix "make check" by defining a comparator for "Empty"

The TCompactProtocol revision added a "set<Empty>" in DebugProtoTest.
C++ needs a comparator in order to link this.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@743111 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTHRIFT-316. java: @Override isn't generated for hashCode() without the hash code...
Bryan Duxbury [Tue, 10 Feb 2009 18:36:56 +0000 (18:36 +0000)] 
THRIFT-316. java: @Override isn't generated for hashCode() without the hash code builder

Fixed with a trivial reorganization of the hashCode method generation.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@743046 13f79535-47bb-0310-9956-ffa450edef68