eletuchy [Wed, 13 Jun 2007 04:24:11 +0000 (04:24 +0000)]
[thrift] small fixes to java generator
Summary: - size generated collections correctly
- StringBuilder vs StringBuffer
Reviewed By: mcslee
Test Plan: built TestThrift.thrift; it compiled, yay
Revert Plan: sure
Notes:
EImportant:
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665134
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Sat, 9 Jun 2007 01:23:04 +0000 (01:23 +0000)]
Darwin endianness junk
Reviewed By: darwin
Test Plan: build on OSX
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665133
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Sat, 9 Jun 2007 01:21:16 +0000 (01:21 +0000)]
Add thread pool option to NonblockingServer
Summary: If you want requests processed outside of the I/O thread
Reviewed By: jake luciani, aditya
Test Plan: nb-main.cpp, in the test folder
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665132
13f79535-47bb-0310-9956-
ffa450edef68
boz [Tue, 5 Jun 2007 22:41:18 +0000 (22:41 +0000)]
THRIFT: generic output handler
Summary: I'm tired of getting output from thrift via perror AND exceptions, so
this class allows the client to set an alternate (or empty) handler for error
output
Reviewed By: mcslee
Test Plan: I ran on the worker with the default, got output via perror, then
overloaded with my own function and got output via syslog and then NULL
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665131
13f79535-47bb-0310-9956-
ffa450edef68
Marc Slemko [Tue, 5 Jun 2007 22:20:14 +0000 (22:20 +0000)]
Modified PosixThreadFactory
Added explicit detached getter and setter
Modified PosixThreadFactory::~PThread:
Check for join failing and don't transition to detached_ state if it does. Potential thread-handle leak for
threads created joinable who aren't referenced by any external thread. Solution for now has to be
"DONT DO THAT", the clever approach doesn't always work.
Added ThreadFactoryTests.floodNThreads:
Loop M times for N threads where M x N is bigger than 32K to verify that detached threads can be created
ad infinitum.
Reviewed By: mcslee
Revert Plan: revertible
Test Plan: concurrency_test thread-factory passes
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665130
13f79535-47bb-0310-9956-
ffa450edef68
Marc Slemko [Mon, 4 Jun 2007 21:01:19 +0000 (21:01 +0000)]
Modified PosixThreadFactory::PThread:
Pay attention to detached flags. If thread is create non-detached and has not been joined when all references are given up,
(ie boost::share_ptr calls ~PThread) do the join in the destructor to prevent thread ids from being leaked.
Modified ThreadFactoryTests.reapNThreads:
Loop M times for M threads where M x N is bigger than 32K to verify that thread ids aren't leaked
Modified TimerManager.cpp:
Removed debug messages.
Reviewed By: mcslee
Revert Plan: revertible
Test Plan: concurrency_test thread-factory passes
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665129
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Fri, 1 Jun 2007 23:04:09 +0000 (23:04 +0000)]
Forgot to add ProcessorFactory
Reviewed By: biren
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665128
13f79535-47bb-0310-9956-
ffa450edef68
boz [Thu, 31 May 2007 23:38:37 +0000 (23:38 +0000)]
THRIFT: ADITYASLOP
Summary: thrift didn't compile
Reviewed By: marc
Test Plan: thrift compiles
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665127
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 31 May 2007 02:30:34 +0000 (02:30 +0000)]
Memory buffer for perl
Reviewed By: Jake Luciani
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665126
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Thu, 31 May 2007 01:33:07 +0000 (01:33 +0000)]
-- handle EINTRS in accept()
Summary:
- I love unix.
Reviewed By: mcslee
Test Plan: boz will test it
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665125
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 31 May 2007 01:30:22 +0000 (01:30 +0000)]
ProcessorFactory for Java
Reviewed By: simon forman
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665124
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 23 May 2007 05:16:07 +0000 (05:16 +0000)]
Get the long longs out of the Thrift codebase
Summary: Replace with int64_t and don't worry about what architecture machine you're on, the typedefed int64_t will do the right thing.
Reviewed By: aditya, marc
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665123
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 23 May 2007 04:55:30 +0000 (04:55 +0000)]
mcslee: being nitpicky ensuring consistent coding style
Summary: no tabs, conditionals with spaces around them, etc
Reviewed By: thrift style rules
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665122
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Wed, 23 May 2007 02:14:58 +0000 (02:14 +0000)]
-- fix read timeout handling in TSocket
Summary:
- turns out that EAGAIN can be returned both when there is a transmission timeout and when there
is a lack of system resources.
This diff has a hacky fix for respecting a user specified read timeout.
Reviewed By: Steve Grimm, Marc, Slee
Test Plan:
- Tested by trying to crash an srp machine
Revert Plan: No.
Notes:
- Also added functionality to allow users to specify the max number of recv retries (in the case
when EAGAIN is returned due to a lack of system resources)
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665121
13f79535-47bb-0310-9956-
ffa450edef68
Marc Slemko [Tue, 22 May 2007 23:59:54 +0000 (23:59 +0000)]
Modified facebook::thrift::concurrency::Monitor.wait:
Throw TimedOutException on wait timeout so caller can distinguish between timeout and event.
Modified facebook::thrift::concurrency::PthreadThread.start:
Throw SystemrResourceException on any pthread_* function call failure rather than asserting 0.
Added facebook::thrift::concurrency::Thread.id() and facebook::thrift::concurrency::ThreadFactory.currentThreadId():
Return thread-id of thread and current thread respectively. Needed for reentrancy tests in ThreadManager
Added facebook::thrift::concurrency::ThreadManager.pendingTaskCountMaxN
Modified facebook::thrift::concurrency::ThreadManager.add():
Now support a maximum pending task count and block if the current pending task count is max.
If timeout is specified for add, TimedOutException is thrown if pending task count doesn't decrease
in the timeout interval. If add() is called by a ThreadManager worker thread and the task cannot
be added, a TooManyPendingTasksException is thrown rather than blocking, since deadlocks can ensue
if worker threads block waiting for works threads to complete tasks.
Reviewed By: mcslee, aditya
Revert Plan: revertible
Test Plan: concurrency/test/ThreadManagerTests.h
run concurrency-test thread-manager
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665120
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 16 May 2007 21:22:34 +0000 (21:22 +0000)]
Need using namespace boost in thrift threads test
Reviewed By: jake luciani
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665119
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 16 May 2007 02:45:16 +0000 (02:45 +0000)]
Add Jake Luciani to contributors list
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665118
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 16 May 2007 02:44:21 +0000 (02:44 +0000)]
Fix Thrift perl framedtransport
Reviewed By: jake luciani
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665117
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 16 May 2007 02:40:12 +0000 (02:40 +0000)]
Perl tutorial code
Summary: Jake Luciani
Reviewed By: mcslee
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665116
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 16 May 2007 02:35:58 +0000 (02:35 +0000)]
Adding perl testclient code
Summary: Submitted by Jake Luciani
Reviewed By: mcslee
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665115
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 16 May 2007 02:31:53 +0000 (02:31 +0000)]
Some filetransport indentation and style fixes
Reviewed By: null, no code change, style only
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665114
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 16 May 2007 02:29:53 +0000 (02:29 +0000)]
Apply thrift license to all files in compiler
Summary: Forgot to do this last time around, only got the libs
Reviewed By: no code in here, just comments
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665113
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 16 May 2007 02:21:06 +0000 (02:21 +0000)]
Perl library for Thrift
Summary: Submitted by Jake Luciani
Reviewed By: mcslee
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665112
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 16 May 2007 02:18:07 +0000 (02:18 +0000)]
Perl generator for Thrift compiler
Summary: Submitted by Jake Luciani
Reviewed By: mcslee
Test Plan: Who likes perl? Not me. Test files to be checked in soon.
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665111
13f79535-47bb-0310-9956-
ffa450edef68
Martin Kraemer [Tue, 15 May 2007 23:24:30 +0000 (23:24 +0000)]
Thrift Syntax for Vim
Summary:
See header of file for installation instructions. I'm not a vim master so this may not
be completely kosher, feel free to improve as necessary.
Reviewed By: Slee
Test Plan:
Revert Plan:
Notes:
EImportant:
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665110
13f79535-47bb-0310-9956-
ffa450edef68
boz [Mon, 14 May 2007 23:04:33 +0000 (23:04 +0000)]
THRIFT: configurable retry settings for bind
Summary: SO_REUSEADDR doesn't always work, and some of my servers have
expensive init routines that I really want to run before it becomes available
to services, so I want thrift to retry the bind several times at varied
intervals before giving up
Reviewed By: slee
Test Plan: running a service in GDB with no problems binding, with another
service bound to the port for all the retries, another service bound to the
port for only some of the retries
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665109
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Fri, 11 May 2007 23:46:42 +0000 (23:46 +0000)]
Haiping made an emacs .el file for Thrift
Summary: Now that is just awesome.
Reviewed By: haiping
Test Plan: Use it or lose it.
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665108
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Fri, 11 May 2007 17:58:54 +0000 (17:58 +0000)]
Fix messed up exception error printing
Reviewed By: boz
Test Plan: comes up in feed
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665107
13f79535-47bb-0310-9956-
ffa450edef68
jsobel [Tue, 8 May 2007 17:51:49 +0000 (17:51 +0000)]
thrift: cpp tsocketpool support
summary: simple port of tsocketpool from php to cpp. missing a lot of functionality due to lack of apc support
review: slee
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665106
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Mon, 7 May 2007 22:54:18 +0000 (22:54 +0000)]
TEOFException must publicly inherit TTransportException
Reviewed By: boz
Test Plan: Queuemap
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665105
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Fri, 4 May 2007 18:49:56 +0000 (18:49 +0000)]
Java test client/server fixes
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665104
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 3 May 2007 01:30:18 +0000 (01:30 +0000)]
Make sure isset fields of java generated objects is public
Reviewed By: rob mccool from yahoo
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665103
13f79535-47bb-0310-9956-
ffa450edef68
peter [Tue, 1 May 2007 04:03:22 +0000 (04:03 +0000)]
fixing a typo
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665102
13f79535-47bb-0310-9956-
ffa450edef68
James Wang [Tue, 17 Apr 2007 22:38:58 +0000 (22:38 +0000)]
Thrift: Fixing memory leak issue with memory buffer used in TPipedTransport
Reviewed by: boz
Test Plan: tested with falcon action_listener using PeekProcessor
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665101
13f79535-47bb-0310-9956-
ffa450edef68
James Wang [Fri, 13 Apr 2007 20:10:39 +0000 (20:10 +0000)]
Thrift: Modifications to PeekProcessor to be able to support nested PeekProcessors
Reviewed by: boz
Test Plan: Tested with Falcon
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665100
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Fri, 13 Apr 2007 01:57:12 +0000 (01:57 +0000)]
Add explicit binary type to Thrift
Summary: Identical to string in all languages except Java. Java String is NOT binary-safe, so we need to use raw byte[] in that case. PHP/RUBY/Python strings are all binary safe, and C++ std::string works fine and manages memory for you so it's the safest route. Java just needs this tweak.
Reviewed By: aditya
Test Plan: Use "binary" as a type instead of String.
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665099
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Fri, 13 Apr 2007 00:33:24 +0000 (00:33 +0000)]
Crazy byteswapping thrift patches from david reiss
Reviewed By: ninjitsu
Test Plan: bswap64, holla holla
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665098
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 11 Apr 2007 09:16:23 +0000 (09:16 +0000)]
sprintf fix on C++ tutorial server
Reviewed By: danli
Test Plan: hello
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665097
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 11 Apr 2007 08:57:07 +0000 (08:57 +0000)]
Fix messed up noninitialized things
Reviewed By: danli
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665096
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Wed, 11 Apr 2007 00:13:09 +0000 (00:13 +0000)]
-- trying to make TFileTransport destructor quicker
Summary:
- setFlushMaxTimeUs to a lower value before trying to close the file
Reviewed By: jwang
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665095
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Tue, 10 Apr 2007 23:15:04 +0000 (23:15 +0000)]
-- fix issues with TFileTransport
Summary:
- Make sure that buffers are always emptied when destructor is called (or when file is closed)
- make flush a no-op if file is not open
- dont allow new events to be enqueued if the file is in the process of being closed
Reviewed By: slee, jwang
Test Plan: tested with building search indices on top of thrift logs
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665094
13f79535-47bb-0310-9956-
ffa450edef68
James Wang [Tue, 10 Apr 2007 17:29:06 +0000 (17:29 +0000)]
Thrift: Checking in readonly option for TFileTransport
Reviewed by: boz
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665093
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Tue, 10 Apr 2007 06:44:53 +0000 (06:44 +0000)]
Yeeeeeeeeahhh
Summary: Missing that $ in the vairable
Reviewed By: php
Test Plan: you need that!
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665092
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Tue, 10 Apr 2007 06:15:25 +0000 (06:15 +0000)]
In php generate array of enum values to string names
Summary: for peter k
Reviewed By: peter
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665091
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Tue, 10 Apr 2007 02:30:30 +0000 (02:30 +0000)]
Forgot to add Java tutorials to thrift
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665090
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Thu, 5 Apr 2007 01:20:45 +0000 (01:20 +0000)]
-- check in updated pdf
Reviewed By: slee
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665089
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Thu, 5 Apr 2007 01:17:52 +0000 (01:17 +0000)]
- fix typo in thrift whitepaper
Summary:
clases -> classes
Reviewed By: scott m
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665088
13f79535-47bb-0310-9956-
ffa450edef68
dweatherford [Thu, 5 Apr 2007 00:20:40 +0000 (00:20 +0000)]
[thrift] Build fix for TFileTransport
Summary: Not including config.h means we never get the HAVE_CLOCK_GETTIME #define, breaking the build with a duplicate function definition on machines that have a clock_gettime() function in the standard library.
Reviewed By: slee
Test Plan: it compiles, ship it
Revert: ok
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665087
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 4 Apr 2007 22:13:37 +0000 (22:13 +0000)]
Oops typo.
Reviewed By: mcslee
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665086
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 4 Apr 2007 22:11:17 +0000 (22:11 +0000)]
Build fixes and clock_get_time copy from paul querna
Reviewed By: mcslee
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665085
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 4 Apr 2007 21:08:21 +0000 (21:08 +0000)]
Thrift string copy construction pathces from kevin ko
Summary: Remove unnecessary string copy constructions in C++ code
Reviewed By: mcslee
Test Plan: build
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665084
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 4 Apr 2007 19:56:41 +0000 (19:56 +0000)]
Two more thrift paper typos
Summary: libthread => libpthread and texttt{HashMap} missing slash
Reviewed By: david reiss
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665083
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Tue, 3 Apr 2007 19:47:04 +0000 (19:47 +0000)]
Fixing typos in the Thrift whitepaper
Reviewed By: eugene, yishan
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665082
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Tue, 3 Apr 2007 07:31:51 +0000 (07:31 +0000)]
Fix build script reference problem
Reviewed By: pquerna@apache.org
Test Plan: build w/o libevent installed
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665081
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Tue, 3 Apr 2007 05:49:12 +0000 (05:49 +0000)]
Fix whitepaper typo
Reviewed By: ditka
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665080
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Tue, 3 Apr 2007 03:16:11 +0000 (03:16 +0000)]
PHP new build fix for TBinaryProtocol
Reviewed By: shire
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665079
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Tue, 3 Apr 2007 00:34:00 +0000 (00:34 +0000)]
Remove extra TApplicationException:: in Thrift.h
Summary: G++ 4.1.1 compatibility
Reviewed By: alex tribble
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665078
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Sun, 1 Apr 2007 23:14:38 +0000 (23:14 +0000)]
Updated Thrift whitepaper with minor formatting cleanup
Reviewed By: marc, aditya
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665077
13f79535-47bb-0310-9956-
ffa450edef68
Marc Slemko [Sun, 1 Apr 2007 20:17:02 +0000 (20:17 +0000)]
Removed comment about needing a lock in thread main. Access through boost::shared_ptr is thread safe
Reviewed By: none
Test Plan: N.A.
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665076
13f79535-47bb-0310-9956-
ffa450edef68
Marc Slemko [Sun, 1 Apr 2007 09:14:05 +0000 (09:14 +0000)]
Added thread library documentation to thrift whitepaper
Reviewed By: To be reviewed by slee and aditya
Test Plan: N.A.
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665075
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Sun, 1 Apr 2007 01:19:57 +0000 (01:19 +0000)]
-- more assert fixes for thrift concurrency
Reviewed By: mcslee
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665074
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Sat, 31 Mar 2007 17:45:12 +0000 (17:45 +0000)]
-- assert fixes for thrift concurrency lib
Summary:
- cannot assume that assert.h is defined
Reviewed By: marc k
Test Plan: everything compiles
Notes:
- need to reflect these changes in libfacebook/fbthread
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665073
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Sat, 31 Mar 2007 16:56:14 +0000 (16:56 +0000)]
-- added a facebook services section to the thrift paper
Reviewed By: slee
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665072
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Sat, 31 Mar 2007 09:18:29 +0000 (09:18 +0000)]
-- checking in pdf copy of thrift paper into doc directory
Reviewed By: tbr-mcslee
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665071
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Sat, 31 Mar 2007 08:28:06 +0000 (08:28 +0000)]
-- additions/fixes to thrift paper
Summary:
- fixed some typos and added a subsection on TFileTransport
Reviewed By: tbr-mcslee
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665070
13f79535-47bb-0310-9956-
ffa450edef68
Martin Kraemer [Fri, 30 Mar 2007 18:41:48 +0000 (18:41 +0000)]
Thrift - remove client disconnect error
Summary:
It's fairly obnoxious.
Reviewed By: Slee and Karl
Test Plan:
Revert Plan: revertible
Notes:
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665069
13f79535-47bb-0310-9956-
ffa450edef68
James Wang [Wed, 28 Mar 2007 22:43:57 +0000 (22:43 +0000)]
Thrift: Making TProcessor::process(io) non-virtual again, since my last change which made it virtual caused compiling errors of functions being hidden, ugh
Reviewed by: Karl
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665068
13f79535-47bb-0310-9956-
ffa450edef68
James Wang [Wed, 28 Mar 2007 00:47:09 +0000 (00:47 +0000)]
Thrift: PeekProcessor - moving PeekEnd call after PeekBuffer
Reviewed by: boz
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665067
13f79535-47bb-0310-9956-
ffa450edef68
James Wang [Tue, 27 Mar 2007 23:17:34 +0000 (23:17 +0000)]
Thrift: Adding StatsProcessor, PeekProcessor, TPipedFileReaderTransport, and TPipedFileReaderTransportFactory classes
- StatsProcessor can be used to print events, or keep track of event frequency
- PeekProcessor is used to examine data in a thrift event, prior to passing it along to an underlying processor
- TPipedFileReaderTransport and its factory are used to pipe a TFileReaderTransport (which TFileProcessor requires)
Also fixed some bugs in TFileTransport - next flush time was overflowing and not always being reset
Reviewed by: aditya, mcslee
Test Plan: Tested using various thrift clients (scribe, falcon) and gdb in sandbox and on dev008.
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665066
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 22 Mar 2007 02:35:33 +0000 (02:35 +0000)]
Fix heinous TMemoryBuffer bug and warning in FileTransport
Reviewed By: dweatherford
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665065
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 21 Mar 2007 06:53:03 +0000 (06:53 +0000)]
Missed an include line in sample code
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665064
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 21 Mar 2007 06:50:52 +0000 (06:50 +0000)]
Readme on PHP/Apache Thrift integration
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665063
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 21 Mar 2007 01:24:00 +0000 (01:24 +0000)]
Thrift whitepaper draft
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665062
13f79535-47bb-0310-9956-
ffa450edef68
Martin Kraemer [Fri, 16 Mar 2007 02:03:32 +0000 (02:03 +0000)]
Thrift: fix error with handling TApplicationException
Summary:
The php recv functions for method invocations didn't pass a proper input object into the handler for reading an application exception. This caused graceful thrift failures to not work gracefully in PHP.
Reviewed By: Slee
Test Plan: Tested by invoking from a thrift client a function not defined on a thrift server. Should response with Invalid method name
Revert Plan: revertible
Notes:
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665061
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 14 Mar 2007 09:08:38 +0000 (09:08 +0000)]
Constants lowercase in java true/false
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665060
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 14 Mar 2007 03:07:00 +0000 (03:07 +0000)]
Generate toString() convenience method for Thrift java structs
Reviewed By: biren
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665059
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 14 Mar 2007 02:47:35 +0000 (02:47 +0000)]
Various Thrift fixes, including Application Exception support in Ruby, better errror messages across languages, etc.
Reviewed By: thrift
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665058
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Fri, 9 Mar 2007 19:26:57 +0000 (19:26 +0000)]
Fix broken C++ Thrift test
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665057
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Fri, 9 Mar 2007 19:26:29 +0000 (19:26 +0000)]
Fix TServerSocket accept() to not do 200ms polling
Summary: Better to signal to unix file in select
Reviewed By: marc
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665056
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Thu, 8 Mar 2007 03:10:29 +0000 (03:10 +0000)]
-- Fix compiler warnings
Summary:
- These showed up when I was compiling on my local machine (cygwin!!)
Reviewed By: thrifty
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665055
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 8 Mar 2007 01:22:46 +0000 (01:22 +0000)]
Fix cleanup and bootstrap
Summary: spaces in directory names should work
Reviewed By: aditya
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665054
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 7 Mar 2007 05:46:50 +0000 (05:46 +0000)]
Ruby code gen fixes and some README improvements
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665053
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 7 Mar 2007 05:46:05 +0000 (05:46 +0000)]
No such thing as e.message in python socket error?
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665052
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 7 Mar 2007 05:45:10 +0000 (05:45 +0000)]
Thrift Tutorial
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665051
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 7 Mar 2007 05:17:25 +0000 (05:17 +0000)]
Some thrift test code improvements
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665050
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 7 Mar 2007 05:16:16 +0000 (05:16 +0000)]
Implement proper TThreadedServer shutdown
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665049
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Tue, 6 Mar 2007 00:06:27 +0000 (00:06 +0000)]
READMEs and DOCs and ant tasks, oh my
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665048
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Mon, 5 Mar 2007 22:55:59 +0000 (22:55 +0000)]
Get rid of all the using namespace and using boost:: declarations in Thrift header files
Summary: To remove upstream dependencies. Still keeping some specific using directives around.
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665047
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Mon, 5 Mar 2007 22:18:18 +0000 (22:18 +0000)]
Thrift build cleanup stuff
Summary: Get rid of autoconf stuff for lib/php, it doesn't do anything
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665046
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Mon, 5 Mar 2007 20:09:37 +0000 (20:09 +0000)]
Thrift CPP threading fixes
Reviewed By: karl
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665045
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Mon, 5 Mar 2007 05:45:51 +0000 (05:45 +0000)]
Move helper structure declarations into .h file
Reviewed By: aditya
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665044
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Mon, 5 Mar 2007 05:41:04 +0000 (05:41 +0000)]
Threads test makefile cleanup
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665043
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Mon, 5 Mar 2007 05:40:37 +0000 (05:40 +0000)]
Threads testing package update
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665042
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Mon, 5 Mar 2007 04:48:48 +0000 (04:48 +0000)]
Threading libraries test for Thrift C++
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665041
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Fri, 2 Mar 2007 21:23:30 +0000 (21:23 +0000)]
Do not check error code if select returns 0
Summary: They don't seem to be guaranteed on our system, 0 just means timeout
Reviewed By: karl
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665040
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Fri, 2 Mar 2007 19:41:08 +0000 (19:41 +0000)]
Server robustness fixes in Thrift C++ libs
Summary: ServerSockets can be interrupt() ed
Reviewed By: marc, karl
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665039
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 1 Mar 2007 22:05:46 +0000 (22:05 +0000)]
Proper shutdown functionality for Thrift servers
Reviewed By: karl
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665038
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 1 Mar 2007 02:45:10 +0000 (02:45 +0000)]
Add join to the ThreadManager
Summary: Now you can join against all the threads in a ThreadManager
Reviewed By: marc, xp-style
Test Plan: Use with new ThriftServer shutdown mechanisms
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665037
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 1 Mar 2007 00:37:56 +0000 (00:37 +0000)]
Giving Marc K props for crazy bitshifting in PHP binary protocol
Reviewed By: marc
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665036
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 1 Mar 2007 00:35:54 +0000 (00:35 +0000)]
Oops missed license on one python file
Reviewed By: mcslee
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665035
13f79535-47bb-0310-9956-
ffa450edef68