Supwisdom Source - common/thrift.git/log

Code Review / common / thrift.git / log

summary | shortlog | log | commit | commitdiff | review | tree
first ⋅ prev ⋅ next

commit | commitdiff | tree

David Reiss [Wed, 18 Mar 2009 23:59:56 +0000 (23:59 +0000)]

THRIFT-373. Update lists of files to include in release tarballs

This is mostly EXTRA_DIST, but also includes some headers.
I had to drill down into test because "make dist" builds some
of the test code. .gitignore is not included in the tarballs.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@755791 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Wed, 18 Mar 2009 23:14:13 +0000 (23:14 +0000)]

THRIFT-362. python: Detect endianness on Solaris

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@755776 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Wed, 18 Mar 2009 03:14:56 +0000 (03:14 +0000)]

THRIFT-379. java: Print enum value names

This patch adds a new generated map of enum values to their respective names to each generated enum class, and then consumes that in the toString method to print the names when possible.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@755464 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Wed, 18 Mar 2009 02:47:02 +0000 (02:47 +0000)]

THRIFT-367. java: Some dead code in TNonblockingSocket.java

All the blocks of commented code are removed.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@755463 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Wed, 18 Mar 2009 02:40:54 +0000 (02:40 +0000)]

THRIFT-277. rb: Abstract Transport in Ruby #read method should throw NotImplementedException

The name says it all.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@755460 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Wed, 18 Mar 2009 01:50:50 +0000 (01:50 +0000)]

THRIFT-278. java: #validate exceptions should contain the offending value

This patch causes validate to throw exceptions that contain the bad field value as well as the field name. I had to modify it slightly from the patch on the issue to conform with the new style isset checks.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@755454 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 17 Mar 2009 21:55:36 +0000 (21:55 +0000)]

THRIFT-365. html: HTML compiler infinite loop

Trivial fix for 64-bit systems.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@755413 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Sat, 14 Mar 2009 23:35:16 +0000 (23:35 +0000)]

THRIFT-351. cpp: Allow a custom ThreadFactory in TThreadedServer

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@754551 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Sat, 14 Mar 2009 07:37:28 +0000 (07:37 +0000)]

Make .thrift files non-executable since we removed the shebangs

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@753610 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Fri, 13 Mar 2009 21:25:31 +0000 (21:25 +0000)]

Fix a test in ax_lib_zlib

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@753429 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Fri, 13 Mar 2009 21:25:29 +0000 (21:25 +0000)]

THRIFT-300. A reimplementation of ax_java

Completely replace ax_java.m4 with ax_javac_and_java, which is
a clean-room implementation of an autoconf macro to detect Java.
It has some limitations compared to the ax_java macros in
The Autoconf Macro archive, but it has two key advantages.
It is not GPL-licensed. It doesn't abort configure if Java is
not found.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@753428 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Fri, 13 Mar 2009 18:28:40 +0000 (18:28 +0000)]

THRIFT-368. java: setFieldValue should allow nulls for all field types

After this patch, setFieldValue will treat a set with a null as an unset.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@753337 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Fri, 13 Mar 2009 00:28:06 +0000 (00:28 +0000)]

THRIFT-366. java: Lots of little warnings in java library

This cleans up imports, adds generic arguments where necessary, and puts OverloadNonblockingServer into the right package.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@753072 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Wed, 11 Mar 2009 23:40:57 +0000 (23:40 +0000)]

THRIFT-364. java: Use of enums in other namespaces breaks java generated code

This patch checks for different namespaces and prefixes appropriately.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@752696 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Sat, 7 Mar 2009 03:08:37 +0000 (03:08 +0000)]

THRIFT-359. java: nocamel style breaks generated services

This patch makes the generated code respect the nocamel option.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@751180 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Kevin Clark [Sat, 7 Mar 2009 00:03:15 +0000 (00:03 +0000)]

THRIFT-229. rb: Don't block indefinitely on connect()

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@751142 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Thu, 5 Mar 2009 23:11:37 +0000 (23:11 +0000)]

THRIFT-358. ruby: Change how external thrift files' generated code is required

Generated code that relies on included thrift files now doesn't assume the path will be the same.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@750667 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Kevin Clark [Thu, 5 Mar 2009 21:05:37 +0000 (21:05 +0000)]

THRIFT-96. cpp: TSocket.peek fails on FreeBSD

Author: Alexander Shigin

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@750585 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Kevin Clark [Wed, 4 Mar 2009 22:06:59 +0000 (22:06 +0000)]

Remove now defunct tests (they've been moved to specs in lib/rb)

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@750188 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Kevin Clark [Wed, 4 Mar 2009 21:42:46 +0000 (21:42 +0000)]

THRIFT-352. rb: Implicit enums should be valid values

Author: Gary Tsang

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@750171 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Kevin Clark [Wed, 4 Mar 2009 21:32:54 +0000 (21:32 +0000)]

THRIFT-353. rb: Capitalize module names on ruby generation

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@750160 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Kevin Clark [Wed, 4 Mar 2009 21:10:58 +0000 (21:10 +0000)]

THRIFT-265. cpp: Reset buffers every 512 calls in TNonblockingServer

Author: Erik Frey

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@750153 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Kevin Clark [Tue, 3 Mar 2009 22:13:46 +0000 (22:13 +0000)]

THRIFT-148. py: One more time, reapply the most *recent* patch

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@749795 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Kevin Clark [Tue, 3 Mar 2009 22:03:57 +0000 (22:03 +0000)]

THRIFT-148. py: Add un-commited file missing from 749510

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@749786 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Kevin Clark [Tue, 3 Mar 2009 02:25:50 +0000 (02:25 +0000)]

THRIFT-148. py: Add support for Twisted

Author: Esteve Fernandez

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@749510 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

T Jake Luciani [Mon, 2 Mar 2009 23:47:20 +0000 (23:47 +0000)]

THRIFT-324: replace strlen with length

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@749478 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Kevin Clark [Mon, 2 Mar 2009 23:29:54 +0000 (23:29 +0000)]

Perl library should honor the INSTALLDIRS variable

Author: Esteve Fernandez

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@749472 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Wed, 25 Feb 2009 00:59:55 +0000 (00:59 +0000)]

THRIFT-348. cpp: Fix readBool for vectors of bools (again)

This bug only affected the returned number bytes read
(which is not currently used), not the actual bool value.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@747635 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Mon, 23 Feb 2009 17:49:24 +0000 (17:49 +0000)]

THRIFT-116. java: Isset fields for non-primitive types unnecessary

Prior commit on this issue was missing a !.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@747090 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Sat, 21 Feb 2009 01:57:46 +0000 (01:57 +0000)]

THRIFT-116. java: Isset fields for non-primitive types unnecessary

Missed one of the cases where isset was being used on non-primitive fields.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@746429 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Thu, 19 Feb 2009 21:21:44 +0000 (21:21 +0000)]

THRIFT-116. java: Isset fields for non-primitive types unnecessary

This patch gets rid of the __isset fields for non-primitives and updates ToStringTest and EqualityTest appropriately.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@746000 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Tue, 17 Feb 2009 20:28:46 +0000 (20:28 +0000)]

THRIFT-325. Remove a bunch of uses of the old command line format

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745242 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Tue, 17 Feb 2009 20:28:37 +0000 (20:28 +0000)]

Make the PHP generator use non-hardcoded namespaces.

- Make the PHP generator use program->get_namespace("php")
instead of program->get_php_namespace()
- Eliminate the explicit "php_namespace" in t_program.
- Deprecate the php_namespace token.
- Update example .thrift files and syntax files.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745241 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Tue, 17 Feb 2009 20:28:30 +0000 (20:28 +0000)]

Allow the Thrift compiler to be built without the PHP generator.

- Use AX_THRIFT_GEN to make configure support --disable-gen-php
- Update the compiler Makefile.am to exclude the generator.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745240 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Tue, 17 Feb 2009 20:28:28 +0000 (20:28 +0000)]

Remove t_php_generator.h.

t_php_generator.h is no longer included anywhere, because
the PHP generator uses the new dynamic generator framework.
Therefore, we can collapse the class definition into the .cc file.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745239 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Tue, 17 Feb 2009 20:28:24 +0000 (20:28 +0000)]

Make the PHP generator dynamic.

- Modify the PHP generator constructor to fit the new generic interface.
- Register the PHP genrator with the central registry.
- Deprecate the old way of invoking the PHP generator.
- main.cc no longer includes t_php_generator.h.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745238 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Tue, 17 Feb 2009 20:28:19 +0000 (20:28 +0000)]

Make the XSD generator use non-hardcoded namespaces.

- Make the XSD generator use program->get_namespace("xsd")
instead of program->get_xsd_namespace()
- Eliminate the explicit "xsd_namespace" in t_program.
- Deprecate the xsd_namespace token.
- Update example .thrift files and syntax files.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745237 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Tue, 17 Feb 2009 20:28:13 +0000 (20:28 +0000)]

Allow the Thrift compiler to be built without the XSD generator.

- Use AX_THRIFT_GEN to make configure support --disable-gen-xsd
- Update the compiler Makefile.am to exclude the generator.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745236 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Tue, 17 Feb 2009 20:28:10 +0000 (20:28 +0000)]

Remove t_xsd_generator.h.

t_xsd_generator.h is no longer included anywhere, because
the XSD generator uses the new dynamic generator framework.
Therefore, we can collapse the class definition into the .cc file.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745235 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Tue, 17 Feb 2009 20:28:06 +0000 (20:28 +0000)]

Make the XSD generator dynamic.

- Modify the XSD generator constructor to fit the new generic interface.
- Register the XSD genrator with the central registry.
- Deprecate the old way of invoking the XSD generator.
- main.cc no longer includes t_xsd_generator.h.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745234 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Tue, 17 Feb 2009 20:28:01 +0000 (20:28 +0000)]

Allow the Thrift compiler to be built without the Erlang generator.

- Use AX_THRIFT_GEN to make configure support --disable-gen-erl
- Update the compiler Makefile.am to exclude the generator.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745233 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Tue, 17 Feb 2009 20:27:58 +0000 (20:27 +0000)]

Remove t_erl_generator.h.

t_erl_generator.h is no longer included anywhere, because
the Erlang generator uses the new dynamic generator framework.
Therefore, we can collapse the class definition into the .cc file.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745232 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Tue, 17 Feb 2009 20:27:54 +0000 (20:27 +0000)]

Make the Erlang generator dynamic.

- Modify the Erlang generator constructor to fit the new generic interface.
- Register the Erlang genrator with the central registry.
- Deprecate the old way of invoking the Erlang generator.
- main.cc no longer includes t_erl_generator.h.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745231 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Tue, 17 Feb 2009 20:27:48 +0000 (20:27 +0000)]

THRIFT-325. Include t_generator.h in main.cc

I'm about to remove all of the generator includes, but we'll still need
the generic header for the generator registry and interface.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745230 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Tue, 17 Feb 2009 20:06:08 +0000 (20:06 +0000)]

THRIFT-340. python: Detect endianness properly on FreeBSD

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745223 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Fri, 13 Feb 2009 03:09:52 +0000 (03:09 +0000)]

THRIFT-309. Make Thrift's C# mapping .NET 2.0 (Mono 1.2.4) compatible

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@743963 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Wed, 11 Feb 2009 01:11:54 +0000 (01:11 +0000)]

THRIFT-199. perl: Let "make distclean" work when we are not using Perl

When configure is run with --without-perl, lib/perl/Makefile.am cannot
generate Makefile-perl.mk. However, "make distclean" still runs, so
the clean-local target fails. This version just silently does nothing
when Perl is not being used.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@743190 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Tue, 10 Feb 2009 21:38:48 +0000 (21:38 +0000)]

cpp: Fix implementations of "list<bool>"

TProtocol::readBool expects a "bool&" as its argument, but "list<bool>"
is implemented as "vector<bool>", which is a specialization of vector
that uses a custom structure as its reference type. Therefore, we need
to overload TProtocol::readBool for std::vector<bool>::reference.
This function is provided as a non-virtual for efficiency since it is
highly unlikely that any subclass will want to override it.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@743112 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Tue, 10 Feb 2009 21:38:44 +0000 (21:38 +0000)]

cpp: Fix "make check" by defining a comparator for "Empty"

The TCompactProtocol revision added a "set<Empty>" in DebugProtoTest.
C++ needs a comparator in order to link this.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@743111 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 10 Feb 2009 18:36:56 +0000 (18:36 +0000)]

THRIFT-316. java: @Override isn't generated for hashCode() without the hash code builder

Fixed with a trivial reorganization of the hashCode method generation.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@743046 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 10 Feb 2009 18:10:57 +0000 (18:10 +0000)]

THRIFT-318. java: Performance of HashSet for enumeration VALID_VALUES seems poor

Instead of a HashSet, enums will now use the special IntRangeSet implementation.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@743037 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 10 Feb 2009 04:49:39 +0000 (04:49 +0000)]

THRIFT-110. java: A more compact format

This patch includes the Java implementation of the new Compact Protocol outlined in the issue and a matching test. It also creates Fixtures.java, a helper class that contains some useful test structure instances.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@742847 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Sun, 8 Feb 2009 22:46:38 +0000 (22:46 +0000)]

java: Fix a minor formatting problem in the gen-code

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@742192 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Sun, 8 Feb 2009 00:12:38 +0000 (00:12 +0000)]

THRIFT-10. java: Descriptors used during serialization should be immutable objects

-Descriptor classes all have final members, making them immutable.
-Generated structs now have static constant versions of their TStruct and TField descriptors, and will be used during writing.
-Protocols that can benefit use static constants for various common returned descriptors.
-A duplicate FieldMetaData.java that should have been removed previously was also removed.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@741984 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Sat, 7 Feb 2009 20:06:09 +0000 (20:06 +0000)]

THRIFT-321. java: THRIFT-303 broke EqualityTest
Regenerated test code.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@741952 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Sat, 7 Feb 2009 17:17:43 +0000 (17:17 +0000)]

THRIFT-159. csharp: Compiler doesn't add package scope to exceptions in catch blocks and assigns to unused local var when reading

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@741917 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Sat, 7 Feb 2009 02:37:09 +0000 (02:37 +0000)]

THRIFT-256. python: Fix inheritance of services in the same IDL file

The old version of type_name did not fully qualify parent service names
when they were defined in the same IDL file, but it is necessary because
they end up in different Python files.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@741833 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Sat, 7 Feb 2009 02:37:05 +0000 (02:37 +0000)]

THRIFT-310. python: Generate valid code for empty services

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@741832 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Sat, 7 Feb 2009 02:37:00 +0000 (02:37 +0000)]

THRIFT-292. Install fb303.thrift in a more sensible location

thrift_home is the Thrift installation we are using.
We shouldn't be trying to install back into it.
Use $(prefix) instead.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@741831 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Sat, 7 Feb 2009 02:36:57 +0000 (02:36 +0000)]

THRIFT-292. Auto-generate the Python gen-code in build.xml

r739384 deleted the generated Python code from the source tree.
With this change, it will be automatically generated when make is run.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@741830 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Sat, 7 Feb 2009 02:36:54 +0000 (02:36 +0000)]

THRIFT-292. Auto-generate the Java gen-code in build.xml

r739384 deleted the generated Java code from the source tree.
With this change, it will be automatically generated when ant is run.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@741829 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Sat, 7 Feb 2009 02:36:52 +0000 (02:36 +0000)]

THRIFT-292. Delete aclocal.m4, a generated file

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@741828 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Sat, 7 Feb 2009 02:36:50 +0000 (02:36 +0000)]

THRIFT-292. s/facebook::thrift/apache::thrift/ in contrib/fb303/cpp

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@741827 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Sat, 7 Feb 2009 02:36:46 +0000 (02:36 +0000)]

THRIFT-292. Make the #includes in fb303 match the rest of Thrift

Specifically, by removing the "thrift/" prefix.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@741826 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Sat, 7 Feb 2009 02:36:43 +0000 (02:36 +0000)]

THRIFT-292. Restore fb303/FacebookBase.py

This file was deleted in r739384, but is is not generated code.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@741825 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Sat, 7 Feb 2009 02:36:35 +0000 (02:36 +0000)]

THRIFT-314. Purge reflection.limited

This was a feature designed to allow a Thrift server to report
information about its interface. However, the feature has
significant design problems, and is presence is currently causing
confusion without doing any good. Therefore, it is being removed.
It will always be in source control if and when we are ready to
come back to it.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@741824 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Sat, 7 Feb 2009 01:08:58 +0000 (01:08 +0000)]

THRIFT-303. java: Changes to __isset interface

This patch makes __isset always private and adds a method per field to set the __isset state when not using the bean-style generator.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@741805 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Thu, 5 Feb 2009 00:24:42 +0000 (00:24 +0000)]

java: Added SerializationBenchmark.java, helper class for performing tests on protocols.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@740952 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Kevin Clark [Wed, 4 Feb 2009 22:43:59 +0000 (22:43 +0000)]

THRIFT-254. rb: Add optional strict version support to binary protocols

Author: Michael Stockton

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@740930 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Tue, 3 Feb 2009 22:16:46 +0000 (22:16 +0000)]

THRIFT-258. csharp: Include all lib source files in Makefile.am

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@740485 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Tue, 3 Feb 2009 21:20:55 +0000 (21:20 +0000)]

THRIFT-264. csharp: Include TBufferedTransport in the build on Linux

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@740456 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Tue, 3 Feb 2009 21:20:27 +0000 (21:20 +0000)]

THRIFT-264. csharp: Use /langversion:linq to fix the Linux build

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@740454 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 3 Feb 2009 19:18:57 +0000 (19:18 +0000)]

THRIFT-132. ruby: Ruby generator should use ::Thrift::Foo namespace form

All of the Thrift library includes now prefix with ::.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@740377 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 3 Feb 2009 18:16:54 +0000 (18:16 +0000)]

THRIFT-302. ruby: Native extension fails to build

A piece of code needed for compilation on Linux was missing; this patch replaces it. Also, there were some compiler warnings and declarations that were missing that are now fixed.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@740366 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 3 Feb 2009 00:49:25 +0000 (00:49 +0000)]

THRIFT-297. java: getFieldValue and setFieldValue should be abstract TBase methods

This patch makes getFieldValue, setFieldValue, and isSet TBase interface methods, and adds all the previously beans-only getters and setters to all Java generated classes.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@740169 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 3 Feb 2009 00:31:55 +0000 (00:31 +0000)]

THRIFT-298. ruby: Exception propagation seems broken for Ruby clients

This patch fixes the problem. How is anyone's guess, but we'll simplify all this code in the future.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@740161 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Mon, 2 Feb 2009 00:48:17 +0000 (00:48 +0000)]

THRIFT-248. ruby: Factor BinaryProtocolAccelerated into separate protocol and struct components

This patch replaces the "binaryprotocolaccelerated" c extension with the "thrift_native" c extension. This new extension creates native implementations for the struct.rb #write and #read methods, Thrift::BinaryProtocol, and Thrift::MemoryBuffer, but keeps ruby-level interfaces, allowing all protocols to benefit from the struct code and the memory buffer. There is however an additional cost associated with going through this ruby layer, but the increased interoperability seems to be well worth it.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@739895 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Sun, 1 Feb 2009 16:56:29 +0000 (16:56 +0000)]

THRIFT-178. java, csharp, cpp: Final Keyword

The lexer has been changed to make "final" a non-reserved word, and the java, csharp, and cpp compilers now look for the final annotation and amend their class declarations appropriately.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@739788 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Sun, 1 Feb 2009 06:21:13 +0000 (06:21 +0000)]

THRIFT-299. doc: binary type isn't documented nor demonstrated in the tutorial

The existence of the "binary" type is now documented in the relevant places.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@739702 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Sun, 1 Feb 2009 06:08:35 +0000 (06:08 +0000)]

add a lot of things to svn:ignore. there are many autogenerated build products that are best ignored, and this gets all of them, I think.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@739701 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Sun, 1 Feb 2009 05:36:10 +0000 (05:36 +0000)]

THRIFT-259. html: Generate "extends" link for extended services

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@739700 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

T Jake Luciani [Sun, 1 Feb 2009 04:47:30 +0000 (04:47 +0000)]

THRIFT-199: integrate perl into automake

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@739697 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Sun, 1 Feb 2009 00:42:10 +0000 (00:42 +0000)]

THRIFT-285. python: Don't generate _result structs for async functions

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@739668 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

T Jake Luciani [Sat, 31 Jan 2009 22:36:20 +0000 (22:36 +0000)]

THRIFT-270: change cpp namespaces from facebook::thrift to apache::thrift

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@739644 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Sat, 31 Jan 2009 22:12:34 +0000 (22:12 +0000)]

THRIFT-209. csharp: Make TTransportFactory.GetTransport virtual

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@739641 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Sat, 31 Jan 2009 21:59:32 +0000 (21:59 +0000)]

THRIFT-195. python: Add a simple THttpServer

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@739638 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Sat, 31 Jan 2009 21:59:27 +0000 (21:59 +0000)]

python: Add TFileObjectTransport

TFileObjectTransport is a Thrift transport that wraps a
Python-style file-like object. This is necessary to add
methods like isOpen and readAll.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@739637 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Sat, 31 Jan 2009 21:39:25 +0000 (21:39 +0000)]

THRIFT-212. python: Make TFramedTransport implement CReadableTransport

This involved adding a few methods to provide lower-level access to the
internal read buffer. This will allow us to use TBinaryProtocolAccelerated
with TFramedTransport.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@739632 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Sat, 31 Jan 2009 21:39:20 +0000 (21:39 +0000)]

python: Make TFramedTransport use a cStringIO for reading

Tested by running a client against a framed-transport server.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@739631 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Sat, 31 Jan 2009 21:39:16 +0000 (21:39 +0000)]

python: Eliminate the option of TFramedTransport to not frame

We've done this in a few other languages. All the tests still pass.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@739630 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Sat, 31 Jan 2009 21:39:11 +0000 (21:39 +0000)]

cpp: Make the test server compatible with the Python test client

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@739629 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Sat, 31 Jan 2009 21:39:08 +0000 (21:39 +0000)]

python: Make the unit tests run faster and more reliably

- The async test was making the server sleep for 2 seconds. Cut it to 0.5.
- The test driver was waiting 5 seconds for shutdown. Cut it to 1.
- Add a 0.25 second sleep to make sure the server comes up before the client.

This is all a bit hacky, but it is better than the status quo.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@739628 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Greg Stein [Sat, 31 Jan 2009 03:54:03 +0000 (03:54 +0000)]

THRIFT-295: remove empty directories.

These directories have no files in them. Toss 'em from version control.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@739501 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Greg Stein [Fri, 30 Jan 2009 19:19:45 +0000 (19:19 +0000)]

THRIFT-292

Delete a number of generated artifacts. The build system should produce
these, rather than having them stored in version control.

* contrib/fb303/py/fb303/...: remove generated Python bindings

* contrib/fb303/java/FacebookService.java:
* contrib/fb303/java/fb_status.java:
* contrib/fb303/java/Constants.java:
- remove generated Java bindings

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@739384 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Greg Stein [Fri, 30 Jan 2009 19:10:27 +0000 (19:10 +0000)]

THRIFT-291

* README: tweak for Thrift's new home at Apache.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@739380 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Thu, 29 Jan 2009 23:54:41 +0000 (23:54 +0000)]

Add a few new generated directories to .gitignore

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@739089 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Thu, 29 Jan 2009 23:53:34 +0000 (23:53 +0000)]

Accidentally svn:ignored Makefile*, getting rid of Makefile.am changes

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@739087 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Thu, 29 Jan 2009 23:46:46 +0000 (23:46 +0000)]

THRIFT-289. cpp: Fix "make check" by defining a comparator for "Instanity"

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@739083 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Thu, 29 Jan 2009 22:13:56 +0000 (22:13 +0000)]

THRIFT-290. java: Metadata map doesn't properly reference external thrift file's types

The code generator now uses full namespaces to refer to the classes.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@739045 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Thu, 29 Jan 2009 21:31:25 +0000 (21:31 +0000)]

THRIFT-289. test: "make check" no longer runs the Java tests

Thanks to David for the changes that straighten the makefiles out.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@739024 13f79535-47bb-0310-9956-ffa450edef68

Unnamed repository; edit this file 'description' to name the repository.