common/thrift.git
18 years agoApplying Thrift software license to Python source
Mark Slee [Thu, 1 Mar 2007 00:20:36 +0000 (00:20 +0000)] 
Applying Thrift software license to Python source

Reviewed By: python

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665032 13f79535-47bb-0310-9956-ffa450edef68

18 years agoApply Thrift license to Java sources
Mark Slee [Thu, 1 Mar 2007 00:00:27 +0000 (00:00 +0000)] 
Apply Thrift license to Java sources

Reviewed By: bash

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665031 13f79535-47bb-0310-9956-ffa450edef68

18 years agoThrift license applied to all the C++ files
Mark Slee [Wed, 28 Feb 2007 23:58:26 +0000 (23:58 +0000)] 
Thrift license applied to all the C++ files

Reviewed By: bash

Notes: marc says $*, corson says "$@"

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665030 13f79535-47bb-0310-9956-ffa450edef68

18 years agoSome Thrift documentation cleanups
Mark Slee [Wed, 28 Feb 2007 21:43:54 +0000 (21:43 +0000)] 
Some Thrift documentation cleanups

Summary: Getting ready to hand this over to powerset, just want to have the right licenses in place and such first.

Reviewed By: thrift

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665029 13f79535-47bb-0310-9956-ffa450edef68

18 years agoTApplicationException handling in PHP generated thrift code
Mark Slee [Tue, 27 Feb 2007 22:11:39 +0000 (22:11 +0000)] 
TApplicationException handling in PHP generated thrift code

Reviewed By: php

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665028 13f79535-47bb-0310-9956-ffa450edef68

18 years agoBogus $this->type in TApplicationException in PHP
Mark Slee [Tue, 27 Feb 2007 22:11:09 +0000 (22:11 +0000)] 
Bogus $this->type in TApplicationException in PHP

Reviewed By: php

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665027 13f79535-47bb-0310-9956-ffa450edef68

18 years agoPython HttpClient for Thrift
Mark Slee [Tue, 27 Feb 2007 20:17:00 +0000 (20:17 +0000)] 
Python HttpClient for Thrift

Reviewed By: thrifty goodness for SMC

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665026 13f79535-47bb-0310-9956-ffa450edef68

18 years agoThrift HTTP client optimizations
Mark Slee [Tue, 27 Feb 2007 19:53:38 +0000 (19:53 +0000)] 
Thrift HTTP client optimizations

Summary: When reading chunked encoding don't always get all the parts right away, return one part at a time so that reading code can deserialize the data on the fly.

Reviewed By: http

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665025 13f79535-47bb-0310-9956-ffa450edef68

18 years agoVarious bug fixes with the THttpClient
Mark Slee [Tue, 27 Feb 2007 19:03:01 +0000 (19:03 +0000)] 
Various bug fixes with the THttpClient

Summary: All kinds of buffer madness, what a pain.

Reviewed By: http

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665024 13f79535-47bb-0310-9956-ffa450edef68

18 years agoWhoops there were 2 extra spaces in this code
Mark Slee [Tue, 27 Feb 2007 05:18:07 +0000 (05:18 +0000)] 
Whoops there were 2 extra spaces in this code

Summary: That bothers me.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665023 13f79535-47bb-0310-9956-ffa450edef68

18 years agoThrift HTTP client in C++
Mark Slee [Tue, 27 Feb 2007 05:16:23 +0000 (05:16 +0000)] 
Thrift HTTP client in C++

Reviewed By: aditya, dweatherford

Test Plan: SMC client

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665022 13f79535-47bb-0310-9956-ffa450edef68

18 years agoSame fix to thrift codebase
Mark Slee [Tue, 27 Feb 2007 01:16:55 +0000 (01:16 +0000)] 
Same fix to thrift codebase

Reviewed By: aditya

 line, and those below, will be ignored--

M    php/src/Thrift.php
M    php/src/transport/TSocket.php
M    php/src/transport/TPhpStream.php

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665021 13f79535-47bb-0310-9956-ffa450edef68

18 years ago-- fix overflow error in seekToChunk()
Aditya Agarwal [Tue, 27 Feb 2007 00:07:45 +0000 (00:07 +0000)] 
-- fix overflow error in seekToChunk()

Summary:
- I love finding overflow errors.

Reviewed By: jwang

Test Plan: tested by rolling back search logfile

Notes:
- This should not affect anything currently in production.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665020 13f79535-47bb-0310-9956-ffa450edef68

18 years agoFix thrift includes
Mark Slee [Thu, 22 Feb 2007 01:01:10 +0000 (01:01 +0000)] 
Fix thrift includes

Summary: Remove circular ref

Reviewed By: lucas

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665019 13f79535-47bb-0310-9956-ffa450edef68

18 years agoProper exception types in PHP thrift
Mark Slee [Wed, 21 Feb 2007 07:35:03 +0000 (07:35 +0000)] 
Proper exception types in PHP thrift

Reviewed By: tbr-aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665018 13f79535-47bb-0310-9956-ffa450edef68

18 years agoRemove nonexistent TBuf ref
Mark Slee [Wed, 21 Feb 2007 05:42:38 +0000 (05:42 +0000)] 
Remove nonexistent TBuf ref

Reviewed By: goozebury

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665017 13f79535-47bb-0310-9956-ffa450edef68

18 years agoMove constant defs into Thrift.py to avoid cirulcar includes
Mark Slee [Wed, 21 Feb 2007 05:38:12 +0000 (05:38 +0000)] 
Move constant defs into Thrift.py to avoid cirulcar includes

Reviewed By: snakes

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665016 13f79535-47bb-0310-9956-ffa450edef68

18 years agoPython application level exceptions
Mark Slee [Wed, 21 Feb 2007 05:37:50 +0000 (05:37 +0000)] 
Python application level exceptions

Reviewed By: snakes

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665015 13f79535-47bb-0310-9956-ffa450edef68

18 years agoSome thrift test code fixes
Mark Slee [Wed, 21 Feb 2007 05:17:48 +0000 (05:17 +0000)] 
Some thrift test code fixes

Reviewed By: tbr-testaditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665014 13f79535-47bb-0310-9956-ffa450edef68

18 years agoStarting python exception handling cleanup
Mark Slee [Wed, 21 Feb 2007 05:16:30 +0000 (05:16 +0000)] 
Starting python exception handling cleanup

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665013 13f79535-47bb-0310-9956-ffa450edef68

18 years agoprotocol exceptions in java
Mark Slee [Wed, 21 Feb 2007 04:56:26 +0000 (04:56 +0000)] 
protocol exceptions in java

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665012 13f79535-47bb-0310-9956-ffa450edef68

18 years agoMore java error codes in thrift
Mark Slee [Wed, 21 Feb 2007 04:54:38 +0000 (04:54 +0000)] 
More java error codes in thrift

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665011 13f79535-47bb-0310-9956-ffa450edef68

18 years agoNew thrift c++ error code
Mark Slee [Wed, 21 Feb 2007 04:54:05 +0000 (04:54 +0000)] 
New thrift c++ error code

Summary: ALREADY_OPEN

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665010 13f79535-47bb-0310-9956-ffa450edef68

18 years agoThrift application exceptions in Java, code gen
Mark Slee [Wed, 21 Feb 2007 04:17:55 +0000 (04:17 +0000)] 
Thrift application exceptions in Java, code gen

Reviewed By: jrift

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665009 13f79535-47bb-0310-9956-ffa450edef68

18 years agoThrift application exceptions in Java
Mark Slee [Wed, 21 Feb 2007 04:17:34 +0000 (04:17 +0000)] 
Thrift application exceptions in Java

Reviewed By: thrift

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665008 13f79535-47bb-0310-9956-ffa450edef68

18 years agoC++ Thrift server throws application exceptions for invalid message types
Mark Slee [Wed, 21 Feb 2007 01:40:05 +0000 (01:40 +0000)] 
C++ Thrift server throws application exceptions for invalid message types

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665007 13f79535-47bb-0310-9956-ffa450edef68

18 years agoApplication exception types for Thrift
Mark Slee [Wed, 21 Feb 2007 01:39:23 +0000 (01:39 +0000)] 
Application exception types for Thrift

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665006 13f79535-47bb-0310-9956-ffa450edef68

18 years agoGen code with /usr/bin/env python not /usr/bin/python
Mark Slee [Wed, 21 Feb 2007 00:22:33 +0000 (00:22 +0000)] 
Gen code with /usr/bin/env python not /usr/bin/python

Summary: More reliable, lets user customize which python to use

Reviewed By: dougb

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665005 13f79535-47bb-0310-9956-ffa450edef68

18 years agoPython code gen includes __init__.py and package directory
Mark Slee [Wed, 21 Feb 2007 00:05:18 +0000 (00:05 +0000)] 
Python code gen includes __init__.py and package directory

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665004 13f79535-47bb-0310-9956-ffa450edef68

18 years agoThrift Binary protocol improvements and application exceptions
Mark Slee [Tue, 20 Feb 2007 20:59:21 +0000 (20:59 +0000)] 
Thrift Binary protocol improvements and application exceptions

Summary: Add application exceptions for unknown methods etc, and also let binary protocol support size limits on containers and strings

Reviewed By: aditya, xp-wayne

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665003 13f79535-47bb-0310-9956-ffa450edef68

18 years agoInclude debug symbols in thrift builds by default
Mark Slee [Tue, 20 Feb 2007 20:57:36 +0000 (20:57 +0000)] 
Include debug symbols in thrift builds by default

Summary: Too irritating not having stack traces when these go down. Sack up and include stack traces always... bigger binary but whatever.

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665002 13f79535-47bb-0310-9956-ffa450edef68

18 years agoGenerate Java code into proper source directory heirarchy
Mark Slee [Tue, 20 Feb 2007 18:44:05 +0000 (18:44 +0000)] 
Generate Java code into proper source directory heirarchy

Reviewed By: tbr-aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665001 13f79535-47bb-0310-9956-ffa450edef68

18 years agoTake out debug print in TServer constructor
Mark Slee [Tue, 20 Feb 2007 04:23:26 +0000 (04:23 +0000)] 
Take out debug print in TServer constructor

Reviewed By: aditya

Test Plan: no print on construct

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665000 13f79535-47bb-0310-9956-ffa450edef68

18 years agoanother typo i missed
Mark Slee [Tue, 20 Feb 2007 03:41:35 +0000 (03:41 +0000)] 
another typo i missed

Summary: outut

Reviewed By: aditya

Test Plan: blog

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664999 13f79535-47bb-0310-9956-ffa450edef68

18 years agoAdityaslop typos in thrift py server
Mark Slee [Tue, 20 Feb 2007 03:37:28 +0000 (03:37 +0000)] 
Adityaslop typos in thrift py server

Summary: outut is not output

Reviewed By: aditya, cheever

Test Plan: blogfeeds fixin

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664998 13f79535-47bb-0310-9956-ffa450edef68

18 years agoThrift: Changing TFileTransport to use the same buffer-swap mechanism that pillar...
James Wang [Wed, 14 Feb 2007 23:22:08 +0000 (23:22 +0000)] 
Thrift: Changing TFileTransport to use the same buffer-swap mechanism that pillar does

Reviewed by: aditya

Tested with thrift test class

Notes: TFileTransport used to use a circular buffer.  Changed this to use two large buffers, one for reading and one for writing, that are swapped whenever the writer thread finishes with the last write.

Also changed a few default constants -- force_flush timeout is now 3 sec, default buffer size is 10000 entries

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664997 13f79535-47bb-0310-9956-ffa450edef68

18 years agoTake brackets out of cpp_type bit
Mark Slee [Fri, 9 Feb 2007 21:55:44 +0000 (21:55 +0000)] 
Take brackets out of cpp_type bit

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664996 13f79535-47bb-0310-9956-ffa450edef68

18 years agoFix code gen to getTransport() not getOutputTransport()
Mark Slee [Fri, 9 Feb 2007 02:14:43 +0000 (02:14 +0000)] 
Fix code gen to getTransport() not getOutputTransport()

Reviewed By: wayne

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664995 13f79535-47bb-0310-9956-ffa450edef68

18 years agoFix handling of accept() exceptions in threadedserver
Mark Slee [Thu, 8 Feb 2007 22:29:24 +0000 (22:29 +0000)] 
Fix handling of accept() exceptions in threadedserver

Reviewed By: threadz-aditya-tbr

Notes: Propagating fix from TThreadPoolServer

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664994 13f79535-47bb-0310-9956-ffa450edef68

18 years agoThrift: PHP Socket instrumentation for connect/read/write issues
Martin Kraemer [Wed, 7 Feb 2007 22:39:58 +0000 (22:39 +0000)] 
Thrift: PHP Socket instrumentation for connect/read/write issues

Summary:
Sockets now error with timeout messages if it's a timeout over general read failures.

Reviewed By: Slee

Test Plan: Tested with payment broker client with overloaded addresses and send/recv timeouts.

Revert Plan: revertible

Notes:

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664993 13f79535-47bb-0310-9956-ffa450edef68

18 years agoImplement TSimpleServer in Ruby
Mark Slee [Wed, 7 Feb 2007 06:05:28 +0000 (06:05 +0000)] 
Implement TSimpleServer in Ruby

Summary: It Works!

Reviewed By: tbr-doug

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664992 13f79535-47bb-0310-9956-ffa450edef68

18 years agoRuby test server code
Mark Slee [Wed, 7 Feb 2007 06:03:53 +0000 (06:03 +0000)] 
Ruby test server code

Reviewed By: tbr-doug

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664991 13f79535-47bb-0310-9956-ffa450edef68

18 years agoFixes for ruby server code gen
Mark Slee [Wed, 7 Feb 2007 06:03:32 +0000 (06:03 +0000)] 
Fixes for ruby server code gen

Reviewed By: tbr-doug

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664990 13f79535-47bb-0310-9956-ffa450edef68

18 years agoUpdate test code with TPipedTransport
Mark Slee [Wed, 7 Feb 2007 04:07:07 +0000 (04:07 +0000)] 
Update test code with TPipedTransport

Reviewed By: tbr-aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664989 13f79535-47bb-0310-9956-ffa450edef68

18 years ago-- Servers should not crash on accept.
Aditya Agarwal [Wed, 7 Feb 2007 03:54:18 +0000 (03:54 +0000)] 
-- Servers should not crash on accept.

Summary:
- Continue running if there is an accept issue

Reviewed By: slee

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664988 13f79535-47bb-0310-9956-ffa450edef68

18 years agoThrift supports the "senum" type now
Mark Slee [Wed, 7 Feb 2007 02:40:59 +0000 (02:40 +0000)] 
Thrift supports the "senum" type now

Summary: Enumerated lists of strings, enforced only in XSD

Reviewed By: xsd

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664987 13f79535-47bb-0310-9956-ffa450edef68

18 years ago-- Remove reference to TBufferedRouter.h/cpp in Makefile
Aditya Agarwal [Wed, 7 Feb 2007 02:38:54 +0000 (02:38 +0000)] 
-- Remove reference to TBufferedRouter.h/cpp in Makefile

Reviewed By: slee

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664986 13f79535-47bb-0310-9956-ffa450edef68

18 years ago-- typo in TSocket
Aditya Agarwal [Wed, 7 Feb 2007 02:36:56 +0000 (02:36 +0000)] 
-- typo in TSocket

Reviewed By: slee

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664985 13f79535-47bb-0310-9956-ffa450edef68

18 years agoxsd_attrs are a FieldList now, so you can have multiple of them and they are typed
Mark Slee [Wed, 7 Feb 2007 01:20:08 +0000 (01:20 +0000)] 
xsd_attrs are a FieldList now, so you can have multiple of them and they are typed

Reviewed By: xsd

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664984 13f79535-47bb-0310-9956-ffa450edef68

18 years agoThrift code-gen optimizations to use raw pointers where possible
Mark Slee [Wed, 7 Feb 2007 00:54:49 +0000 (00:54 +0000)] 
Thrift code-gen optimizations to use raw pointers where possible

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664983 13f79535-47bb-0310-9956-ffa450edef68

18 years agoProtocol should hang onto shared pointer for protection but always use underlying...
Mark Slee [Wed, 7 Feb 2007 00:54:17 +0000 (00:54 +0000)] 
Protocol should hang onto shared pointer for protection but always use underlying raw pointer

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664982 13f79535-47bb-0310-9956-ffa450edef68

18 years agoThrift support for the xsd_nillable attribute
Mark Slee [Tue, 6 Feb 2007 21:03:18 +0000 (21:03 +0000)] 
Thrift support for the xsd_nillable attribute

Reviewed By: dave

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664981 13f79535-47bb-0310-9956-ffa450edef68

18 years agoNAmespace PHP exceptions in catch block properly and add getName() method to generate...
Mark Slee [Tue, 6 Feb 2007 07:11:23 +0000 (07:11 +0000)] 
NAmespace PHP exceptions in catch block properly and add getName() method to generated structs

Reviewed By: ari

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664980 13f79535-47bb-0310-9956-ffa450edef68

18 years ago-- TBufferedRouterTransport being renamed to TPipedTransport
Aditya Agarwal [Tue, 6 Feb 2007 03:25:13 +0000 (03:25 +0000)] 
-- TBufferedRouterTransport being renamed to TPipedTransport

Summary:
- TBufferedRouterTransport is the most nonsensical name I have ever
  heard of

Reviewed By: slee

Test Plan: it compiles

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664979 13f79535-47bb-0310-9956-ffa450edef68

18 years ago-- Protocol and transport factories now wrap around a single protocol/transport
Aditya Agarwal [Tue, 6 Feb 2007 02:51:15 +0000 (02:51 +0000)] 
-- Protocol and transport factories now wrap around a single protocol/transport

Summary:
- This is an analagous to the C++ change made in r31441

Reviewed By: slee

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664978 13f79535-47bb-0310-9956-ffa450edef68

18 years ago-- Protocol and transport factories now wrap around a single protocol/transport
Aditya Agarwal [Tue, 6 Feb 2007 02:50:56 +0000 (02:50 +0000)] 
-- Protocol and transport factories now wrap around a single protocol/transport

Summary:
- This is an analagous to the C++ change made in r31441

Reviewed By: slee

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664977 13f79535-47bb-0310-9956-ffa450edef68

18 years ago-- Allow specification of socket timeouts in thrift python socket code
Aditya Agarwal [Tue, 6 Feb 2007 01:26:12 +0000 (01:26 +0000)] 
-- Allow specification of socket timeouts in thrift python socket code

Reviewed By: slee

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664976 13f79535-47bb-0310-9956-ffa450edef68

18 years ago-- Protocol and transport factories now wrap around a single protocol/transport
Aditya Agarwal [Tue, 6 Feb 2007 01:14:33 +0000 (01:14 +0000)] 
-- Protocol and transport factories now wrap around a single protocol/transport

Summary:
- This is an analagous to the C++ change made in r31441

Reviewed By: cheever, mcslee

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664975 13f79535-47bb-0310-9956-ffa450edef68

18 years agoAdding XSD attribute support
Mark Slee [Mon, 5 Feb 2007 21:52:08 +0000 (21:52 +0000)] 
Adding XSD attribute support

Reviewed By: dave

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664974 13f79535-47bb-0310-9956-ffa450edef68

18 years agosvn adding t_doc.h
Mark Slee [Mon, 5 Feb 2007 21:47:03 +0000 (21:47 +0000)] 
svn adding t_doc.h

Summary: charlie you missed this one!

Reviewed By: cheever

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664973 13f79535-47bb-0310-9956-ffa450edef68

18 years agoThrift: Supported for file descriptor == 0 and cleanup error output
Martin Kraemer [Mon, 5 Feb 2007 21:40:38 +0000 (21:40 +0000)] 
Thrift: Supported for file descriptor == 0 and cleanup error output

Summary:
Thrift improperly initialized file descriptors to zero and treated 0 and an invalid value.  0 is a valid file descriptor.  Also, commented out error message on client disconnect for TThreadPoolServer

Reviewed By: Marc & Karl

Revert Plan: revertible

Notes:

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664972 13f79535-47bb-0310-9956-ffa450edef68

18 years agoThrift: Exception message is protected and accessible to derived classes.
Martin Kraemer [Mon, 5 Feb 2007 20:58:41 +0000 (20:58 +0000)] 
Thrift: Exception message is protected and accessible to derived classes.

Summary:
Exception message is protected and accessible to derived classes.

Reviewed By: Karl

Revert Plan: revertible

Notes:

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664971 13f79535-47bb-0310-9956-ffa450edef68

18 years agoadding documentation syntax to thrift
ccheever [Mon, 5 Feb 2007 20:33:11 +0000 (20:33 +0000)] 
adding documentation syntax to thrift

see DocTest.thrift for examples.

todo: integrate parsed documentation into code generation

review: marc k, mcslee
test plan: DocTest.thrift

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664970 13f79535-47bb-0310-9956-ffa450edef68

18 years agoThrift fixes for Exceptions and TServerSocket
Martin Kraemer [Sat, 3 Feb 2007 01:59:12 +0000 (01:59 +0000)] 
Thrift fixes for Exceptions and TServerSocket

Summary:
TServerSocket detected file des. 0 as an invalid file des.  This has been fixed.

Reviewed By: Steve

Revert Plan: Revertible

Notes:

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664969 13f79535-47bb-0310-9956-ffa450edef68

18 years agoTFileTransport %lu => %u
Mark Slee [Fri, 2 Feb 2007 00:09:51 +0000 (00:09 +0000)] 
TFileTransport %lu => %u

Summary: compiler warnings are lame

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664968 13f79535-47bb-0310-9956-ffa450edef68

18 years agoPrevent direct instantation of ThreadManager
Mark Slee [Thu, 1 Feb 2007 23:05:38 +0000 (23:05 +0000)] 
Prevent direct instantation of ThreadManager

Reviewed By: marc

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664967 13f79535-47bb-0310-9956-ffa450edef68

18 years agoBring C++ thrift stress test up to date with new constructs
Mark Slee [Thu, 1 Feb 2007 22:55:30 +0000 (22:55 +0000)] 
Bring C++ thrift stress test up to date with new constructs

Reviewed By: marc

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664966 13f79535-47bb-0310-9956-ffa450edef68

18 years agoAdding threaded server to Thrift
Mark Slee [Thu, 1 Feb 2007 22:55:00 +0000 (22:55 +0000)] 
Adding threaded server to Thrift

Summary: Spawns a new thread for each client connection

Reviewed By: marc

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664965 13f79535-47bb-0310-9956-ffa450edef68

18 years agoFix bufferedroutertransport overflow bugs
Mark Slee [Thu, 1 Feb 2007 21:39:50 +0000 (21:39 +0000)] 
Fix bufferedroutertransport overflow bugs

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664964 13f79535-47bb-0310-9956-ffa450edef68

18 years agoDefault values and nullification for thrift code
Mark Slee [Thu, 1 Feb 2007 05:26:18 +0000 (05:26 +0000)] 
Default values and nullification for thrift code

Summary: All things are null now, unless you specify a default value!

Reviewed By: marc

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664963 13f79535-47bb-0310-9956-ffa450edef68

18 years agoThrift: Fix xsd:sequence and xsd:all minOccurs/maxOccurs generation
dave [Thu, 1 Feb 2007 00:17:28 +0000 (00:17 +0000)] 
Thrift: Fix xsd:sequence and xsd:all minOccurs/maxOccurs generation

The minOccurs and maxOccurs attributes should appear on the elements, rather than the containers.

for a thrift struct, we produce:
<sequence>
<element name="some_element"> <!-- max is implicitly 1 -->
<element name="some_optional_element" minOccurs="0"> <!-- max is
implicitly 1 -->
...

for a thrift list, we produce
<sequence>
<element name="the_list_element" minOccurs="0" maxOccurs="unbounded">
</sequence>

for a thrift struct tagged with xsd_all, we produce

<all>
<element name="some_element" minOccurs="0"/>  <!-- max is implicitly 1
-->
</all>

Reviewed By: mcslee

Test Plan: sandbox

Revert Plan: revertible

Notes:

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664962 13f79535-47bb-0310-9956-ffa450edef68

18 years agoFix for TBufferedTransport double-buffer-size strings
Mark Slee [Wed, 31 Jan 2007 08:31:29 +0000 (08:31 +0000)] 
Fix for TBufferedTransport double-buffer-size strings

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664961 13f79535-47bb-0310-9956-ffa450edef68

18 years agoThrift: Finish namespace generation from xsd_namespace command
dave [Wed, 31 Jan 2007 02:49:01 +0000 (02:49 +0000)] 
Thrift: Finish namespace generation from xsd_namespace command

In .thrift file:

xsd_namespace "http://api.facebook.com/v1"

Turns up in the xsd output as:

<xsd:schema xmlns:xsd="http://www.w3.org/2001/XMLSchema"
 targetNamespace="http://api.facebook.com/v1"
 xmlns="http://api.facebook.com/v1"
 elementFormDefault="qualified">

to properly accommodate our generated xml

Thank you, Slee.

Reviewed By: mcslee

Test Plan: sandbox

Revert Plan: revertible

Notes:

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664960 13f79535-47bb-0310-9956-ffa450edef68

18 years agoxsd_namespace keyword for thrift
Mark Slee [Wed, 31 Jan 2007 02:08:30 +0000 (02:08 +0000)] 
xsd_namespace keyword for thrift

Summary: So you can Spaceify the Shiznits

Reviewed By: fett

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664959 13f79535-47bb-0310-9956-ffa450edef68

18 years agoMove var declarations out of switch blocks in Thrift
Mark Slee [Tue, 30 Jan 2007 19:52:05 +0000 (19:52 +0000)] 
Move var declarations out of switch blocks in Thrift

Summary: Strict G++ compliance

Reviewed By: fett

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664958 13f79535-47bb-0310-9956-ffa450edef68

18 years agoThrift: Small changes to support XSD generation
dave [Tue, 30 Jan 2007 19:50:30 +0000 (19:50 +0000)] 
Thrift: Small changes to support XSD generation

xs:restriction -> xsd:restriction
minoccurs -> minOccurs

Reviewed By: marc

Test Plan: sandbox

Revert Plan: revertible

Notes:

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664957 13f79535-47bb-0310-9956-ffa450edef68

18 years agoThrift gen'd code now checks for field ID AND type matches
Mark Slee [Mon, 29 Jan 2007 17:58:54 +0000 (17:58 +0000)] 
Thrift gen'd code now checks for field ID AND type matches

Summary: Will call skip() even if FID matches when there is an invalid field type identifier

Reviewed By: corson

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664956 13f79535-47bb-0310-9956-ffa450edef68

18 years agoFix HashMap => AbstractMap conversions in Java test thrift code
Mark Slee [Mon, 29 Jan 2007 17:35:54 +0000 (17:35 +0000)] 
Fix HashMap => AbstractMap conversions in Java test thrift code

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664955 13f79535-47bb-0310-9956-ffa450edef68

18 years agoUpdate configure.ac to include compiler/cpp directory
Mark Slee [Sat, 27 Jan 2007 01:58:17 +0000 (01:58 +0000)] 
Update configure.ac to include compiler/cpp directory

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664954 13f79535-47bb-0310-9956-ffa450edef68

18 years agoRuby support for Thrift
Mark Slee [Sat, 27 Jan 2007 01:44:22 +0000 (01:44 +0000)] 
Ruby support for Thrift

Summary: Just client support so far.

Reviewed By: tbr-doug

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664953 13f79535-47bb-0310-9956-ffa450edef68

18 years agoThrift: indentation
Martin Kraemer [Fri, 26 Jan 2007 01:41:03 +0000 (01:41 +0000)] 
Thrift: indentation

Summary:
sigh mixed indentation sytyles.

Reviewed By: Slee

Test Plan: Test by building..

Revert Plan: revertible

Notes:

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664952 13f79535-47bb-0310-9956-ffa450edef68

18 years agoSeparate thrift into libthrift and libthriftnb
Mark Slee [Thu, 25 Jan 2007 08:14:50 +0000 (08:14 +0000)] 
Separate thrift into libthrift and libthriftnb

Summary: libthriftnb is the one that requires libevent. It was really annoying that you always had to put -levent in your link step to build thrift programs when youa re not using any of the c++ nonblocking stuff. This way, if you're using nonblocking you can do that, but the normal case is easier to link.

Reviewed By: makefile

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664951 13f79535-47bb-0310-9956-ffa450edef68

18 years agoFix relative paths in test dirs
Mark Slee [Thu, 25 Jan 2007 08:01:28 +0000 (08:01 +0000)] 
Fix relative paths in test dirs

Reviewed By: makefile

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664950 13f79535-47bb-0310-9956-ffa450edef68

18 years agoFull automake/autoconf compliance for thrift
Mark Slee [Thu, 25 Jan 2007 07:58:55 +0000 (07:58 +0000)] 
Full automake/autoconf compliance for thrift

Summary: Including the compiler!!!

Reviewed By: automake

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664949 13f79535-47bb-0310-9956-ffa450edef68

18 years agoFix bootstrap for the jwang
Mark Slee [Thu, 25 Jan 2007 06:28:24 +0000 (06:28 +0000)] 
Fix bootstrap for the jwang

Summary: SORRY MY HAX)RDS WAS BROKED

Reviewed By: jwang

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664948 13f79535-47bb-0310-9956-ffa450edef68

18 years ago-- ThriftLogfile is finally done.
Aditya Agarwal [Thu, 25 Jan 2007 03:27:43 +0000 (03:27 +0000)] 
-- ThriftLogfile is finally done.

Summary:
- Everything seems to be working well..

Reviewed By: tbr - slee

Test Plan: Tested using search

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664947 13f79535-47bb-0310-9956-ffa450edef68

18 years agoFix Makefile to use thrifty.yy and thriftl.ll
Mark Slee [Thu, 25 Jan 2007 02:10:07 +0000 (02:10 +0000)] 
Fix Makefile to use thrifty.yy and thriftl.ll

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664946 13f79535-47bb-0310-9956-ffa450edef68

18 years agoRename some thrif tcompiler files
Mark Slee [Thu, 25 Jan 2007 02:07:22 +0000 (02:07 +0000)] 
Rename some thrif tcompiler files

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664945 13f79535-47bb-0310-9956-ffa450edef68

18 years agoAdd some smaller test cases and fix new single protocol/transport C++ test
Mark Slee [Wed, 24 Jan 2007 23:42:12 +0000 (23:42 +0000)] 
Add some smaller test cases and fix new single protocol/transport C++ test

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664944 13f79535-47bb-0310-9956-ffa450edef68

18 years ago-- Error recovery code for thrift logfile
Aditya Agarwal [Wed, 24 Jan 2007 23:39:10 +0000 (23:39 +0000)] 
-- Error recovery code for thrift logfile

Summary:
- perform some basic corruption checks:
   1) Event larger than chunk
   2) Event larger than specified max
   3) Event crossing chunk boundary etc.
- If error encountered, then try to perform some recovery

Reviewed By: Slee

Test Plan: Going to test now...need to check in because of compile issues

Notes:
- These checks take care of the case when there is a dirty read from the filesystem (which
  we have encountered with the netapps). The recovery involves trying to perform the read
  again from ths FS and if that fails skipping the chunk altogether.
  Keep in mind that this might only be useful for idempotent systems (e.g. search redolog).

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664943 13f79535-47bb-0310-9956-ffa450edef68

18 years agoThrift socket should not perror in the TRYAGAIN state
Mark Slee [Wed, 24 Jan 2007 23:14:30 +0000 (23:14 +0000)] 
Thrift socket should not perror in the TRYAGAIN state

Reviewed By: wayne

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664942 13f79535-47bb-0310-9956-ffa450edef68

18 years agoNo more getInputTransport vs getOutputTransport in protocols
Mark Slee [Wed, 24 Jan 2007 22:57:20 +0000 (22:57 +0000)] 
No more getInputTransport vs getOutputTransport in protocols

Summary: It is just getTransport ow

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664941 13f79535-47bb-0310-9956-ffa450edef68

18 years ago-- Change concept of protocol and transport factory
Aditya Agarwal [Wed, 24 Jan 2007 22:53:54 +0000 (22:53 +0000)] 
-- Change concept of protocol and transport factory

Summary:
- Transport factories now wrap around one transport
- Protocol factories now wrap around one transport (as opposed to a pair of input/output
   transports)
- TServer now takes input/output transport and protocol factories

The motivation for this change is that you could concievably want to use a different protocol or
transport for input and output. An example is that incoming data is encoded using binary protocol
but outgoing data is encrypted XML (with encryption being done on the transport level).

This change should be mostly backwards compatible because the TServer classes have constructors
that take a transport factory and use that for both the input and transport factories. The only
change might be for anyone who is using the C++ client code directly i.e. instantiating
TBinaryProtocol() directly because the constructor now only accepts one transport.

Reviewed By: Slee

Test Plan: Everything compiles (for both thrift and search).

Notes:
I am going to make the same changes in all the supported languages after this...

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664940 13f79535-47bb-0310-9956-ffa450edef68

18 years agoGenerate pargs an presult helpers in C++ to be more efficient in thrift
Mark Slee [Wed, 24 Jan 2007 22:53:07 +0000 (22:53 +0000)] 
Generate pargs an presult helpers in C++ to be more efficient in thrift

Summary: Copy construction is the pits. Avoid it at all costs.

Reviewed By: aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664939 13f79535-47bb-0310-9956-ffa450edef68

18 years agoFix C++ Thrift test code to work with new gen'd code interface
Mark Slee [Wed, 24 Jan 2007 19:43:06 +0000 (19:43 +0000)] 
Fix C++ Thrift test code to work with new gen'd code interface

Reviewed By: tbr-aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664938 13f79535-47bb-0310-9956-ffa450edef68

18 years agoNonblockingserver constructor that uses binary protocol factory by default
Mark Slee [Wed, 24 Jan 2007 19:41:57 +0000 (19:41 +0000)] 
Nonblockingserver constructor that uses binary protocol factory by default

Reviewed By: tbr-aditya

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664937 13f79535-47bb-0310-9956-ffa450edef68

18 years ago-- thrift logfile fixes
Aditya Agarwal [Wed, 24 Jan 2007 02:24:35 +0000 (02:24 +0000)] 
-- thrift logfile fixes

Summary:
-- numChunks was broken and that was causing a lot of strange downstream behaviour

Reviewed By: tbr slee

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664936 13f79535-47bb-0310-9956-ffa450edef68

18 years agoNo need to generate private __construct() function if the class is already final
Mark Slee [Tue, 23 Jan 2007 23:22:35 +0000 (23:22 +0000)] 
No need to generate private __construct() function if the class is already final

Reviewed By: lucas

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664935 13f79535-47bb-0310-9956-ffa450edef68

18 years agoUse proper name for catching exceptions
Mark Slee [Fri, 19 Jan 2007 23:49:00 +0000 (23:49 +0000)] 
Use proper name for catching exceptions

Reviewed By: tbr-dave

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664934 13f79535-47bb-0310-9956-ffa450edef68

18 years agoThrift XSD generator populates PHP globals with type names for typedeffed stuffs
Mark Slee [Fri, 19 Jan 2007 22:12:10 +0000 (22:12 +0000)] 
Thrift XSD generator populates PHP globals with type names for typedeffed stuffs

Reviewed By: dave

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664933 13f79535-47bb-0310-9956-ffa450edef68