Supwisdom Source - common/thrift.git/log

Code Review / common / thrift.git / log

summary | shortlog | log | commit | commitdiff | review | tree
first ⋅ prev ⋅ next

commit | commitdiff | tree

Bryan Duxbury [Tue, 12 May 2009 16:53:23 +0000 (16:53 +0000)]

THRIFT-349. php: Accelerated binary protocol serialization segementation fault

Check to make sure that the object being serialized has a valid struct spec, error otherwise.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@773976 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 12 May 2009 16:44:52 +0000 (16:44 +0000)]

THRIFT-499. php: Thrift_protocol PHP extension does not handle signedness correctly

Cast all the number types to signed values before making PHP longs out of them.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@773974 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Tue, 12 May 2009 02:17:43 +0000 (02:17 +0000)]

THRIFT-495. python: Raise a TTransportException if TSocket is not open

Previously, TSocket.write would raise an AttributeError if the transport
had not been opened. A TTransportException with the code set to
NOT_OPEN is more appropriate. The cost of the check should be
negligible, since TSocket.write is already fairly expensive (it does a
system call).

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@773762 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Mon, 11 May 2009 18:09:24 +0000 (18:09 +0000)]

THRIFT-493. java: Stopping TNonblockingServer when it hasn't been starting results in an exception

Check if the server is null before trying to stop.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@773632 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Sun, 10 May 2009 05:14:44 +0000 (05:14 +0000)]

THRIFT-494. python: Update meta-information in setup.py

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@773306 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Thu, 7 May 2009 00:41:18 +0000 (00:41 +0000)]

THRIFT-490. Clarify the comment for the Guard macro

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@772478 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Wed, 6 May 2009 22:00:33 +0000 (22:00 +0000)]

THRIFT-483. Use --copy for libtoolize

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@772440 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Wed, 6 May 2009 17:22:11 +0000 (17:22 +0000)]

THRIFT-482. java: build.xml does not specify a target version for compiled java classes

This patch updates the build file to target java 1.5.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@772373 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 5 May 2009 18:59:49 +0000 (18:59 +0000)]

THRIFT-486. rb: ruby tutorial needs updated require statements

Fixed.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@771969 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 5 May 2009 18:50:26 +0000 (18:50 +0000)]

THRIFT-485. rb: Generated validate methods that reference external thrift files' types are not referenced correctly

This patch fully qualifies type names in two spots.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@771964 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Kevin Clark [Tue, 5 May 2009 00:53:01 +0000 (00:53 +0000)]

Preparing for 0.1.0 RC1

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@771515 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andrew McGeachie [Tue, 5 May 2009 00:44:48 +0000 (00:44 +0000)]

THRIFT-60. Make generated constants object extend NSObject.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@771514 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Kevin Clark [Tue, 5 May 2009 00:43:59 +0000 (00:43 +0000)]

Add version number to Rakefile, update generated manifest (via rake)

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@771513 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Kevin Clark [Mon, 4 May 2009 22:00:47 +0000 (22:00 +0000)]

Adding incubator disclaimer

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@771464 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andrew McGeachie [Mon, 4 May 2009 21:17:55 +0000 (21:17 +0000)]

THRIFT-478. Release our input and output stream instance variables when we're dealloc to avoid a memory leak.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@771447 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Wed, 29 Apr 2009 23:35:01 +0000 (23:35 +0000)]

THRIFT-471. python: Generated exceptions should implement __str__

This makes Python stack dumps properly show the exception content.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@770002 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Wed, 29 Apr 2009 23:20:56 +0000 (23:20 +0000)]

THRIFT-453. java: By default, use Ivy to download Java dependencies

build.xml will now download Apache Ivy into the build tree.  Ivy will
then be used to download the other Java dependencies: log4j and Apache
Commons Lang.  This achieves the goal of allowing the Java library to be
built from a clean checkout, without requiring users to manually obtain
dependencies or checking external binaries into the source tree.

The Ivy behavior (except for a few mkdir calls) can be inhibited by
passing -Dnoivy= on the ant command line (or in a property file).  In
this case, log4j must be available in the user's CLASSPATH.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@769995 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Wed, 29 Apr 2009 04:54:24 +0000 (04:54 +0000)]

THRIFT-470. fb303: Use a namespace in Perl gen-code

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@769653 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Mon, 27 Apr 2009 19:36:50 +0000 (19:36 +0000)]

THRIFT-463. python: Fix thrift_spec ordering bug from r760201

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@769123 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Mon, 27 Apr 2009 19:25:23 +0000 (19:25 +0000)]

THRIFT-467. csharp: Fix compilation on Debian Sid

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@769114 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

T Jake Luciani [Tue, 21 Apr 2009 00:50:11 +0000 (00:50 +0000)]

THRIFT-460: fixes constant structs

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@766933 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

T Jake Luciani [Mon, 20 Apr 2009 01:38:42 +0000 (01:38 +0000)]

THRIFT-461: moves thrift compiler call to test suite

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@766558 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Wed, 15 Apr 2009 17:37:52 +0000 (17:37 +0000)]

Add makefile stuff to svn:ignore

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@765279 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Mon, 13 Apr 2009 18:12:07 +0000 (18:12 +0000)]

THRIFT-451. rb: ruby structs use lowercase enum while modules are capitalized

This patch updates the full_type_name call so it capitalizes a type before it's appended to the module prefix.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@764549 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Mon, 13 Apr 2009 17:48:23 +0000 (17:48 +0000)]

THRIFT-445. rb: client and processor do not inherit from the proper namespace scope

This patch adds namespace support to a client and processor extended from an included thrift def with its own namespace.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@764540 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Fri, 10 Apr 2009 21:51:00 +0000 (21:51 +0000)]

THRIFT-236. Structs should be serialized in a consistent order

2nd try at this issue. This time, we will use numeric field order ONLY for the serialization portion, instead of globally. This should make it much easier to produce the correctly ordered output in all cases.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@764072 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Fri, 10 Apr 2009 17:20:51 +0000 (17:20 +0000)]

THRIFT-416. java: java.util.logging eats exceptions without warning

This patch switches the logging framework to log4j and updates all the server implementations accordingly.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@763981 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Thu, 9 Apr 2009 20:02:56 +0000 (20:02 +0000)]

THRIFT-445. Revert r760201 "THRIFT-236. Sort fields in id order during parsing"

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@763786 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Wed, 8 Apr 2009 20:46:13 +0000 (20:46 +0000)]

Remove "Library" from CHANGES because the compiler is also affected

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@763384 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Wed, 8 Apr 2009 00:19:37 +0000 (00:19 +0000)]

THRIFT-387. Add appropriate Apache header to all code files

This hits all the documentation and some misc code files that have avoided the license up to this point.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@763048 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 7 Apr 2009 23:45:15 +0000 (23:45 +0000)]

THRIFT-444. rb: THRIFT-356 broke compact protocol spec

This patch cleans up the spec, removing some unncessary code.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@763043 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Tue, 7 Apr 2009 23:44:01 +0000 (23:44 +0000)]

Add some more info to CHANGES and re-sort it

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@763040 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Tue, 7 Apr 2009 23:38:39 +0000 (23:38 +0000)]

smalltalk: Fix TBinaryProtocol readString for empty strings

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@763037 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 7 Apr 2009 23:29:42 +0000 (23:29 +0000)]

THRIFT-407. hs: Refactor and improve Haskell-related code

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@763031 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 7 Apr 2009 23:27:01 +0000 (23:27 +0000)]

THRIFT-390. hs: Cabalize Haskell library code

Missed some files that needed to be added.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@763030 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 7 Apr 2009 23:23:39 +0000 (23:23 +0000)]

THRIFT-390. hs: Cabalize Haskell library code

Use Cabal to build and install the Haskell library code.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@763029 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Kevin Clark [Tue, 7 Apr 2009 22:47:34 +0000 (22:47 +0000)]

THRIFT-431. rb: Capitalize namespace values

Author: Michael Stockton

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@763022 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 7 Apr 2009 22:23:40 +0000 (22:23 +0000)]

THRIFT-437. rb: fix benchmarking tools to require proper file names

A few scripts in benchmark/ and script/ were using old-style require statments.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@763003 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Tue, 7 Apr 2009 20:51:48 +0000 (20:51 +0000)]

THRIFT-356. Improve CompactProtocolTestStruct

- Remove the default values from CompactProtocolTestStruct
- Add a const CompactProtocolTestStruct that contains those values

This has a short-term benefit and a long-term benefit.

The short-term benefit is that it removes the list-as-map-key
(etc.) values from the "types" generated file and puts it into
the "constants" generated file.  This gets them out of the way
of the Python tests, so they pass again.

The long term benefit is that is strengthens the Java TCompactProtocol
test.  Before, it was reading the "full" CompactProtocolTestStruct into
a CompactProtocolTestStruct that was just constructed, but the latter
was already almost equal to the former.  This change makes it much
easier to create an empty CompactProtocolTestStruct to read the serialized
data into.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@762957 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Tue, 7 Apr 2009 20:51:37 +0000 (20:51 +0000)]

THRIFT-427. java: Fix print_const_value

Simplify it a bit in the process, because the beans-style setters
are produced even in non-beans mode, and they handle isset internally.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@762956 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Kevin Clark [Tue, 7 Apr 2009 20:03:09 +0000 (20:03 +0000)]

THRIFT-421. rb: Fix tests broken by original patch

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@762928 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Kevin Clark [Tue, 7 Apr 2009 19:12:01 +0000 (19:12 +0000)]

Add basic Changelog

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@762908 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Kevin Clark [Tue, 7 Apr 2009 19:09:28 +0000 (19:09 +0000)]

Thrift-421. rb: Underscore output file names and require file statments

Breaks compatiblity

Author: Michael Stockton

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@762907 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 7 Apr 2009 16:35:49 +0000 (16:35 +0000)]

THRIFT-433. rb: 'rake spec' sort of fails

This patch allows the process to exit cleanly. Yay!

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@762840 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 7 Apr 2009 16:31:04 +0000 (16:31 +0000)]

THRIFT-175. Specs in Ruby library should be run during make check

This patch makes 'make check' run 'rake spec' in the appropriate scenarios. There is still another bug that will break the build though.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@762838 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 7 Apr 2009 04:40:50 +0000 (04:40 +0000)]

THRIFT-422. rb: scope all references to the Thrift module

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@762620 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 7 Apr 2009 04:37:28 +0000 (04:37 +0000)]

THRIFT-430. rb: ruby tutorials and ruby tests require deprecated files and class names

This patch cleans all this up.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@762618 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Sun, 5 Apr 2009 06:19:51 +0000 (06:19 +0000)]

Flush output at the end of thrift_dump

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@762043 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Sat, 4 Apr 2009 00:58:03 +0000 (00:58 +0000)]

THRIFT-276. rb: Ruby libraries should have one class per file

This monster of a patch moves all the classes into their own files and specs as appropriate. Additionally, it concentrates all the requires into thrift.rb, removing the need to require any other file. (Changes were made to the compiler to reflect this reduced requirement.)

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@761849 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Fri, 3 Apr 2009 19:07:19 +0000 (19:07 +0000)]

THRIFT-426. cpp: Fix include path under test/cpp

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@761763 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Fri, 3 Apr 2009 17:29:25 +0000 (17:29 +0000)]

THRIFT-423. -strict should turn omitted field ids into compile error

Issue name says it all.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@761736 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Fri, 3 Apr 2009 15:05:28 +0000 (15:05 +0000)]

THRIFT-425. cpp: numeric_limits is declared in <limits>

TCompactProtocol.cpp doesn't compile without including limits.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@761705 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Thu, 2 Apr 2009 23:51:39 +0000 (23:51 +0000)]

THRIFT-411. cpp: Make TNonblockingServer::connectionStackLimit_ accessors use the right type

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@761481 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Thu, 2 Apr 2009 23:49:20 +0000 (23:49 +0000)]

cpp: Rename Makefiles under test/cpp

".mk" is the usual extension for makefiles not named
"GNUMakefile", "Makefile", or "makefile". "Makefile.thrift"
should be a Thrift IDL file (think "Makefile.PL").

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@761480 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Thu, 2 Apr 2009 23:49:18 +0000 (23:49 +0000)]

cpp: Fix test server/client under test/cpp

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@761479 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Thu, 2 Apr 2009 23:05:40 +0000 (23:05 +0000)]

cpp: Fix compiler and library compilation with newer glibc

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@761464 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Thu, 2 Apr 2009 21:37:17 +0000 (21:37 +0000)]

THRIFT-333. cpp: Initial TCompactProtocol implementation

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@761438 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Thu, 2 Apr 2009 21:37:12 +0000 (21:37 +0000)]

Run aclocal before autoheader

It looks ike autoheader inspects ./aclocal.m4 (produced by aclocal)
but not ./aclocal (which is read by aclocal), so it doesn't pick up
our custom defines unless we run aclocal first.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@761437 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Thu, 2 Apr 2009 19:24:02 +0000 (19:24 +0000)]

THRIFT-420. Remove all negative structure field ids from the code

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@761393 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Thu, 2 Apr 2009 19:23:59 +0000 (19:23 +0000)]

THRIFT-420. Warn on implicit (negative) structure field ids

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@761391 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Thu, 2 Apr 2009 19:22:31 +0000 (19:22 +0000)]

THRIFT-388. Create a "ONEWAY" message type that is an alias for "CALL"

Pave the way for a new message type for oneway function calls.
For now, just define the constant in all languages and make
server implementations treat it the same way as a normal call.
Only C++ and Erlang currently check the message type (on the
server side).

There is a little bit of redundancy in the Erlang code, but
the alternative is a bit gross, and this split-up will be
necessary eventually when we start handling one-way calls
differently.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@761389 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Thu, 2 Apr 2009 00:48:11 +0000 (00:48 +0000)]

Get rid of missing LICENSE files from some Makefile.am

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@761137 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Wed, 1 Apr 2009 21:01:56 +0000 (21:01 +0000)]

THRIFT-393. RPM .spec file has incorrect license

Changed "Thrift Software License" to "Apache license v2.0".

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@761056 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Wed, 1 Apr 2009 20:10:15 +0000 (20:10 +0000)]

THRIFT-417. rb: BufferedTransport can enter an infinite loop

Switch native proto implementations to use read_all instead of read. Add a bunch of tests to verify.

Also:
- removed some commented code in binary_protocol_accelerated.c
- struct.c was missing one of the possible native method calls
- updates gem manifest (included files that didn't exist)
- fixed svn:ignores of test/rb/gen-rb and lib/java/gen-java

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@761037 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 31 Mar 2009 23:51:07 +0000 (23:51 +0000)]

THRIFT-410. rb: Ruby lib should have no checked in generated code

Forgot the gen-rb in lib/rb/benchmark.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760739 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 31 Mar 2009 23:48:36 +0000 (23:48 +0000)]

THRIFT-415. rb: BinaryProtocolAccelerated does not behave properly when strict reads are turned off

This patch adds the appropriate test for the behavior and fixes the thrift_native project to do the right thing.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760735 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Tue, 31 Mar 2009 21:09:26 +0000 (21:09 +0000)]

rb: The shared binary protocol specs lacked a test for read_message_begin

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760637 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Mon, 30 Mar 2009 22:52:51 +0000 (22:52 +0000)]

THRIFT-387. Add license to a bunch of fb303 files

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760222 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Mon, 30 Mar 2009 22:52:46 +0000 (22:52 +0000)]

THRIFT-387. Add license to a few misc files

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760221 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Mon, 30 Mar 2009 22:52:44 +0000 (22:52 +0000)]

THRIFT-387. Add license to configure.ac

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760220 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Mon, 30 Mar 2009 22:52:42 +0000 (22:52 +0000)]

THRIFT-387. Add license to pkgconfig files

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760219 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Mon, 30 Mar 2009 22:52:39 +0000 (22:52 +0000)]

Remove obsolete php extension tag

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760218 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Mon, 30 Mar 2009 22:52:35 +0000 (22:52 +0000)]

THRIFT-387. Fix LICENSE, add NOTICE, and add some third-party licenses

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760217 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Mon, 30 Mar 2009 22:52:29 +0000 (22:52 +0000)]

THRIFT-387. Add license statements to some autoconf macro files

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760216 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Mon, 30 Mar 2009 22:24:30 +0000 (22:24 +0000)]

THRIFT-236. Sort fields in id order during parsing

This effectively eliminates the notion of "IDL-order".
All structs have their fields sorted in increasing order of field id.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760201 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Mon, 30 Mar 2009 21:35:00 +0000 (21:35 +0000)]

THRIFT-387. Add license headers to a bunch of files

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760189 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Mon, 30 Mar 2009 21:25:20 +0000 (21:25 +0000)]

Fix up Manifest again to include the proper files for gem building

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760184 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Mon, 30 Mar 2009 21:24:34 +0000 (21:24 +0000)]

Needed a newline at the end of the file to avoid warnings when compiling on linux.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760183 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Mon, 30 Mar 2009 21:22:54 +0000 (21:22 +0000)]

contrib: Update thrift_dump to use the new namespace

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760182 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Mon, 30 Mar 2009 21:22:52 +0000 (21:22 +0000)]

csharp: Remove a BOM and CRLF line endings from some test code

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760181 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Mon, 30 Mar 2009 20:47:05 +0000 (20:47 +0000)]

THRIFT-307. erlang: Make HiPE optional

You can still use it by running "make ERLC_FLAGS='+native'".

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760166 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Mon, 30 Mar 2009 20:47:01 +0000 (20:47 +0000)]

THRIFT-306. erlang: Let thrift_http_transport specify custom HTTP headers

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760165 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Mon, 30 Mar 2009 20:46:56 +0000 (20:46 +0000)]

THRIFT-305. erlang: Fix http_options for thrift_http_transport

The old implementation of thrift_http_transport:set_http_options assumed
that the return value of thrift_transport:new was a pid, but it isn't.
It is a private structure. Therefore, set_http_options could never work.
Now, thrift_http_transport:new takes an optional third argument,
an assoc-list of options, including http_options.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760164 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Mon, 30 Mar 2009 20:46:52 +0000 (20:46 +0000)]

THRIFT-192. erlang: Commit test code missed in r757870

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760163 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Mon, 30 Mar 2009 20:46:47 +0000 (20:46 +0000)]

THRIFT-127. erlang: Skip fields that have the wrong type

In the other languages (AFAIK), if a field has the wrong type,
it is silently skipped. Erlang currently assumes that the type
is correct and de-synchronizes. This change makes it behave like
the other languages (except that it is not silent).

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760161 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Mon, 30 Mar 2009 20:46:37 +0000 (20:46 +0000)]

THRIFT-126. erlang: TMemoryBuffer for Erlang

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760160 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Mon, 30 Mar 2009 20:11:45 +0000 (20:11 +0000)]

Need a newline at the end of the file for it to compile.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760143 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Mon, 30 Mar 2009 19:52:39 +0000 (19:52 +0000)]

Get rid of gem Manifest entries for files that don't exist anymore

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760129 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Mon, 30 Mar 2009 19:31:36 +0000 (19:31 +0000)]

THRIFT-412. python: Fix some syntacticaly-incorrect code generation

r758558 introduced a but that caused some of the generated docstrings
to be indented incorrectly, resulting in syntactically invalid code.
This commit fixes the indentation.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760118 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Mon, 30 Mar 2009 17:14:06 +0000 (17:14 +0000)]

THRIFT-410. rb: Ruby lib should have no checked in generated code

This patch deletes the existing checked in ruby code, adds all the generated ruby code directories to svn:ignore, and updates the Rakefile so that "rake spec" generates the ruby code automatically.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760050 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Thu, 26 Mar 2009 23:32:36 +0000 (23:32 +0000)]

THRIFT-153. Proper handling of strings with escapes (in IDL)

- Recognize and parse escape characters in .thrift files.
- Escape strings used as constants in generated source files.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758922 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Thu, 26 Mar 2009 23:32:27 +0000 (23:32 +0000)]

Make vim recognize that "thriftl.ll" is Lex source

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758921 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Bryan Duxbury [Thu, 26 Mar 2009 18:41:44 +0000 (18:41 +0000)]

THRIFT-372. rb: Ruby lib doesn't rescue properly from lack of native_thrift extension

This patch adds a new thrift/thrift_native.rb which should be the require point for application users. It also removes some unnecessary code from a few files and cleans up requires in some specs.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758794 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Thu, 26 Mar 2009 08:47:07 +0000 (08:47 +0000)]

THRIFT-389. Make "make dist" work properly for Subversion working copies

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758560 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Thu, 26 Mar 2009 08:40:55 +0000 (08:40 +0000)]

THRIFT-282. Generate doccstrings for Python classes

Docstrings are generated for
  - enums (but not enum members)
  - structures and structure fields
  - service interfaces
  - functions and function arguments

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758558 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Thu, 26 Mar 2009 08:40:18 +0000 (08:40 +0000)]

THRIFT-282. Move generate_docstring_comment to t_generator

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758556 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Thu, 26 Mar 2009 06:23:57 +0000 (06:23 +0000)]

THRIFT-255. cpp: Add TSimpleFileTransport, a wrapper around TFDTransport

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758533 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Thu, 26 Mar 2009 06:22:18 +0000 (06:22 +0000)]

THRIFT-154. python: Make THttpClient take a URL in its constructor

Support https in the process.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758532 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Thu, 26 Mar 2009 06:15:26 +0000 (06:15 +0000)]

cpp: Eliminate a buffer overflow in the tutorial server

Negative numbers can have 11 characters :)

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758529 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

David Reiss [Thu, 26 Mar 2009 06:15:05 +0000 (06:15 +0000)]

THRIFT-405. php: Create a tutorial server

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758528 13f79535-47bb-0310-9956-ffa450edef68

Unnamed repository; edit this file 'description' to name the repository.