common/thrift.git
15 years agoTHRIFT-670. java: Unions don't skip unrecognizable fields correctly
Bryan Duxbury [Thu, 31 Dec 2009 18:59:15 +0000 (18:59 +0000)] 
THRIFT-670. java: Unions don't skip unrecognizable fields correctly

This patch adds a test and a fix for the bug.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@894924 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-668. java: Using a map in an exception type will generate a class that does...
Bryan Duxbury [Thu, 31 Dec 2009 18:18:00 +0000 (18:18 +0000)] 
THRIFT-668. java: Using a map in an exception type will generate a class that does not implement Comperable-> that will generate a stub that does not compile

The compiler was incorrectly assuming that exceptions were comparable. Now, exceptions are treated just like structs.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@894919 13f79535-47bb-0310-9956-ffa450edef68

15 years ago(no ticket). java: Make Unions print binary values more tersely
Bryan Duxbury [Mon, 28 Dec 2009 18:49:03 +0000 (18:49 +0000)] 
(no ticket). java: Make Unions print binary values more tersely

Bytes were getting sign-extended out into giant strings of f's. This change makes sure only the bottom byte is used.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@894222 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-632. java: Constants of enum types don't behave well
Bryan Duxbury [Fri, 18 Dec 2009 19:41:11 +0000 (19:41 +0000)] 
THRIFT-632. java: Constants of enum types don't behave well

This patch causes constants of all types to be resolved differently by the compiler, and makes it so that constants of enum types contain a reference to the enum type so that code generators can produce the correct names.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@892358 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-653. java: Fix toString method for enums
Bryan Duxbury [Fri, 18 Dec 2009 19:34:25 +0000 (19:34 +0000)] 
THRIFT-653. java: Fix toString method for enums

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@892357 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-645. java: Create ant rules for running the test client and server
David Reiss [Wed, 9 Dec 2009 19:30:01 +0000 (19:30 +0000)] 
THRIFT-645. java: Create ant rules for running the test client and server

I didn't make these depend on compile-test since ant doesn't seem to
detect that the class files are up to date, so it takes a really long
time to recompile everything.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@888931 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-592. php: Make the test client work properly after r815878
David Reiss [Wed, 9 Dec 2009 19:29:59 +0000 (19:29 +0000)] 
THRIFT-592. php: Make the test client work properly after r815878

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@888930 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-592. php: Make the tutorial work properly after r815878
David Reiss [Wed, 9 Dec 2009 19:29:48 +0000 (19:29 +0000)] 
THRIFT-592. php: Make the tutorial work properly after r815878

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@888929 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-622. Add appropriate licensing information to get Thrift ready for a release.
Todd Lipcon [Mon, 7 Dec 2009 00:42:38 +0000 (00:42 +0000)] 
THRIFT-622. Add appropriate licensing information to get Thrift ready for a release.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@887812 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-637. python: Fix mixing of oneway and regular requests in TNonblockingServer
Todd Lipcon [Thu, 3 Dec 2009 01:18:44 +0000 (01:18 +0000)] 
THRIFT-637. python: Fix mixing of oneway and regular requests in TNonblockingServer

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@886646 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-551. java: Enumeration doesn't generate real enum in Java
Bryan Duxbury [Thu, 19 Nov 2009 17:26:38 +0000 (17:26 +0000)] 
THRIFT-551. java: Enumeration doesn't generate real enum in Java
This patch makes the compiler generate actual Enum classes.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@882211 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-628. java: Hash code method for _Fields objects does not behave as expected
Bryan Duxbury [Tue, 17 Nov 2009 21:56:43 +0000 (21:56 +0000)] 
THRIFT-628. java: Hash code method for _Fields objects does not behave as expected
This patch switches to using the hashcode of the actual field id, instead of the field id enumeration.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@881559 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-621. cpp: Fix generated files using "apache" namespaces
David Reiss [Fri, 13 Nov 2009 04:52:10 +0000 (04:52 +0000)] 
THRIFT-621. cpp: Fix generated files using "apache" namespaces

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@835739 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-623. java: Use a Java enum to represent field ids in generated structs
Bryan Duxbury [Thu, 12 Nov 2009 20:52:25 +0000 (20:52 +0000)] 
THRIFT-623. java: Use a Java enum to represent field ids in generated structs

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@835538 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-619: Perl server and example
T Jake Luciani [Thu, 12 Nov 2009 03:01:33 +0000 (03:01 +0000)] 
THRIFT-619: Perl server and example

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@835206 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-626: Increase timeouts for socket requests
T Jake Luciani [Thu, 12 Nov 2009 02:44:42 +0000 (02:44 +0000)] 
THRIFT-626: Increase timeouts for socket requests

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@835203 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-590: send/recv timeout values interchanged in perl socket lib
T Jake Luciani [Thu, 12 Nov 2009 02:36:30 +0000 (02:36 +0000)] 
THRIFT-590: send/recv timeout values interchanged in perl socket lib

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@835200 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-624. java: compareTo is broken for Unions with binary fields
Bryan Duxbury [Wed, 11 Nov 2009 21:01:35 +0000 (21:01 +0000)] 
THRIFT-624. java: compareTo is broken for Unions with binary fields
This patch adds a special case for byte[] values in TUnion. It also fixes a related bug in TBaseHelper for comparing two byte arrays.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@835065 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-210. c#: Add support for TFramedTransport
Esteve Fernandez [Wed, 11 Nov 2009 18:32:25 +0000 (18:32 +0000)] 
THRIFT-210. c#: Add support for TFramedTransport

author: Michael Greene (euphoria)

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@835006 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-565. java: Structs containing typedefs for incomparable objects will be consid...
Bryan Duxbury [Mon, 9 Nov 2009 15:55:22 +0000 (15:55 +0000)] 
THRIFT-565. java: Structs containing typedefs for incomparable objects will be considered comparable
This patch causes the compiler to fully unwrap typedefs when determining comparability.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@834119 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-620. java: Compact Protocol should call readAll, not read
Bryan Duxbury [Wed, 4 Nov 2009 00:30:10 +0000 (00:30 +0000)] 
THRIFT-620. java: Compact Protocol should call readAll, not read
This patch switches to calling readAll instead of read.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@832633 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-613. Make generated objects implement the NSCoding protocol.
Andrew McGeachie [Tue, 3 Nov 2009 18:52:15 +0000 (18:52 +0000)] 
THRIFT-613.  Make generated objects implement the NSCoding protocol.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@832507 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-612. python: Fix exception bug in TFramedTransport.cstringio_refill
David Reiss [Wed, 28 Oct 2009 17:07:14 +0000 (17:07 +0000)] 
THRIFT-612. python: Fix exception bug in TFramedTransport.cstringio_refill

readFrame was being called without "self."

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@830673 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-614. Add some more info to the exception that gets thrown when THTTPClient...
Andrew McGeachie [Tue, 27 Oct 2009 20:27:49 +0000 (20:27 +0000)] 
THRIFT-614. Add some more info to the exception that gets thrown when THTTPClient encounters an unexpected NSURLResponse object.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@830329 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-521. Change @synthesize property declarations to @dynamic for happy compiling...
Andrew McGeachie [Tue, 27 Oct 2009 20:23:02 +0000 (20:23 +0000)] 
THRIFT-521. Change @synthesize property declarations to @dynamic for happy compiling on OS X 10.6 as well as 10.5

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@830326 13f79535-47bb-0310-9956-ffa450edef68

15 years agopynames
David Reiss [Wed, 21 Oct 2009 06:09:16 +0000 (06:09 +0000)] 
pynames

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@827893 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-606. cpp: Fix build on Solaris Nevada
David Reiss [Wed, 21 Oct 2009 05:51:28 +0000 (05:51 +0000)] 
THRIFT-606. cpp: Fix build on Solaris Nevada

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@827890 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-589. java: Add Field Name to Field ID Mapping
Bryan Duxbury [Thu, 15 Oct 2009 01:24:26 +0000 (01:24 +0000)] 
THRIFT-589. java: Add Field Name to Field ID Mapping
Java Thrift structs now have a static mapping of field name to field ID.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@825371 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-603. rb: Struct read method does not call validate
Bryan Duxbury [Thu, 15 Oct 2009 01:20:34 +0000 (01:20 +0000)] 
THRIFT-603. rb: Struct read method does not call validate
After reading a struct, we will now call the struct's validate method.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@825369 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-529. java: Change generated constructors so that application code evolves...
Bryan Duxbury [Fri, 2 Oct 2009 00:56:53 +0000 (00:56 +0000)] 
THRIFT-529. java: Change generated constructors so that application code evolves better
Optional fields are now excluded from constructors.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@820857 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-477. java: remove extra methods generated for collections
Bryan Duxbury [Thu, 1 Oct 2009 22:52:25 +0000 (22:52 +0000)] 
THRIFT-477. java: remove extra methods generated for collections
I have rolled back the patch originally applied in this issue.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@820831 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-446. java: PartialDeserialization in Java
Bryan Duxbury [Thu, 1 Oct 2009 20:53:45 +0000 (20:53 +0000)] 
THRIFT-446. java: PartialDeserialization in Java

This patch adds a partialDeserialize method to TDeserializer that allows you to request a specific subfield of the serialized data.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@820786 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-588. java: Generated .equals method throws NPE for thrift object
Bryan Duxbury [Fri, 25 Sep 2009 20:28:35 +0000 (20:28 +0000)] 
THRIFT-588. java: Generated .equals method throws NPE for thrift object

If other is null, then they're not equal.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@818998 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-586. python: TSocket incorrectly sets the exception type when an end of file...
Esteve Fernandez [Thu, 24 Sep 2009 10:22:00 +0000 (10:22 +0000)] 
THRIFT-586. python: TSocket incorrectly sets the exception type when an end of file error occurs

TTransportException's type was set to "Transport not open" in some cases, which should
be its message.
Use named arguments and set the type for TTransportException to END_OF_FILE in TSocket#read
and TSocket#write.

reviewer: dreiss

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@818429 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-572. java: Union compareTo is broken
Bryan Duxbury [Mon, 21 Sep 2009 16:52:48 +0000 (16:52 +0000)] 
THRIFT-572. java: Union compareTo is broken

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@817317 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-587. cpp: Properly set addrLen before accept calls
David Reiss [Sat, 19 Sep 2009 01:59:13 +0000 (01:59 +0000)] 
THRIFT-587. cpp: Properly set addrLen before accept calls

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@816850 13f79535-47bb-0310-9956-ffa450edef68

15 years agogenerate Twisted code in a separate directory (gen-py.twisted)
Esteve Fernandez [Thu, 17 Sep 2009 19:19:11 +0000 (19:19 +0000)] 
generate Twisted code in a separate directory (gen-py.twisted)

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@816340 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-584. php: Generate a better directory structure
David Reiss [Wed, 16 Sep 2009 16:57:05 +0000 (16:57 +0000)] 
THRIFT-584. php: Generate a better directory structure

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@815878 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-583. python: Allow new-style classes for Interfaces
David Reiss [Wed, 16 Sep 2009 16:50:00 +0000 (16:50 +0000)] 
THRIFT-583. python: Allow new-style classes for Interfaces

The original new-style class only affected structs, enums, and
exceptions.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@815874 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-574. erlang: Support framed transport for servers
David Reiss [Wed, 9 Sep 2009 17:18:57 +0000 (17:18 +0000)] 
THRIFT-574. erlang: Support framed transport for servers

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@813054 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-575. Allow required fields in function parameters
David Reiss [Wed, 2 Sep 2009 22:15:55 +0000 (22:15 +0000)] 
THRIFT-575. Allow required fields in function parameters

r665255 was a bit too aggressive.  "optional" was causing confusion,
but there doesn't seem to be any harm in allowing "required".

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@810713 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-569. rb: Segmentation Fault when using BinaryProtocolAccelerated in Ruby
Bryan Duxbury [Wed, 2 Sep 2009 20:05:07 +0000 (20:05 +0000)] 
THRIFT-569. rb: Segmentation Fault when using BinaryProtocolAccelerated in Ruby

This patch checks to make sure that a value is a string before treating it as one.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@810689 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-572. rb: fix RSTRING for 1.9 compatibility
Bryan Duxbury [Tue, 1 Sep 2009 23:18:34 +0000 (23:18 +0000)] 
THRIFT-572. rb: fix RSTRING for 1.9 compatibility

Use a macro compatible with Ruby 1.9.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@810303 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-409. java: Add "union" to Thrift
Bryan Duxbury [Tue, 1 Sep 2009 23:03:47 +0000 (23:03 +0000)] 
THRIFT-409. java: Add "union" to Thrift

This patch introduces new IDL syntax for creating Unions, explicityly single-valued structs. While the parser changes are portable, this patch only includes the actual generated code changes for the Java library. Other libraries can continue to generate a struct with the same fields and remain compatible until they are able to implement the full shebang.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@810300 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-571. rb: compact_protocol.c:89: warning: format not a string literal and no...
Bryan Duxbury [Tue, 1 Sep 2009 22:32:50 +0000 (22:32 +0000)] 
THRIFT-571. rb: compact_protocol.c:89: warning: format not a string literal and no format arguments

This patch solves the issue for those of you on Ruby 1.9.1.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@810288 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMinor whitespace fixes in the Java generator and gen-code
David Reiss [Tue, 1 Sep 2009 21:36:46 +0000 (21:36 +0000)] 
Minor whitespace fixes in the Java generator and gen-code

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@810255 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-214. cpp: Qualify another cast
David Reiss [Tue, 1 Sep 2009 18:03:07 +0000 (18:03 +0000)] 
THRIFT-214. cpp: Qualify another cast

r722337 only fixed one occurrence of this issue.
Not sure why this one hasn't been a problem before,
but it is breaking compilation on Mac OS 10.6.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@810150 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRevert r806014 "THRIFT-562. java: Java is inconsistent ..."
David Reiss [Thu, 27 Aug 2009 20:27:09 +0000 (20:27 +0000)] 
Revert r806014 "THRIFT-562. java: Java is inconsistent ..."

- It changed the semantics of default-presence fields.
- It messed up calls that accept exceptions.
- Full details on issue.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@808609 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-562. java: Java is inconsistent checking for required fields
Bryan Duxbury [Thu, 20 Aug 2009 01:00:18 +0000 (01:00 +0000)] 
THRIFT-562. java: Java is inconsistent checking for required fields

This patch makes the compiler act consistently regarding what it means to be required or optional. Additionally, it cleans up the tests to actually use the Fixtures class all over.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@806014 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-566. java: jar file should contain copies of LICENSE and NOTICE files
Bryan Duxbury [Thu, 20 Aug 2009 00:55:12 +0000 (00:55 +0000)] 
THRIFT-566. java: jar file should contain copies of LICENSE and NOTICE files

LICENSE and NOTICE are now included in the jar file by the build process.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@806013 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-558. java: Replace use of log4j by commons-logging in Java library and genera...
Bryan Duxbury [Fri, 14 Aug 2009 20:04:15 +0000 (20:04 +0000)] 
THRIFT-558. java:  Replace use of log4j by commons-logging in Java library and generated Java code

This patch switches Thrift to use slf4j instead of log4j.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@804349 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-561: Add "register" to list of reserved keywords
Mark Slee [Thu, 13 Aug 2009 19:21:40 +0000 (19:21 +0000)] 
THRIFT-561: Add "register" to list of reserved keywords

Reviewed By: dreiss

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@803997 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-555. cpp: Fix macro defintions for TCompact on non-GNU big endian
David Reiss [Wed, 5 Aug 2009 16:42:59 +0000 (16:42 +0000)] 
THRIFT-555. cpp: Fix macro defintions for TCompact on non-GNU big endian

We were defining ntolell and letonll, but we were only using
htolell and letohll.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@801293 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-115. java: Isset structure has a large memory footprint
Bryan Duxbury [Mon, 3 Aug 2009 19:37:26 +0000 (19:37 +0000)] 
THRIFT-115. java: Isset structure has a large memory footprint

Instead of the old __isset structure, there is now a bit vector for fields that require an isset flag.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@800510 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-144. java: Generated classes should implement Comparable
Bryan Duxbury [Fri, 31 Jul 2009 19:32:34 +0000 (19:32 +0000)] 
THRIFT-144. java: Generated classes should implement Comparable

Forgot to add TBaseHelper.java. Oops.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@799714 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-547. rb: Thrift deserializer hangs when deserializing empty string
Bryan Duxbury [Fri, 31 Jul 2009 18:53:14 +0000 (18:53 +0000)] 
THRIFT-547. rb: Thrift deserializer hangs when deserializing empty string

Thrift::MemoryBuffer will now throw an EOFError when it cannot fulfill a request for data.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@799696 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-498. rb: Compact and Binary native protocols, used at the same time, can cause...
Bryan Duxbury [Fri, 31 Jul 2009 18:47:09 +0000 (18:47 +0000)] 
THRIFT-498. rb: Compact and Binary native protocols, used at the same time, can cause some issues

Disable native method table usage.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@799693 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-554: Perl improper namespace check for exception handling and writeMessageEnd...
T Jake Luciani [Fri, 31 Jul 2009 01:31:00 +0000 (01:31 +0000)] 
THRIFT-554: Perl improper namespace check for exception handling and writeMessageEnd missing on processor calls

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@799484 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-144. java: Generated classes should implement Comparable
Bryan Duxbury [Fri, 31 Jul 2009 00:12:21 +0000 (00:12 +0000)] 
THRIFT-144. java: Generated classes should implement Comparable

If generated structs don't contain any incomparable child members, they implement Comparable.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@799474 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-552. rb: gem requires exactly rubygems 1.2.0
Bryan Duxbury [Thu, 30 Jul 2009 15:52:25 +0000 (15:52 +0000)] 
THRIFT-552. rb: gem requires exactly rubygems 1.2.0

The Thrift gem will now work with rubygems >= 1.2.0.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@799337 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-540. java: Have set methods return reference to self
Bryan Duxbury [Wed, 29 Jul 2009 23:47:38 +0000 (23:47 +0000)] 
THRIFT-540. java: Have set methods return reference to self

Issue title says it all, really.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@799130 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-479. java: Add javadocs for enum types
Bryan Duxbury [Wed, 29 Jul 2009 23:44:44 +0000 (23:44 +0000)] 
THRIFT-479. java: Add javadocs for enum types

Fields now reference their enum class name in javadoc. Also, generated enum classes's members are now javadoc'd.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@799128 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-477. java: remove extra methods generated for collections
Bryan Duxbury [Wed, 29 Jul 2009 19:46:00 +0000 (19:46 +0000)] 
THRIFT-477. java: remove extra methods generated for collections

This patch removes the special extra methods for collections.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@799036 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMake ax_lib_event.m4 set a per-version variable on success
David Reiss [Wed, 29 Jul 2009 19:07:33 +0000 (19:07 +0000)] 
Make ax_lib_event.m4 set a per-version variable on success

This makes it a little bit easier to check for several versions of
libevent and see which succeeded.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@799017 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-523. Make ax_lib_event.m4 work with newer versions of libevent
David Reiss [Wed, 29 Jul 2009 19:07:27 +0000 (19:07 +0000)] 
THRIFT-523. Make ax_lib_event.m4 work with newer versions of libevent

libevent changed is minor version numbering scheme with version 1.4.0,
and the simplistic comparison function used by ax_lib_event.m4 did not
work with the new scheme.  This patch introduced a more accurate
comparison function that works with all existing versions of libevent.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@799016 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-413. Suppport for annotations on base types
David Reiss [Mon, 27 Jul 2009 17:02:42 +0000 (17:02 +0000)] 
THRIFT-413. Suppport for annotations on base types

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@798219 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-549. Make socket client compatible with iPhone SDK as well as OS X
Andrew McGeachie [Fri, 24 Jul 2009 15:58:07 +0000 (15:58 +0000)] 
THRIFT-549. Make socket client compatible with iPhone SDK as well as OS X

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@797545 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-548. malloc our temporary buffer, rather than creating it on the stack.
Andrew McGeachie [Thu, 23 Jul 2009 18:12:18 +0000 (18:12 +0000)] 
THRIFT-548. malloc our temporary buffer, rather than creating it on the stack.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@797175 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-280. Server-side Cocoa implementation.
Andrew McGeachie [Tue, 21 Jul 2009 21:14:19 +0000 (21:14 +0000)] 
THRIFT-280. Server-side Cocoa implementation.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@796538 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-59. Make sure we don't over-release strings after we deserialize them.
Andrew McGeachie [Tue, 21 Jul 2009 20:14:31 +0000 (20:14 +0000)] 
THRIFT-59.  Make sure we don't over-release strings after we deserialize them.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@796518 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-545. Fix mem leak in generated 'description' method
Andrew McGeachie [Tue, 21 Jul 2009 17:22:03 +0000 (17:22 +0000)] 
THRIFT-545.  Fix mem leak in generated 'description' method

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@796391 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-521. Generate objective-c 2.0 propery declarations on iphone and OS X 10.5...
Andrew McGeachie [Tue, 21 Jul 2009 16:51:49 +0000 (16:51 +0000)] 
THRIFT-521. Generate objective-c 2.0 propery declarations on iphone and OS X 10.5 and greater.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@796377 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-520. Fix generation of cocoa constants when a namespace prefix is set.
Andrew McGeachie [Tue, 21 Jul 2009 16:12:33 +0000 (16:12 +0000)] 
THRIFT-520. Fix generation of cocoa constants when a namespace prefix is set.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@796356 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-533. Fix write:offset:length: to ensure all requested data is written.
Andrew McGeachie [Tue, 21 Jul 2009 15:34:07 +0000 (15:34 +0000)] 
THRIFT-533.  Fix write:offset:length: to ensure all requested data is written.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@796351 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-344. Add a 'log_unexpected' option to the cocoa generator. off by default...
Andrew McGeachie [Tue, 21 Jul 2009 15:30:16 +0000 (15:30 +0000)] 
THRIFT-344.  Add a 'log_unexpected' option to the cocoa generator.  off by default.  when supplied, unexpected field IDs and types are logged when reading a struct.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@796347 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-343. Import <Foundation/Foundation.h> instead of <Cocoa/Cocoa.h> to support...
Andrew McGeachie [Tue, 21 Jul 2009 14:45:12 +0000 (14:45 +0000)] 
THRIFT-343. Import <Foundation/Foundation.h> instead of <Cocoa/Cocoa.h> to support iPhone

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@796327 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-59. Fix memory leak by releasing allocated objects after assigning to container.
Andrew McGeachie [Tue, 21 Jul 2009 14:33:17 +0000 (14:33 +0000)] 
THRIFT-59. Fix memory leak by releasing allocated objects after assigning to container.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@796320 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-535. py: Twisted Thrift protocol max length is too small (fix off-by-one error...
Esteve Fernandez [Fri, 17 Jul 2009 18:35:52 +0000 (18:35 +0000)] 
THRIFT-535. py: Twisted Thrift protocol max length is too small (fix off-by-one error in MAX_LENGTH)

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@795187 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-535. py: Twisted Thrift protocol max length is too small
Esteve Fernandez [Fri, 17 Jul 2009 18:18:19 +0000 (18:18 +0000)] 
THRIFT-535. py: Twisted Thrift protocol max length is too small

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@795176 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-542: Perl compiler uses invalid method 'method_exists' and subsequent test
T Jake Luciani [Fri, 17 Jul 2009 01:37:01 +0000 (01:37 +0000)] 
THRIFT-542: Perl compiler uses invalid method 'method_exists' and subsequent test

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@794939 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-542: Perl compiler uses invalid method 'method_exists' and subsequent test
T Jake Luciani [Fri, 17 Jul 2009 01:34:50 +0000 (01:34 +0000)] 
THRIFT-542: Perl compiler uses invalid method 'method_exists' and subsequent test

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@794938 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-543. java: Generate normal style java files should respect the "optional"...
Bryan Duxbury [Tue, 14 Jul 2009 01:42:09 +0000 (01:42 +0000)] 
THRIFT-543. java: Generate normal style java files should respect the "optional" keyword when serializing

As the summary suggests, this patch causes "optional" fields to be skipped if they are unset, even if they are primitives. As this patch is for the non-beans style generator, the user is expected to maintain the set/unset status themselves.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@793778 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-350. php: Fix the extension build when C++ is not already used
David Reiss [Mon, 13 Jul 2009 17:21:03 +0000 (17:21 +0000)] 
THRIFT-350. php: Fix the extension build when C++ is not already used

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@793630 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-525. csharp: ThriftTest project will not generate c# from .thrift file or...
Bryan Duxbury [Thu, 2 Jul 2009 20:28:33 +0000 (20:28 +0000)] 
THRIFT-525. csharp: ThriftTest project will not generate c# from .thrift file or generate ThriftImpl.dll

C# test project correctly references directories with spaces and deletes only data it generates

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@790732 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-531. csharp: C# project and solution files reference external source control...
Bryan Duxbury [Thu, 2 Jul 2009 20:18:12 +0000 (20:18 +0000)] 
THRIFT-531. csharp: C# project and solution files reference external source control system

This patch removes the external source providers from all csproj and sln files.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@790731 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-204. csharp: C# Partial Classes
Bryan Duxbury [Thu, 2 Jul 2009 20:15:05 +0000 (20:15 +0000)] 
THRIFT-204. csharp: C# Partial Classes

C# structs are now generated as partial classes so they can be extended without wrapping.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@790730 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-526. rb: Generated Ruby enums have no good way to get the names back out once...
Bryan Duxbury [Wed, 24 Jun 2009 17:55:53 +0000 (17:55 +0000)] 
THRIFT-526. rb: Generated Ruby enums have no good way to get the names back out once you have a number.

enums generated in Ruby will now have a static map of enum values to names.

Patch by Adam Coffman (with slight modifications).

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@788098 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-524. erlang: Decapitalize file names in include directives
David Reiss [Thu, 18 Jun 2009 23:30:03 +0000 (23:30 +0000)] 
THRIFT-524. erlang: Decapitalize file names in include directives

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@786334 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-378. java: Java servers do not turn internal errors into thrift exceptions
Bryan Duxbury [Wed, 17 Jun 2009 16:43:25 +0000 (16:43 +0000)] 
THRIFT-378. java: Java servers do not turn internal errors into thrift exceptions

This patch causes Java servers to log internal server errors and return an INTERNAL_ERROR exception instead of just closing the connection.

Author: Jonathan Ellis

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@785713 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-462. java: Installed jar shouldn't be executable
David Reiss [Thu, 4 Jun 2009 02:05:25 +0000 (02:05 +0000)] 
THRIFT-462. java: Installed jar shouldn't be executable

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@781639 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-211. erlang: Modify test_tether to test protocol error handling as well
David Reiss [Thu, 4 Jun 2009 02:01:35 +0000 (02:01 +0000)] 
THRIFT-211. erlang: Modify test_tether to test protocol error handling as well

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@781637 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-211. erlang: Support "tethered" clients
David Reiss [Thu, 4 Jun 2009 02:01:32 +0000 (02:01 +0000)] 
THRIFT-211. erlang: Support "tethered" clients

Add a client option that causes clients to monitor their creators
and terminate when the creator dies.  This makes it possible to
prevent client leaks without linking, because the latter causes
application code to be killed when a transport error occurs and
exits are not trapped.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@781636 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-211. erlang: Allow clients to be created without connecting
David Reiss [Thu, 4 Jun 2009 02:01:28 +0000 (02:01 +0000)] 
THRIFT-211. erlang: Allow clients to be created without connecting

Add a client option to prevent the initial connect (which causes
the protocol factory to be ignored).  The main use case for this
is testing the proper handling of clients that cannot connect.
Update the tether test to use this feature instead of a raw
gen_server:start call.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@781635 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-211. erlang: Support unlinked Thrift clients.
David Reiss [Thu, 4 Jun 2009 02:01:24 +0000 (02:01 +0000)] 
THRIFT-211. erlang: Support unlinked Thrift clients.

- Create a thrift_client:start function that accepts client options.
- Make start_link a wrapper that adds {monitor, link}.
- Add a test to make sure that everything dies or doesn't die as expected.
  (The test has to be run manually.)

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@781634 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-469. cpp: Fix a bug in TimerManager::add
David Reiss [Thu, 4 Jun 2009 00:32:57 +0000 (00:32 +0000)] 
THRIFT-469. cpp: Fix a bug in TimerManager::add

The old code didn't notify waiters when the inserted task's timeout
was less than the current timeout because it didn't check the task map
to find the lowest timeout until after the new task was inserted.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@781630 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-466. cpp: Make the concurrency library test more thorough
David Reiss [Thu, 4 Jun 2009 00:32:54 +0000 (00:32 +0000)] 
THRIFT-466. cpp: Make the concurrency library test more thorough

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@781629 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-465. cpp: Fix some STL misuse in the concurrency library test
David Reiss [Thu, 4 Jun 2009 00:32:50 +0000 (00:32 +0000)] 
THRIFT-465. cpp: Fix some STL misuse in the concurrency library test

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@781628 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-464. cpp: Fix some STL misuse in the concurrency library
David Reiss [Thu, 4 Jun 2009 00:32:47 +0000 (00:32 +0000)] 
THRIFT-464. cpp: Fix some STL misuse in the concurrency library

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@781627 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-497. cpp: Fix TSocket::read and peek on Max OS
David Reiss [Thu, 4 Jun 2009 00:10:50 +0000 (00:10 +0000)] 
THRIFT-497. cpp: Fix TSocket::read and peek on Max OS

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@781626 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTHRIFT-511. rb: Better performing hash method for generated structs
Bryan Duxbury [Fri, 29 May 2009 20:18:58 +0000 (20:18 +0000)] 
THRIFT-511. rb: Better performing hash method for generated structs

This patch uses a hash function that takes into account the hashes of struct elements, instead of just returning 0. This make hashes of Thrift structs O(1) instead of O(n).

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@780094 13f79535-47bb-0310-9956-ffa450edef68