Aditya Agarwal [Wed, 7 Feb 2007 03:54:18 +0000 (03:54 +0000)]
-- Servers should not crash on accept.
Summary:
- Continue running if there is an accept issue
Reviewed By: slee
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664988
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 7 Feb 2007 02:40:59 +0000 (02:40 +0000)]
Thrift supports the "senum" type now
Summary: Enumerated lists of strings, enforced only in XSD
Reviewed By: xsd
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664987
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Wed, 7 Feb 2007 02:38:54 +0000 (02:38 +0000)]
-- Remove reference to TBufferedRouter.h/cpp in Makefile
Reviewed By: slee
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664986
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Wed, 7 Feb 2007 02:36:56 +0000 (02:36 +0000)]
-- typo in TSocket
Reviewed By: slee
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664985
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 7 Feb 2007 01:20:08 +0000 (01:20 +0000)]
xsd_attrs are a FieldList now, so you can have multiple of them and they are typed
Reviewed By: xsd
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664984
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 7 Feb 2007 00:54:49 +0000 (00:54 +0000)]
Thrift code-gen optimizations to use raw pointers where possible
Reviewed By: aditya
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664983
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 7 Feb 2007 00:54:17 +0000 (00:54 +0000)]
Protocol should hang onto shared pointer for protection but always use underlying raw pointer
Reviewed By: aditya
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664982
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Tue, 6 Feb 2007 21:03:18 +0000 (21:03 +0000)]
Thrift support for the xsd_nillable attribute
Reviewed By: dave
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664981
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Tue, 6 Feb 2007 07:11:23 +0000 (07:11 +0000)]
NAmespace PHP exceptions in catch block properly and add getName() method to generated structs
Reviewed By: ari
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664980
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Tue, 6 Feb 2007 03:25:13 +0000 (03:25 +0000)]
-- TBufferedRouterTransport being renamed to TPipedTransport
Summary:
- TBufferedRouterTransport is the most nonsensical name I have ever
heard of
Reviewed By: slee
Test Plan: it compiles
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664979
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Tue, 6 Feb 2007 02:51:15 +0000 (02:51 +0000)]
-- Protocol and transport factories now wrap around a single protocol/transport
Summary:
- This is an analagous to the C++ change made in r31441
Reviewed By: slee
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664978
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Tue, 6 Feb 2007 02:50:56 +0000 (02:50 +0000)]
-- Protocol and transport factories now wrap around a single protocol/transport
Summary:
- This is an analagous to the C++ change made in r31441
Reviewed By: slee
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664977
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Tue, 6 Feb 2007 01:26:12 +0000 (01:26 +0000)]
-- Allow specification of socket timeouts in thrift python socket code
Reviewed By: slee
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664976
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Tue, 6 Feb 2007 01:14:33 +0000 (01:14 +0000)]
-- Protocol and transport factories now wrap around a single protocol/transport
Summary:
- This is an analagous to the C++ change made in r31441
Reviewed By: cheever, mcslee
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664975
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Mon, 5 Feb 2007 21:52:08 +0000 (21:52 +0000)]
Adding XSD attribute support
Reviewed By: dave
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664974
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Mon, 5 Feb 2007 21:47:03 +0000 (21:47 +0000)]
svn adding t_doc.h
Summary: charlie you missed this one!
Reviewed By: cheever
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664973
13f79535-47bb-0310-9956-
ffa450edef68
Martin Kraemer [Mon, 5 Feb 2007 21:40:38 +0000 (21:40 +0000)]
Thrift: Supported for file descriptor == 0 and cleanup error output
Summary:
Thrift improperly initialized file descriptors to zero and treated 0 and an invalid value. 0 is a valid file descriptor. Also, commented out error message on client disconnect for TThreadPoolServer
Reviewed By: Marc & Karl
Revert Plan: revertible
Notes:
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664972
13f79535-47bb-0310-9956-
ffa450edef68
Martin Kraemer [Mon, 5 Feb 2007 20:58:41 +0000 (20:58 +0000)]
Thrift: Exception message is protected and accessible to derived classes.
Summary:
Exception message is protected and accessible to derived classes.
Reviewed By: Karl
Revert Plan: revertible
Notes:
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664971
13f79535-47bb-0310-9956-
ffa450edef68
ccheever [Mon, 5 Feb 2007 20:33:11 +0000 (20:33 +0000)]
adding documentation syntax to thrift
see DocTest.thrift for examples.
todo: integrate parsed documentation into code generation
review: marc k, mcslee
test plan: DocTest.thrift
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664970
13f79535-47bb-0310-9956-
ffa450edef68
Martin Kraemer [Sat, 3 Feb 2007 01:59:12 +0000 (01:59 +0000)]
Thrift fixes for Exceptions and TServerSocket
Summary:
TServerSocket detected file des. 0 as an invalid file des. This has been fixed.
Reviewed By: Steve
Revert Plan: Revertible
Notes:
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664969
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Fri, 2 Feb 2007 00:09:51 +0000 (00:09 +0000)]
TFileTransport %lu => %u
Summary: compiler warnings are lame
Reviewed By: aditya
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664968
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 1 Feb 2007 23:05:38 +0000 (23:05 +0000)]
Prevent direct instantation of ThreadManager
Reviewed By: marc
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664967
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 1 Feb 2007 22:55:30 +0000 (22:55 +0000)]
Bring C++ thrift stress test up to date with new constructs
Reviewed By: marc
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664966
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 1 Feb 2007 22:55:00 +0000 (22:55 +0000)]
Adding threaded server to Thrift
Summary: Spawns a new thread for each client connection
Reviewed By: marc
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664965
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 1 Feb 2007 21:39:50 +0000 (21:39 +0000)]
Fix bufferedroutertransport overflow bugs
Reviewed By: aditya
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664964
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 1 Feb 2007 05:26:18 +0000 (05:26 +0000)]
Default values and nullification for thrift code
Summary: All things are null now, unless you specify a default value!
Reviewed By: marc
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664963
13f79535-47bb-0310-9956-
ffa450edef68
dave [Thu, 1 Feb 2007 00:17:28 +0000 (00:17 +0000)]
Thrift: Fix xsd:sequence and xsd:all minOccurs/maxOccurs generation
The minOccurs and maxOccurs attributes should appear on the elements, rather than the containers.
for a thrift struct, we produce:
<sequence>
<element name="some_element"> <!-- max is implicitly 1 -->
<element name="some_optional_element" minOccurs="0"> <!-- max is
implicitly 1 -->
...
for a thrift list, we produce
<sequence>
<element name="the_list_element" minOccurs="0" maxOccurs="unbounded">
</sequence>
for a thrift struct tagged with xsd_all, we produce
<all>
<element name="some_element" minOccurs="0"/> <!-- max is implicitly 1
-->
</all>
Reviewed By: mcslee
Test Plan: sandbox
Revert Plan: revertible
Notes:
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664962
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 31 Jan 2007 08:31:29 +0000 (08:31 +0000)]
Fix for TBufferedTransport double-buffer-size strings
Reviewed By: aditya
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664961
13f79535-47bb-0310-9956-
ffa450edef68
dave [Wed, 31 Jan 2007 02:49:01 +0000 (02:49 +0000)]
Thrift: Finish namespace generation from xsd_namespace command
In .thrift file:
xsd_namespace "http://api.facebook.com/v1"
Turns up in the xsd output as:
<xsd:schema xmlns:xsd="http://www.w3.org/2001/XMLSchema"
targetNamespace="http://api.facebook.com/v1"
xmlns="http://api.facebook.com/v1"
elementFormDefault="qualified">
to properly accommodate our generated xml
Thank you, Slee.
Reviewed By: mcslee
Test Plan: sandbox
Revert Plan: revertible
Notes:
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664960
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 31 Jan 2007 02:08:30 +0000 (02:08 +0000)]
xsd_namespace keyword for thrift
Summary: So you can Spaceify the Shiznits
Reviewed By: fett
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664959
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Tue, 30 Jan 2007 19:52:05 +0000 (19:52 +0000)]
Move var declarations out of switch blocks in Thrift
Summary: Strict G++ compliance
Reviewed By: fett
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664958
13f79535-47bb-0310-9956-
ffa450edef68
dave [Tue, 30 Jan 2007 19:50:30 +0000 (19:50 +0000)]
Thrift: Small changes to support XSD generation
xs:restriction -> xsd:restriction
minoccurs -> minOccurs
Reviewed By: marc
Test Plan: sandbox
Revert Plan: revertible
Notes:
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664957
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Mon, 29 Jan 2007 17:58:54 +0000 (17:58 +0000)]
Thrift gen'd code now checks for field ID AND type matches
Summary: Will call skip() even if FID matches when there is an invalid field type identifier
Reviewed By: corson
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664956
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Mon, 29 Jan 2007 17:35:54 +0000 (17:35 +0000)]
Fix HashMap => AbstractMap conversions in Java test thrift code
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664955
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Sat, 27 Jan 2007 01:58:17 +0000 (01:58 +0000)]
Update configure.ac to include compiler/cpp directory
Reviewed By: aditya
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664954
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Sat, 27 Jan 2007 01:44:22 +0000 (01:44 +0000)]
Ruby support for Thrift
Summary: Just client support so far.
Reviewed By: tbr-doug
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664953
13f79535-47bb-0310-9956-
ffa450edef68
Martin Kraemer [Fri, 26 Jan 2007 01:41:03 +0000 (01:41 +0000)]
Thrift: indentation
Summary:
sigh mixed indentation sytyles.
Reviewed By: Slee
Test Plan: Test by building..
Revert Plan: revertible
Notes:
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664952
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 25 Jan 2007 08:14:50 +0000 (08:14 +0000)]
Separate thrift into libthrift and libthriftnb
Summary: libthriftnb is the one that requires libevent. It was really annoying that you always had to put -levent in your link step to build thrift programs when youa re not using any of the c++ nonblocking stuff. This way, if you're using nonblocking you can do that, but the normal case is easier to link.
Reviewed By: makefile
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664951
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 25 Jan 2007 08:01:28 +0000 (08:01 +0000)]
Fix relative paths in test dirs
Reviewed By: makefile
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664950
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 25 Jan 2007 07:58:55 +0000 (07:58 +0000)]
Full automake/autoconf compliance for thrift
Summary: Including the compiler!!!
Reviewed By: automake
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664949
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 25 Jan 2007 06:28:24 +0000 (06:28 +0000)]
Fix bootstrap for the jwang
Summary: SORRY MY HAX)RDS WAS BROKED
Reviewed By: jwang
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664948
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Thu, 25 Jan 2007 03:27:43 +0000 (03:27 +0000)]
-- ThriftLogfile is finally done.
Summary:
- Everything seems to be working well..
Reviewed By: tbr - slee
Test Plan: Tested using search
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664947
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 25 Jan 2007 02:10:07 +0000 (02:10 +0000)]
Fix Makefile to use thrifty.yy and thriftl.ll
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664946
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 25 Jan 2007 02:07:22 +0000 (02:07 +0000)]
Rename some thrif tcompiler files
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664945
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 24 Jan 2007 23:42:12 +0000 (23:42 +0000)]
Add some smaller test cases and fix new single protocol/transport C++ test
Reviewed By: aditya
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664944
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Wed, 24 Jan 2007 23:39:10 +0000 (23:39 +0000)]
-- Error recovery code for thrift logfile
Summary:
- perform some basic corruption checks:
1) Event larger than chunk
2) Event larger than specified max
3) Event crossing chunk boundary etc.
- If error encountered, then try to perform some recovery
Reviewed By: Slee
Test Plan: Going to test now...need to check in because of compile issues
Notes:
- These checks take care of the case when there is a dirty read from the filesystem (which
we have encountered with the netapps). The recovery involves trying to perform the read
again from ths FS and if that fails skipping the chunk altogether.
Keep in mind that this might only be useful for idempotent systems (e.g. search redolog).
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664943
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 24 Jan 2007 23:14:30 +0000 (23:14 +0000)]
Thrift socket should not perror in the TRYAGAIN state
Reviewed By: wayne
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664942
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 24 Jan 2007 22:57:20 +0000 (22:57 +0000)]
No more getInputTransport vs getOutputTransport in protocols
Summary: It is just getTransport ow
Reviewed By: aditya
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664941
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Wed, 24 Jan 2007 22:53:54 +0000 (22:53 +0000)]
-- Change concept of protocol and transport factory
Summary:
- Transport factories now wrap around one transport
- Protocol factories now wrap around one transport (as opposed to a pair of input/output
transports)
- TServer now takes input/output transport and protocol factories
The motivation for this change is that you could concievably want to use a different protocol or
transport for input and output. An example is that incoming data is encoded using binary protocol
but outgoing data is encrypted XML (with encryption being done on the transport level).
This change should be mostly backwards compatible because the TServer classes have constructors
that take a transport factory and use that for both the input and transport factories. The only
change might be for anyone who is using the C++ client code directly i.e. instantiating
TBinaryProtocol() directly because the constructor now only accepts one transport.
Reviewed By: Slee
Test Plan: Everything compiles (for both thrift and search).
Notes:
I am going to make the same changes in all the supported languages after this...
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664940
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 24 Jan 2007 22:53:07 +0000 (22:53 +0000)]
Generate pargs an presult helpers in C++ to be more efficient in thrift
Summary: Copy construction is the pits. Avoid it at all costs.
Reviewed By: aditya
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664939
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 24 Jan 2007 19:43:06 +0000 (19:43 +0000)]
Fix C++ Thrift test code to work with new gen'd code interface
Reviewed By: tbr-aditya
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664938
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 24 Jan 2007 19:41:57 +0000 (19:41 +0000)]
Nonblockingserver constructor that uses binary protocol factory by default
Reviewed By: tbr-aditya
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664937
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Wed, 24 Jan 2007 02:24:35 +0000 (02:24 +0000)]
-- thrift logfile fixes
Summary:
-- numChunks was broken and that was causing a lot of strange downstream behaviour
Reviewed By: tbr slee
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664936
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Tue, 23 Jan 2007 23:22:35 +0000 (23:22 +0000)]
No need to generate private __construct() function if the class is already final
Reviewed By: lucas
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664935
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Fri, 19 Jan 2007 23:49:00 +0000 (23:49 +0000)]
Use proper name for catching exceptions
Reviewed By: tbr-dave
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664934
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Fri, 19 Jan 2007 22:12:10 +0000 (22:12 +0000)]
Thrift XSD generator populates PHP globals with type names for typedeffed stuffs
Reviewed By: dave
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664933
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Fri, 19 Jan 2007 20:09:51 +0000 (20:09 +0000)]
Allow field elements to be optional in thrift with xsd_optional keyword
Reviewed By: tbr-dave
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664932
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Fri, 19 Jan 2007 19:14:36 +0000 (19:14 +0000)]
Add comma-separated list of type "slist" to thrift
Summary: Useful for API arguments
Reviewed By: tbr-dave
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664931
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Fri, 19 Jan 2007 02:02:12 +0000 (02:02 +0000)]
-- Nonblocking server changes to allow logging
Summary:
-- the constructor needs to accept a transport factory
-- TConnection close() needs to close factor generated transports
Reviewed By: Mark Slee
Test Plan: Tested with search redologger
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664930
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Fri, 19 Jan 2007 00:17:02 +0000 (00:17 +0000)]
Add xsd_all keyword to Thrift
Summary: Makes a struct an xsd_all instead of a sequence
Reviewed By: dave
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664929
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 18 Jan 2007 22:59:59 +0000 (22:59 +0000)]
Thrift now generates XSD files
Summary: Are you fucking kidding me? This shit is robust.
Reviewed By: fetter-tbr-d00d
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664928
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 18 Jan 2007 20:00:11 +0000 (20:00 +0000)]
Resolve typedefs in php generation
Reviewed By: xsd
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664927
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 18 Jan 2007 18:35:26 +0000 (18:35 +0000)]
Remove py compiler from thrift repo
Summary: This keeps confusing people when they try to do make and make install, we always have it around in the svn repo, so we can take it out of current trunk.
Reviewed By: martin
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664926
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 18 Jan 2007 06:54:43 +0000 (06:54 +0000)]
Fix changing struct name bug on C++ generation
Reviewed By: aditya
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664925
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Thu, 18 Jan 2007 06:20:24 +0000 (06:20 +0000)]
-- additions to ThriftLogfile
Summary:
-- fixed peek() in TBufferedRouterTransport.cpp
-- Added processChunk() to ThriftLogfile
Reviewed By: Slee
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664924
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 18 Jan 2007 02:35:27 +0000 (02:35 +0000)]
Do not generate write code for null fields in Java
Summary: It will make null pointer exceptions!
Reviewed By: martin, alex
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664923
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 18 Jan 2007 01:16:51 +0000 (01:16 +0000)]
Add mkdir for bin in thrift compiler
Reviewed By: dcorson
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664922
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 17 Jan 2007 19:19:21 +0000 (19:19 +0000)]
Fix bugs with php_namespace keyword in thrift
Reviewed By: aditya
line, and those below, will be ignored--
M t_php_generator.cc
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664921
13f79535-47bb-0310-9956-
ffa450edef68
Karl Lehenbauer [Wed, 17 Jan 2007 18:56:10 +0000 (18:56 +0000)]
Fix identifier typo in Thrift error message.
Trac Bug: #
Reviewed By:
Test Plan:
The correct error message appears when a PHP Thrift client can't
connect to a server. Set that up, and try and get the error message:
[Wed Jan 17 10:41:41 2007] [error] TSocketPool: retryInterval (60) has
passed for host dev007:8188
...then you're good. If you get something about a undefined property,
then this fix didn't work.
Revert Plan: Revertible
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664920
13f79535-47bb-0310-9956-
ffa450edef68
Marc Slemko [Wed, 17 Jan 2007 08:32:16 +0000 (08:32 +0000)]
Added ax_event_base.m4 to find and configure libevent
Modified configure.ac to pull in AX_EVENT_BASE
Modified Makefile.am to take EVENT settings from automake.
Reviewed by dcorson
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664919
13f79535-47bb-0310-9956-
ffa450edef68
Marc Slemko [Wed, 17 Jan 2007 07:59:38 +0000 (07:59 +0000)]
Make boost base default to yes to make sure we don't get through configure without boost
Fixed configure.ac to add a few missing functions and headers
Reviewed by dcorson
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664918
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Tue, 16 Jan 2007 23:53:53 +0000 (23:53 +0000)]
Resolve complex typedefs in Thrift
Summary: For function returns
Reviewed By: aditya
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664917
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Tue, 16 Jan 2007 23:00:31 +0000 (23:00 +0000)]
Thrift should generate C++ enums first before typdefs
Summary: In case you want to typedef an enum
Reviewed By: aditya
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664916
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Tue, 16 Jan 2007 22:48:22 +0000 (22:48 +0000)]
Prefix generated _args and _result helper classes with service name
Summary: To avoid conflicts when you have two services with the same name inside one .thrift file
Reviewed By: aditya
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664915
13f79535-47bb-0310-9956-
ffa450edef68
Marc Slemko [Tue, 16 Jan 2007 22:20:19 +0000 (22:20 +0000)]
Added autoconf/automake glue to run lib/py/setup.py as part of make install
Reviewed by mslee
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664914
13f79535-47bb-0310-9956-
ffa450edef68
robert [Mon, 15 Jan 2007 23:53:25 +0000 (23:53 +0000)]
Fixed some warnings, changed TSocketPool to inherit debugHandler from TSocket
reviewed: mcslee
revert: yes
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664913
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Mon, 15 Jan 2007 23:14:58 +0000 (23:14 +0000)]
-- Allow manual setting of host and port in TSocket
Summary:
-- required for TSocketPool equivalent functionality
Reviewed By: slee
Notes:
-- Todo is to replicate TSocketPool.php in C++
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664912
13f79535-47bb-0310-9956-
ffa450edef68
robert [Mon, 15 Jan 2007 18:29:51 +0000 (18:29 +0000)]
Added open, close, and isOpen to TFramedTransport
reviewed: mcslee
revert: yes
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664911
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Fri, 12 Jan 2007 21:44:14 +0000 (21:44 +0000)]
Thrift C++ code generator returns complex types by reference
Summary: Efficiency, Yo.
Reviewed By: aditya
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664910
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Fri, 12 Jan 2007 02:10:16 +0000 (02:10 +0000)]
Committing code gen changes for const ref args to functions in Thrift
Reviewed By: aditya
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664909
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Fri, 12 Jan 2007 01:06:24 +0000 (01:06 +0000)]
Add PHP namespacing support to Thrift
Summary: "php_namespace Whoa" at the top of your Thrift file, then all your defined class names start with "Whoa_"
Reviewed By: aditya
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664908
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Fri, 12 Jan 2007 00:23:26 +0000 (00:23 +0000)]
Disallow keywords in Thrift files
Summary: Or else you are bound to get shitty errors in some generated languages.. They're not all covered here, but a lot of them are.
Reviewed By: dougb, bobby
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664907
13f79535-47bb-0310-9956-
ffa450edef68
Adam Nichols [Thu, 11 Jan 2007 21:25:29 +0000 (21:25 +0000)]
minor syntax change in thrift php library, reviewed by slee, revertible
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664906
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Thu, 11 Jan 2007 01:26:00 +0000 (01:26 +0000)]
Fix call_user_func bug on debugHandler_
Reviewed By: lucas
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664905
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Fri, 5 Jan 2007 01:09:04 +0000 (01:09 +0000)]
Example syntax for constants in Thrift
Reviewed By: martin
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664904
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 3 Jan 2007 19:23:50 +0000 (19:23 +0000)]
Add options to thrift transport classes for custom error handlers
Summary: So we can pass debug_rlog (facebook custom) in as a handler for errors to thrift (generic open source)
Reviewed By: lucas
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664903
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 3 Jan 2007 18:45:04 +0000 (18:45 +0000)]
Fix typo class variable bug in TSocketPool
Reviewed By: corson
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664902
13f79535-47bb-0310-9956-
ffa450edef68
putnam [Fri, 22 Dec 2006 10:35:12 +0000 (10:35 +0000)]
Fixed typo in Thrift README
Summary:
locacation? COME ON GUYS.
Review:
peter
Test plan:
I read it, then re-read it, then re-re-read it.
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664901
13f79535-47bb-0310-9956-
ffa450edef68
robert [Wed, 20 Dec 2006 19:25:38 +0000 (19:25 +0000)]
fixed a problem with read buffer resizing in TNonblockingServer
reviewed: mcslee
revert: yes
test: send a large message to a nonblocking server
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664900
13f79535-47bb-0310-9956-
ffa450edef68
robert [Tue, 19 Dec 2006 22:27:54 +0000 (22:27 +0000)]
fixed a bug in TFramedTransport where it was checking a size for nonzero after byte swapping it.
reviewed: mcslee
revert: yes
test: run a C++ client and server with framed transport
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664899
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Sat, 16 Dec 2006 01:06:49 +0000 (01:06 +0000)]
message_ in TException can't be const or subclasses break
Reviewed By: yishan
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664898
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Sat, 16 Dec 2006 00:59:29 +0000 (00:59 +0000)]
Fix exceptions throw() and virtual destructor
Reviewed By: yishan
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664897
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Fri, 15 Dec 2006 19:07:04 +0000 (19:07 +0000)]
All user-defined thrift exceptions inherit from TException
Summary: So you can catch more effectively
Reviewed By: tbr-karl
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664896
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 13 Dec 2006 01:54:56 +0000 (01:54 +0000)]
Another AccessNull bug fix in Thrift
Reviewed By: yhishan
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664895
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 13 Dec 2006 01:45:26 +0000 (01:45 +0000)]
Fix c++ Null inheritance issue
Reviewed By: yishan
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664894
13f79535-47bb-0310-9956-
ffa450edef68
Mark Slee [Wed, 13 Dec 2006 01:07:33 +0000 (01:07 +0000)]
Take out timestamps from generated files
Summary: File system does this for you.
Reviewed By: martin, yishan
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664893
13f79535-47bb-0310-9956-
ffa450edef68
Martin Kraemer [Sat, 9 Dec 2006 01:57:58 +0000 (01:57 +0000)]
Thrift TException Cleanup
Summary:
Destructors should be virtual or declared protected.
Reviewed By: mcslee
Revert Plan: revertible
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664892
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Sat, 9 Dec 2006 00:58:15 +0000 (00:58 +0000)]
-- Rename TBufferedFileWriter.h/cpp to TFileTransport.h/cpp
Summary:
-- Thrift logfile is now officially in action!
Reviewed By: Mark Slee
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664891
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Sat, 9 Dec 2006 00:47:03 +0000 (00:47 +0000)]
-- Check all system call return values
Summary:
-- Throw TTransportException if a system call fails
Reviewed By: Mark Slee
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664890
13f79535-47bb-0310-9956-
ffa450edef68
Aditya Agarwal [Fri, 8 Dec 2006 23:52:57 +0000 (23:52 +0000)]
-- TFileTransport (Thrift Logfile)
Summary:
-- TBufferedFileWriter.h/cpp will be renamed to TFileTransport.h/cpp in the next commit.
-- TFileTransport is essentially reading and writing thrift calls to/from a file instead of a
socket.
-- The code/design is somewhat similar to pillar_logfile but there are some significant changes.
todo:
-- still need to do error correction/detection
Reviewed By: Mark Slee
Test Plan:
-- Wrote test in thrift/test/cpp/src/main.cpp that appends to a file and replays requests
Notes:
It's finally time to port search over to Thrift
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664889
13f79535-47bb-0310-9956-
ffa450edef68