From 2b386c50d7cf649c928a792bed73bcb938f8501f Mon Sep 17 00:00:00 2001 From: David Reiss Date: Thu, 27 Mar 2008 21:42:23 +0000 Subject: [PATCH] Make the Perl generator dynamic. - Modify the Perl generator constructor to fit the new generic interface. - Register the Perl genrator with the central registry. - Deprecate the old way of invoking the Perl generator. - main.cc no longer includes t_pl_generator.h. git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665621 13f79535-47bb-0310-9956-ffa450edef68 --- compiler/cpp/src/generate/t_perl_generator.cc | 3 +++ compiler/cpp/src/generate/t_perl_generator.h | 9 ++++++--- compiler/cpp/src/main.cc | 15 +++++---------- 3 files changed, 14 insertions(+), 13 deletions(-) diff --git a/compiler/cpp/src/generate/t_perl_generator.cc b/compiler/cpp/src/generate/t_perl_generator.cc index 0b16212e..226144f2 100644 --- a/compiler/cpp/src/generate/t_perl_generator.cc +++ b/compiler/cpp/src/generate/t_perl_generator.cc @@ -1595,3 +1595,6 @@ string t_perl_generator ::type_to_enum(t_type* type) { throw "INVALID TYPE IN type_to_enum: " + type->get_name(); } + + +THRIFT_REGISTER_GENERATOR(perl, "Perl", ""); diff --git a/compiler/cpp/src/generate/t_perl_generator.h b/compiler/cpp/src/generate/t_perl_generator.h index fc107047..f05321c7 100644 --- a/compiler/cpp/src/generate/t_perl_generator.h +++ b/compiler/cpp/src/generate/t_perl_generator.h @@ -22,9 +22,12 @@ */ class t_perl_generator : public t_oop_generator { public: - t_perl_generator(t_program* program) : - t_oop_generator(program) { - + t_perl_generator( + t_program* program, + const std::map& parsed_options, + const std::string& option_string) + : t_oop_generator(program) + { out_dir_base_ = "gen-perl"; } diff --git a/compiler/cpp/src/main.cc b/compiler/cpp/src/main.cc index 9e94482c..abd6a36f 100644 --- a/compiler/cpp/src/main.cc +++ b/compiler/cpp/src/main.cc @@ -37,7 +37,6 @@ #include "parse/t_scope.h" #include "generate/t_php_generator.h" #include "generate/t_xsd_generator.h" -#include "generate/t_perl_generator.h" #include "generate/t_erl_generator.h" using namespace std; @@ -601,7 +600,6 @@ void usage() { fprintf(stderr, " -phpa Generate PHP with autoload (with -php)\n"); fprintf(stderr, " -phpo Generate PHP with object oriented subclasses (with -php)\n"); fprintf(stderr, " -xsd Generate XSD output files\n"); - fprintf(stderr, " -perl Generate Perl output files\n"); fprintf(stderr, " -erl Generate Erlang output files\n"); fprintf(stderr, " -o dir Set the output directory for gen-* packages\n"); fprintf(stderr, " (default: current directory)\n"); @@ -872,13 +870,6 @@ void generate(t_program* program, const vector& generator_strings) { delete xsd; } - if (gen_perl) { - pverbose("Generating PERL\n"); - t_perl_generator* perl = new t_perl_generator(program); - perl->generate_program(); - delete perl; - } - if (gen_erl) { pverbose("Generating Erlang\n"); t_erl_generator* erl = new t_erl_generator(program); @@ -1091,6 +1082,10 @@ int main(int argc, char** argv) { pwarning(1, "-rb is deprecated. Use --gen rb"); generator_strings.push_back("rb"); } + if (gen_perl) { + pwarning(1, "-perl is deprecated. Use --gen perl"); + generator_strings.push_back("perl"); + } if (gen_cocoa) { pwarning(1, "-cocoa is deprecated. Use --gen cocoa"); generator_strings.push_back("cocoa"); @@ -1109,7 +1104,7 @@ int main(int argc, char** argv) { } // You gotta generate something! - if (!gen_php && !gen_phpi && !gen_xsd && !gen_perl && !gen_erl && generator_strings.empty()) { + if (!gen_php && !gen_phpi && !gen_xsd && !gen_erl && generator_strings.empty()) { fprintf(stderr, "!!! No output language(s) specified\n\n"); usage(); } -- 2.17.1