From 2c9824c5bdd3d9aefa0c1edb4538c996e4d513dd Mon Sep 17 00:00:00 2001 From: David Reiss Date: Sun, 2 Mar 2008 00:20:47 +0000 Subject: [PATCH] Fix potential out of bounds read issue with getTypeIDForTypeName(). Make sure type name is at least 2 characters long. git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665536 13f79535-47bb-0310-9956-ffa450edef68 --- lib/cpp/src/protocol/TJSONProtocol.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/cpp/src/protocol/TJSONProtocol.cpp b/lib/cpp/src/protocol/TJSONProtocol.cpp index 39eb1290..d2d56c18 100644 --- a/lib/cpp/src/protocol/TJSONProtocol.cpp +++ b/lib/cpp/src/protocol/TJSONProtocol.cpp @@ -81,7 +81,7 @@ static const std::string &getTypeNameForTypeID(TType typeID) { static TType getTypeIDForTypeName(const std::string &name) { TType result = T_STOP; // Sentinel value - if (name.length() > 0) { + if (name.length() > 1) { switch (name[0]) { case 'd': result = T_DOUBLE; -- 2.17.1