From 9957d3022e69e8e9b8921e297171f8903017694d Mon Sep 17 00:00:00 2001 From: Jens Geyer Date: Mon, 4 Nov 2013 22:18:40 +0100 Subject: [PATCH] THRIFT-2158 Compact, JSON, and SimpleJSON protocols are not working correctly Patch: Jens Geyer --- lib/go/thrift/compact_protocol.go | 3 +-- lib/go/thrift/serializer_test.go | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/go/thrift/compact_protocol.go b/lib/go/thrift/compact_protocol.go index ba5f722f..74d36d00 100644 --- a/lib/go/thrift/compact_protocol.go +++ b/lib/go/thrift/compact_protocol.go @@ -719,8 +719,7 @@ func (p *TCompactProtocol) getTType(t tCompactType) (TType, error) { switch byte(t) & 0x0f { case STOP: return STOP, nil - case COMPACT_BOOLEAN_FALSE: - case COMPACT_BOOLEAN_TRUE: + case COMPACT_BOOLEAN_FALSE, COMPACT_BOOLEAN_TRUE: return BOOL, nil case COMPACT_BYTE: return BYTE, nil diff --git a/lib/go/thrift/serializer_test.go b/lib/go/thrift/serializer_test.go index ca8fb0e4..0f3f7d78 100644 --- a/lib/go/thrift/serializer_test.go +++ b/lib/go/thrift/serializer_test.go @@ -145,7 +145,7 @@ func TestSerializer(t *testing.T) { var protocol_factories map[string]ProtocolFactory protocol_factories = make(map[string]ProtocolFactory) protocol_factories["Binary"] = NewTBinaryProtocolFactoryDefault() -// protocol_factories["Compact"] = NewTCompactProtocolFactory() - not working right now, see THRIFT-2158 + protocol_factories["Compact"] = NewTCompactProtocolFactory() //protocol_factories["SimpleJSON"] = NewTSimpleJSONProtocolFactory() - write only, can't be read back by design protocol_factories["JSON"] = NewTJSONProtocolFactory() -- 2.17.1