From a9387af56ee5dd6fe601ac59f62a553b64e0eb49 Mon Sep 17 00:00:00 2001 From: Mark Slee Date: Wed, 21 Nov 2007 22:05:50 +0000 Subject: [PATCH] Double-free Cocoa fix: Redux Summary: Need get_true_type to evaluate string status Reviewed By: mcslee Other Notes: Submission from Andrew McGeachie git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665362 13f79535-47bb-0310-9956-ffa450edef68 --- compiler/cpp/src/generate/t_cocoa_generator.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compiler/cpp/src/generate/t_cocoa_generator.cc b/compiler/cpp/src/generate/t_cocoa_generator.cc index 9ade7fdb..fc853658 100644 --- a/compiler/cpp/src/generate/t_cocoa_generator.cc +++ b/compiler/cpp/src/generate/t_cocoa_generator.cc @@ -486,7 +486,7 @@ void t_cocoa_generator::generate_cocoa_struct_reader(ofstream& out, // is now retaining it if (type_can_be_null((*f_iter)->get_type())) { // deserialized strings are autorelease, so don't release them - if (!((*f_iter)->get_type()->is_string())) { + if (!(get_true_type((*f_iter)->get_type())->is_string())) { indent(out) << "[fieldValue release];" << endl; } } -- 2.17.1