From d081dd668b4c8d11de68d4e2047b3e54cfc21ec3 Mon Sep 17 00:00:00 2001 From: Bryan Duxbury Date: Wed, 23 Mar 2011 18:05:27 +0000 Subject: [PATCH] THRIFT-1106. cpp: C++ code TAsyncProtocolProcessor.h & TAsyncBufferProcessor.h dont have virtual functions but no virtual destructor. Causes warnings on -Wall Patch: Fasih git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1084656 13f79535-47bb-0310-9956-ffa450edef68 --- lib/cpp/src/async/TAsyncBufferProcessor.h | 1 + lib/cpp/src/async/TAsyncProtocolProcessor.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/lib/cpp/src/async/TAsyncBufferProcessor.h b/lib/cpp/src/async/TAsyncBufferProcessor.h index 06a503e5..bfaf3230 100644 --- a/lib/cpp/src/async/TAsyncBufferProcessor.h +++ b/lib/cpp/src/async/TAsyncBufferProcessor.h @@ -38,6 +38,7 @@ class TAsyncBufferProcessor { std::tr1::function _return, boost::shared_ptr ibuf, boost::shared_ptr obuf) = 0; + virtual ~TAsyncBufferProcessor() {} }; }}} // apache::thrift::async diff --git a/lib/cpp/src/async/TAsyncProtocolProcessor.h b/lib/cpp/src/async/TAsyncProtocolProcessor.h index 7ec718bd..647bbb69 100644 --- a/lib/cpp/src/async/TAsyncProtocolProcessor.h +++ b/lib/cpp/src/async/TAsyncProtocolProcessor.h @@ -40,6 +40,8 @@ class TAsyncProtocolProcessor : public TAsyncBufferProcessor { boost::shared_ptr ibuf, boost::shared_ptr obuf); + virtual ~TAsyncProtocolProcessor() {} + private: static void finish( std::tr1::function _return, -- 2.17.1