From d28d4d578470233e384ae6012d0ecfa5a8f3deba Mon Sep 17 00:00:00 2001 From: Henrique Date: Thu, 16 May 2013 21:19:50 +0200 Subject: [PATCH] THRIFT-1907 Compiling namespace and sub-namespace directives for unrecognized generators should only be a warning Patch: Andrew Cox --- compiler/cpp/src/parse/t_program.h | 3 ++- test/ThriftTest.thrift | 8 +++++++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/compiler/cpp/src/parse/t_program.h b/compiler/cpp/src/parse/t_program.h index 12fcf0e3..dfd9d43d 100644 --- a/compiler/cpp/src/parse/t_program.h +++ b/compiler/cpp/src/parse/t_program.h @@ -188,7 +188,8 @@ class t_program : public t_doc { if (sub_index != std::string::npos) { std::string sub_namespace = language.substr(sub_index+1); if ( ! it->second->is_valid_namespace(sub_namespace)) { - throw base_language + " generator does not accept '" + sub_namespace + "' as sub-namespace!"; + std::string warning = base_language + " generator does not accept '" + sub_namespace + "' as sub-namespace!"; + pwarning(1, warning.c_str()); } } } diff --git a/test/ThriftTest.thrift b/test/ThriftTest.thrift index 2be53fa2..be000b6a 100644 --- a/test/ThriftTest.thrift +++ b/test/ThriftTest.thrift @@ -35,6 +35,12 @@ namespace go ThriftTest namespace php ThriftTest namespace delphi Thrift.Test namespace cocoa ThriftTest + +// Presence of namespaces and sub-namespaces for which there is +// no generator should compile with warnings only +namespace noexist ThriftTest +namespace cpp.noexist ThriftTest + namespace * thrift.test /** @@ -368,4 +374,4 @@ struct StructA { struct StructB { 1: optional StructA aa; 2: required StructA ab; -} \ No newline at end of file +} -- 2.17.1