From d4a0b27ad0e57f0cd681f3334847492decf35c2e Mon Sep 17 00:00:00 2001 From: Jens Geyer Date: Wed, 21 Aug 2013 23:55:29 +0200 Subject: [PATCH] THRIFT-1351 Compiler does not care about binary strings Patch: Wade Simmons & Jens Geyer --- compiler/cpp/src/generate/t_js_generator.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/compiler/cpp/src/generate/t_js_generator.cc b/compiler/cpp/src/generate/t_js_generator.cc index e27f5dea..9f7fa041 100644 --- a/compiler/cpp/src/generate/t_js_generator.cc +++ b/compiler/cpp/src/generate/t_js_generator.cc @@ -1259,7 +1259,7 @@ void t_js_generator::generate_deserialize_field(ofstream &out, name; break; case t_base_type::TYPE_STRING: - out << "readString()"; + out << (((t_base_type*)type)->is_binary() ? "readBinary()" : "readString()"); break; case t_base_type::TYPE_BOOL: out << "readBool()"; @@ -1498,7 +1498,7 @@ void t_js_generator::generate_serialize_field(ofstream &out, "compiler error: cannot serialize void field in a struct: " + name; break; case t_base_type::TYPE_STRING: - out << "writeString(" << name << ")"; + out << (((t_base_type*)type)->is_binary() ? "writeBinary(" : "writeString(") << name << ")"; break; case t_base_type::TYPE_BOOL: out << "writeBool(" << name << ")"; -- 2.17.1