From dfffdd8726cbf7b6a309ab354c638ede92d2f215 Mon Sep 17 00:00:00 2001 From: Bryan Duxbury Date: Thu, 11 Aug 2011 18:54:11 +0000 Subject: [PATCH] THRIFT-1205. java: port server unduly fragile with arbitrary input Increase the default max frame size to 16MB. Patch: Ryan King git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1156731 13f79535-47bb-0310-9956-ffa450edef68 --- .../src/org/apache/thrift/transport/TFastFramedTransport.java | 4 ++-- .../src/org/apache/thrift/transport/TFramedTransport.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/java/src/org/apache/thrift/transport/TFastFramedTransport.java b/lib/java/src/org/apache/thrift/transport/TFastFramedTransport.java index 2a1f1dac..e32b7db9 100644 --- a/lib/java/src/org/apache/thrift/transport/TFastFramedTransport.java +++ b/lib/java/src/org/apache/thrift/transport/TFastFramedTransport.java @@ -59,9 +59,9 @@ public class TFastFramedTransport extends TTransport { */ public static final int DEFAULT_BUF_CAPACITY = 1024; /** - * How big is the largest allowable frame? Defaults to Integer.MAX_VALUE. + * How big is the largest allowable frame? Defaults to 16MB. */ - public static final int DEFAULT_MAX_LENGTH = Integer.MAX_VALUE; + public static final int DEFAULT_MAX_LENGTH = 16384000; private final TTransport underlying; private final AutoExpandingBufferWriteTransport writeBuffer; diff --git a/lib/java/src/org/apache/thrift/transport/TFramedTransport.java b/lib/java/src/org/apache/thrift/transport/TFramedTransport.java index eb5b0c2e..c948aa4f 100644 --- a/lib/java/src/org/apache/thrift/transport/TFramedTransport.java +++ b/lib/java/src/org/apache/thrift/transport/TFramedTransport.java @@ -27,7 +27,7 @@ import org.apache.thrift.TByteArrayOutputStream; */ public class TFramedTransport extends TTransport { - protected static final int DEFAULT_MAX_LENGTH = 0x7FFFFFFF; + protected static final int DEFAULT_MAX_LENGTH = 16384000; private int maxLength_; -- 2.17.1