From e02d6118bfe00f74fec801efcb677ef17dfe928e Mon Sep 17 00:00:00 2001 From: Bryan Duxbury Date: Thu, 2 Sep 2010 00:29:08 +0000 Subject: [PATCH] THRIFT-838. cocoa: Generated Cocoa classes have useless @dynamic declarations This patch removes the @dynamic properties. Patch: Kevin Ballard git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@991779 13f79535-47bb-0310-9956-ffa450edef68 --- .../cpp/src/generate/t_cocoa_generator.cc | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/compiler/cpp/src/generate/t_cocoa_generator.cc b/compiler/cpp/src/generate/t_cocoa_generator.cc index 9e24b528..64c29390 100644 --- a/compiler/cpp/src/generate/t_cocoa_generator.cc +++ b/compiler/cpp/src/generate/t_cocoa_generator.cc @@ -179,7 +179,6 @@ class t_cocoa_generator : public t_oop_generator { std::string base_type_name(t_base_type* tbase); std::string declare_field(t_field* tfield); std::string declare_property(t_field* tfield); - std::string dynamic_property(t_field* tfield); std::string function_signature(t_function* tfunction); std::string argument_list(t_struct* tstruct); std::string type_to_enum(t_type* ttype); @@ -717,15 +716,6 @@ void t_cocoa_generator::generate_cocoa_struct_implementation(ofstream &out, const vector& members = tstruct->get_members(); vector::const_iterator m_iter; - // @dynamic property declarations - if (!members.empty()) { - out << "#if TARGET_OS_IPHONE || (MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_5)" << endl; - for (m_iter = members.begin(); m_iter != members.end(); ++m_iter) { - out << indent() << dynamic_property(*m_iter) << endl; - } - out << "#endif" << endl << endl; - } - // initializer with all fields as params if (!members.empty()) { generate_cocoa_struct_initializer_signature(out, tstruct); @@ -2334,15 +2324,6 @@ string t_cocoa_generator::declare_property(t_field* tfield) { return render.str(); } -/** - * Add @dynamic declaration for an Objective-C 2.0 property. - * - * @param tfield The field for which to declare a dynamic property - */ -string t_cocoa_generator::dynamic_property(t_field* tfield) { - return "@dynamic " + tfield->get_name() + ";"; -} - /** * Renders a function signature * -- 2.17.1