From e043a9ec4b91ef5373681e966753d5172d56e79f Mon Sep 17 00:00:00 2001 From: Bryan Duxbury Date: Fri, 22 May 2009 20:17:04 +0000 Subject: [PATCH] THRIFT-516. rb: If TFramedTransport reads a negative frame size, throw a TTransportException descendant instead of the default NegativeArraySizeException Throw a TTransportException when the frame size read from the wire is < 0. git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@777690 13f79535-47bb-0310-9956-ffa450edef68 --- .../src/org/apache/thrift/transport/TFramedTransport.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/java/src/org/apache/thrift/transport/TFramedTransport.java b/lib/java/src/org/apache/thrift/transport/TFramedTransport.java index c83748ad..3600a2b6 100644 --- a/lib/java/src/org/apache/thrift/transport/TFramedTransport.java +++ b/lib/java/src/org/apache/thrift/transport/TFramedTransport.java @@ -96,6 +96,10 @@ public class TFramedTransport extends TTransport { ((i32rd[2] & 0xff) << 8) | ((i32rd[3] & 0xff)); + if (size < 0) { + throw new TTransportException("Read a negative frame size (" + size + ")!"); + } + byte[] buff = new byte[size]; transport_.readAll(buff, 0, size); readBuffer_ = new ByteArrayInputStream(buff); -- 2.17.1