From f33c7c670b189fbb58eb9cb868703ca99a107b7c Mon Sep 17 00:00:00 2001 From: David Reiss Date: Thu, 26 Mar 2009 06:15:26 +0000 Subject: [PATCH] cpp: Eliminate a buffer overflow in the tutorial server Negative numbers can have 11 characters :) git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758529 13f79535-47bb-0310-9956-ffa450edef68 --- tutorial/cpp/CppServer.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tutorial/cpp/CppServer.cpp b/tutorial/cpp/CppServer.cpp index a2c30d2a..044e1d99 100644 --- a/tutorial/cpp/CppServer.cpp +++ b/tutorial/cpp/CppServer.cpp @@ -69,8 +69,8 @@ class CalculatorHandler : public CalculatorIf { SharedStruct ss; ss.key = logid; - char buffer[11]; - sprintf(buffer, "%d", val); + char buffer[12]; + snprintf(buffer, sizeof(buffer), "%d", val); ss.value = buffer; log[logid] = ss; -- 2.17.1