From f845b7d3e097097446067b3a0bc96c6dc85008ca Mon Sep 17 00:00:00 2001 From: Mark Slee Date: Fri, 21 Dec 2007 23:53:10 +0000 Subject: [PATCH] Make base set_name take const std:string& instead of std:string Summary: All the subclasses do that so it causes warnings not to and is dumb because copy constructing std::string is dumb Reviewed By: kholst Test Plan: Generate some codes, compile with -Werror git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665405 13f79535-47bb-0310-9956-ffa450edef68 --- compiler/cpp/src/parse/t_type.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compiler/cpp/src/parse/t_type.h b/compiler/cpp/src/parse/t_type.h index b9da4fd5..bf8d7fa7 100644 --- a/compiler/cpp/src/parse/t_type.h +++ b/compiler/cpp/src/parse/t_type.h @@ -29,7 +29,7 @@ class t_type : public t_doc { public: virtual ~t_type() {} - virtual void set_name(std::string name) { + virtual void set_name(const std::string& name) { name_ = name; } -- 2.17.1