From fbb14ef1b33db23cb0862975af58bbba957d2378 Mon Sep 17 00:00:00 2001 From: David Reiss Date: Tue, 2 Dec 2008 02:32:25 +0000 Subject: [PATCH] THRIFT-214. cpp: Qualify a cast to fix OSX compilation id_t is defined in some OSX header, and the id_t in this function resolved to that one instead of Thread::id_t. This change fully qualifies the type to make sure it resolves properly. Also remove a comment about eliminating the C-style cast, since it is actually quite appropriate in this case. git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@722337 13f79535-47bb-0310-9956-ffa450edef68 --- lib/cpp/src/concurrency/PosixThreadFactory.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/cpp/src/concurrency/PosixThreadFactory.cpp b/lib/cpp/src/concurrency/PosixThreadFactory.cpp index 59953417..001d6ad8 100644 --- a/lib/cpp/src/concurrency/PosixThreadFactory.cpp +++ b/lib/cpp/src/concurrency/PosixThreadFactory.cpp @@ -139,9 +139,8 @@ class PthreadThread: public Thread { } } - id_t getId() { - // TODO(dreiss): Stop using C-style casts. - return (id_t)pthread_; + Thread::id_t getId() { + return (Thread::id_t)pthread_; } shared_ptr runnable() const { return Thread::runnable(); } -- 2.17.1