Fix: "eval set" called in the wrong context.
This is the real fix for the incorrect fix that I reverted in the
previous commit. parse_cmdline was used to DRY up the source, but this
introduced a bug because the "eval set" line changes the positional
parameters semantics, but does it in the wrong context, so the calling
function never receives the changes.
This closes at least the GitHub issues #54 and #86.
diff --git a/git-flow-feature b/git-flow-feature
index b69cc73..226730a 100644
--- a/git-flow-feature
+++ b/git-flow-feature
@@ -170,14 +170,10 @@
fi
}
-parse_cmdline() {
+parse_args() {
# parse options
FLAGS "$@" || exit $?
eval set -- "${FLAGS_ARGV}"
-}
-
-parse_args() {
- parse_cmdline "$@"
# read arguments into global variables
NAME=$1
@@ -185,7 +181,9 @@
}
parse_remote_name() {
- parse_cmdline "$@"
+ # parse options
+ FLAGS "$@" || exit $?
+ eval set -- "${FLAGS_ARGV}"
# read arguments into global variables
REMOTE=$1