THRIFT-1485 Performance: pass large and/or refcounted arguments as "const"
Patch: Jens Geyer
git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1228965 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/lib/delphi/src/Thrift.Transport.pas b/lib/delphi/src/Thrift.Transport.pas
index a460819..f5ccf6e 100644
--- a/lib/delphi/src/Thrift.Transport.pas
+++ b/lib/delphi/src/Thrift.Transport.pas
@@ -145,11 +145,11 @@
ITransportFactory = interface
['{DD809446-000F-49E1-9BFF-E0D0DC76A9D7}']
- function GetTransport( ATrans: ITransport): ITransport;
+ function GetTransport( const ATrans: ITransport): ITransport;
end;
TTransportFactoryImpl = class( TInterfacedObject, ITransportFactory)
- function GetTransport( ATrans: ITransport): ITransport; virtual;
+ function GetTransport( const ATrans: ITransport): ITransport; virtual;
end;
TTcpSocketStreamImpl = class( TThriftStreamImpl )
@@ -165,7 +165,7 @@
function IsOpen: Boolean; override;
function ToArray: TBytes; override;
public
- constructor Create( ATcpClient: TCustomIpClient);
+ constructor Create( const ATcpClient: TCustomIpClient);
end;
IStreamTransport = interface( ITransport )
@@ -194,7 +194,7 @@
procedure Flush; override;
function Read(var buf: TBytes; off: Integer; len: Integer): Integer; override;
procedure Write( const buf: TBytes; off: Integer; len: Integer); override;
- constructor Create( AInputStream : IThriftStream; AOutputStream : IThriftStream);
+ constructor Create( const AInputStream : IThriftStream; const AOutputStream : IThriftStream);
destructor Destroy; override;
end;
@@ -212,7 +212,7 @@
function IsOpen: Boolean; override;
function ToArray: TBytes; override;
public
- constructor Create( AStream: IThriftStream; ABufSize: Integer);
+ constructor Create( const AStream: IThriftStream; ABufSize: Integer);
destructor Destroy; override;
end;
@@ -226,8 +226,8 @@
protected
function AcceptImpl: ITransport; override;
public
- constructor Create( AServer: TTcpServer ); overload;
- constructor Create( AServer: TTcpServer; AClientTimeout: Integer); overload;
+ constructor Create( const AServer: TTcpServer ); overload;
+ constructor Create( const AServer: TTcpServer; AClientTimeout: Integer); overload;
constructor Create( APort: Integer); overload;
constructor Create( APort: Integer; AClientTimeout: Integer); overload;
constructor Create( APort: Integer; AClientTimeout: Integer;
@@ -254,8 +254,8 @@
procedure Close(); override;
function Read(var buf: TBytes; off: Integer; len: Integer): Integer; override;
procedure Write( const buf: TBytes; off: Integer; len: Integer); override;
- constructor Create( ATransport : IStreamTransport ); overload;
- constructor Create( ATransport : IStreamTransport; ABufSize: Integer); overload;
+ constructor Create( const ATransport : IStreamTransport ); overload;
+ constructor Create( const ATransport : IStreamTransport; ABufSize: Integer); overload;
property UnderlyingTransport: ITransport read GetUnderlyingTransport;
property IsOpen: Boolean read GetIsOpen;
end;
@@ -273,7 +273,7 @@
function GetIsOpen: Boolean; override;
public
procedure Open; override;
- constructor Create( AClient : TCustomIpClient); overload;
+ constructor Create( const AClient : TCustomIpClient); overload;
constructor Create( const AHost: string; APort: Integer); overload;
constructor Create( const AHost: string; APort: Integer; ATimeout: Integer); overload;
destructor Destroy; override;
@@ -299,14 +299,14 @@
type
TFactory = class( TTransportFactoryImpl )
public
- function GetTransport( ATrans: ITransport): ITransport; override;
+ function GetTransport( const ATrans: ITransport): ITransport; override;
end;
{$IF CompilerVersion >= 21.0}
class constructor Create;
{$IFEND}
constructor Create; overload;
- constructor Create( ATrans: ITransport); overload;
+ constructor Create( const ATrans: ITransport); overload;
destructor Destroy; override;
procedure Open(); override;
@@ -528,20 +528,20 @@
{ TTransportFactoryImpl }
-function TTransportFactoryImpl.GetTransport(ATrans: ITransport): ITransport;
+function TTransportFactoryImpl.GetTransport( const ATrans: ITransport): ITransport;
begin
Result := ATrans;
end;
{ TServerSocket }
-constructor TServerSocketImpl.Create(AServer: TTcpServer; AClientTimeout: Integer);
+constructor TServerSocketImpl.Create( const AServer: TTcpServer; AClientTimeout: Integer);
begin
FServer := AServer;
FClientTimeout := AClientTimeout;
end;
-constructor TServerSocketImpl.Create(AServer: TTcpServer);
+constructor TServerSocketImpl.Create( const AServer: TTcpServer);
begin
Create( AServer, 0 );
end;
@@ -658,7 +658,7 @@
{ TSocket }
-constructor TSocketImpl.Create(AClient : TCustomIpClient);
+constructor TSocketImpl.Create( const AClient : TCustomIpClient);
var
stream : IThriftStream;
begin
@@ -773,7 +773,7 @@
FBuffer := nil;
end;
-constructor TBufferedStreamImpl.Create(AStream: IThriftStream; ABufSize: Integer);
+constructor TBufferedStreamImpl.Create( const AStream: IThriftStream; ABufSize: Integer);
begin
FStream := AStream;
FBufSize := ABufSize;
@@ -903,7 +903,7 @@
end;
end;
-constructor TStreamTransportImpl.Create( AInputStream : IThriftStream; AOutputStream : IThriftStream);
+constructor TStreamTransportImpl.Create( const AInputStream : IThriftStream; const AOutputStream : IThriftStream);
begin
FInputStream := AInputStream;
FOutputStream := AOutputStream;
@@ -967,7 +967,7 @@
{ TBufferedTransportImpl }
-constructor TBufferedTransportImpl.Create(ATransport: IStreamTransport);
+constructor TBufferedTransportImpl.Create( const ATransport: IStreamTransport);
begin
Create( ATransport, 1024 );
end;
@@ -977,7 +977,7 @@
FTransport.Close;
end;
-constructor TBufferedTransportImpl.Create(ATransport: IStreamTransport;
+constructor TBufferedTransportImpl.Create( const ATransport: IStreamTransport;
ABufSize: Integer);
begin
FTransport := ATransport;
@@ -1064,7 +1064,7 @@
FTransport.Close;
end;
-constructor TFramedTransportImpl.Create(ATrans: ITransport);
+constructor TFramedTransportImpl.Create( const ATrans: ITransport);
begin
InitWriteBuffer;
FTransport := ATrans;
@@ -1176,7 +1176,7 @@
{ TFramedTransport.TFactory }
-function TFramedTransportImpl.TFactory.GetTransport(ATrans: ITransport): ITransport;
+function TFramedTransportImpl.TFactory.GetTransport( const ATrans: ITransport): ITransport;
begin
Result := TFramedTransportImpl.Create( ATrans );
end;
@@ -1188,7 +1188,7 @@
FTcpClient.Close;
end;
-constructor TTcpSocketStreamImpl.Create(ATcpClient: TCustomIpClient);
+constructor TTcpSocketStreamImpl.Create( const ATcpClient: TCustomIpClient);
begin
FTcpClient := ATcpClient;
end;